Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3351260imm; Fri, 19 Oct 2018 09:10:32 -0700 (PDT) X-Google-Smtp-Source: ACcGV62CSq+iHnzGYWri2GTrUm2zg/OZdDDiipCdE0jOXchRPgssZkWoXO/2nHCt3Zi0/tDSSWKk X-Received: by 2002:a62:11cb:: with SMTP id 72-v6mr34877572pfr.120.1539965431946; Fri, 19 Oct 2018 09:10:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539965431; cv=none; d=google.com; s=arc-20160816; b=VHFZZgYiasRgvqJoh8jD+keHaMGpZoEyN5Bt7+hgTbA5qapuq7xF7noBTpFDSBVEX1 4pSLI4cXAWKaWN+RHGJPIh1O0AIMPk81KWdfdiJfaoSwEBy8Qyrdj5AVfPqo/teOg9Uu Cu8dRNuKOd/uvpB6NGH4Z6+u7VRe34pLCHcnyGJd6Sn9F/vsQAoPG7+/V2iHQz6lXBFy IYApURZnNvZRjSaCu8U2IVQJCCt0LsnCyYSeyesKlrKTD7AuKvVKHyoU8qXW2A3q8GR4 JwdnfRBRo4q9m8dRWgHm9J0/Ankd0LVH5TAxJ+gqN7q1f+2LzQoqGKx8rsPR2+0G7aOc aEzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=dsLXfaLWiIOGfI/4tSeP5DQ5iEvDOCdPLCQDZb5sWN0=; b=znCfzFu9KesulMUCV0f4dgAulb9TYFP2PkO/iE/qJfrZXKA9/k7nd7OJPrI8PpjuPd lirCvmohJGjtp0DoUzTy8/shH9+xs84bYhTf22OR60Uiz0MPCX8PUP6rOl1fRJFlG5vi P7mj8Xgdm6SJArI/SJrxZr2EucI8ATeTbwXwDSpJ2hT8u+cpcTcMiitDvkbCQkn7a/X0 MtyDXJDyKP29N0BgocRNmXtTs5X3sX7CqrtgKEiHjxxHPP104sGP07+otOr9YBr/8AJu cb7fRioAhx5mdW2rJI3tc84lG/vIYVzi4MT1F6Q7P+iaGC1+j9v1NZZkmNoHKFuGHtOZ NRxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=BvdaBSOT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r12-v6si24090525plo.269.2018.10.19.09.10.13; Fri, 19 Oct 2018 09:10:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=BvdaBSOT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbeJTANk (ORCPT + 99 others); Fri, 19 Oct 2018 20:13:40 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:41868 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727042AbeJTANj (ORCPT ); Fri, 19 Oct 2018 20:13:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dsLXfaLWiIOGfI/4tSeP5DQ5iEvDOCdPLCQDZb5sWN0=; b=BvdaBSOTRxbJjkSDAK5Mk6u8m hQUSPgGvdbaIuuiFDlV7vVu5WDTWe+2Guzg/h7oI/0dT06spD9McQlBBtj0E+eyTCyuomQbYuEpw+ kWfYL2m8N+qtbfWfef93GKMYyJnvC6Gli2YDt0nXrFEsWvOExO2eGNB7uARr1yxIfO908=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gDXI7-0000Oy-3h; Fri, 19 Oct 2018 16:06:23 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 8FB901122548; Fri, 19 Oct 2018 17:06:22 +0100 (BST) Date: Fri, 19 Oct 2018 17:06:22 +0100 From: Mark Brown To: Olivier Moysan Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com, benjamin.gaignard@st.com Subject: Re: [PATCH 1/1] ASoC: cs42l51: fix mclk support Message-ID: <20181019160622.GO5895@sirena.org.uk> References: <1539964595-23758-1-git-send-email-olivier.moysan@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XMHqbYJb993HXwLR" Content-Disposition: inline In-Reply-To: <1539964595-23758-1-git-send-email-olivier.moysan@st.com> X-Cookie: Obey all traffic laws. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XMHqbYJb993HXwLR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 19, 2018 at 05:56:35PM +0200, Olivier Moysan wrote: > Fixes: 5e8d63a726f8 ("ASoC: cs42l51: add mclk support") >=20 > The MCLK clock is made optional for cs42l51 codec. > However, ASoC DAPM clock supply widget, expects the clock to be defined > unconditionally. > Register MCLK DAPM conditionally in codec driver, > depending on clock presence in DT. I've applied this but TBH I think we should be doing this in the core - I actually thought we had handling for that but I can't see it so I'm obviously imagining things. It's something that can be done later anyway. --XMHqbYJb993HXwLR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlvKAP0ACgkQJNaLcl1U h9BF3Qf5AaeJZBaqJoRHji9hqrAa33wqz4EfrAdli0y2nm4Eq4cAeBoOyP757DH8 qzrJB810WvwHfsBEvWxkalsGBYb1wrWGh/zUpg0pmoJW4GbCAUYRxytBOrT6Dmx6 BOEkGD2qLqdLbhN1H2gFSu7D9dleu2SI0P49UjC7PsSnOgH0jMopaezI/upwZ57z u5AROw2BJtCtb+FUyepG7Igv/znfbydyGrkB34Ta3p4AZMmBih00WzKQePXxVeZr hROu2OnEBjBi7O7rTcbJ3VhSbSGAGcr713DKPHrliwizS43L0OffKA+RvuuE3Yy8 TxnPBm7bh24YUBeEeME01Y0qurc6ng== =wR4T -----END PGP SIGNATURE----- --XMHqbYJb993HXwLR--