Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3352304imm; Fri, 19 Oct 2018 09:11:17 -0700 (PDT) X-Google-Smtp-Source: ACcGV6070G2/+X4C6SItvGRT1NzSeSaQEpUB1ru8e3tIL2UkZCoGHk4hj1aoENTmvGk0hoQyGmuJ X-Received: by 2002:a17:902:760b:: with SMTP id k11-v6mr34962853pll.103.1539965477419; Fri, 19 Oct 2018 09:11:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539965477; cv=none; d=google.com; s=arc-20160816; b=qk3zWbE0QJsFZPnydSrWnr5MAoFi1L/4JHdbNztJVWCJn15k1MrrGqFQYx5gUoc/TA GXgVKBfBwxd442d2ym9Lq0hdJEtXDr8Dm3Ka7MhD5WQ4/DfPNM5LQbepS79Qjji8ag/E nvTM6iZ6gN2LKQLLDyXd3E9K5nXY6p92Mn9Zx6+xTh8bVH49wdbvAwnjjgDltUiObTrG HDxUsQUyCGeeJlQz6b2FggoB7c2HhsQ2F5W3u7wHQATh7cZ+Qbldavd58MtzS2qltORu CEAG+rSKFnt/dFxRHlZ6DBErR4LkGiI/eKLPRJqFCpbqf1eV7PhIhuCxjQryijFOtXIm LHGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Jc6pbtnbinMNt8RzK+UUZtfqLCLHaMqV+5/gYPRpVzE=; b=sJpAXzh1Vd6WfHuS3XWhZz4hVZ/o9WM35Ha6LWBXudvBLNaiqUTYZSG94SwAJy+vju cyYIeIUk9dBKQqfcXbTV34Wg6UGx76VN9U12AsPkwA/tWm1brQtXt0snx7k3AzBwizXr OvLSPSN9TIz7hYWWGxH8fre8+hxAq9yoHPmIZqFUN7/MAGeVh4zwaxWRCj21Y64uQ8B5 fNkIIWaLBLhCQNPQrqJZbIo+HBinMldl95lZ/7hGrDWDcvLnJpBWiOgJkiuBvbQ6qyUN j+XGs9p7yyuHF6S7ecYnd0/haH8RhMBni1IXLV/QXFPiQSDpNQYwn4Fue1/EnSIs+Zhs KC+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=w9gHLqVu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p6-v6si25215546pgp.243.2018.10.19.09.11.00; Fri, 19 Oct 2018 09:11:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=w9gHLqVu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727643AbeJTARS (ORCPT + 99 others); Fri, 19 Oct 2018 20:17:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:59170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727197AbeJTARR (ORCPT ); Fri, 19 Oct 2018 20:17:17 -0400 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D90CE21476; Fri, 19 Oct 2018 16:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539965432; bh=XxhNLthymnIFPnHMwqFaCxA9IGCUpdnIUE4qhaivIQ4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=w9gHLqVuqNPsctDlQ7tHtR6+vC16XXFbnwa3C/88PX6VU6kx7a3wOxSFriZvWNMvt d1RhducvH+/F81OdvtQ9YSTqH6XlJy9ZoQMgxn+APlZlCX5tSC2IDw5Oa7lgvM8roP qPzsTkU9VkeMFaZYCffuqorh3fOsjJMvJYYWfD5M= Received: by mail-qk1-f172.google.com with SMTP id g13-v6so1711531qke.8; Fri, 19 Oct 2018 09:10:31 -0700 (PDT) X-Gm-Message-State: ABuFfoiT/3oAqZp/qQQGcNc04RXcW/zjizRVgXvVXgXOILioWyE+HsTl bEUhnf9nXmaFwkeYeT2uAnSUPPXRNxSbRRqp7g== X-Received: by 2002:a37:9201:: with SMTP id u1-v6mr31342061qkd.29.1539965430939; Fri, 19 Oct 2018 09:10:30 -0700 (PDT) MIME-Version: 1.0 References: <1539657458-24401-1-git-send-email-frowand.list@gmail.com> <1539657458-24401-5-git-send-email-frowand.list@gmail.com> <20181018170931.GC15557@bogus> <780fb659-29e8-1ef4-4f62-97dacf36f6c8@gmail.com> In-Reply-To: <780fb659-29e8-1ef4-4f62-97dacf36f6c8@gmail.com> From: Rob Herring Date: Fri, 19 Oct 2018 11:10:19 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node() To: Frank Rowand Cc: Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer , "linux-kernel@vger.kernel.org" , linuxppc-dev , devicetree@vger.kernel.org, linux-fpga@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 18, 2018 at 2:09 PM Frank Rowand wrote: > > On 10/18/18 10:09, Rob Herring wrote: > > On Mon, Oct 15, 2018 at 07:37:24PM -0700, frowand.list@gmail.com wrote: > >> From: Frank Rowand > >> > >> "of: overlay: add missing of_node_get() in __of_attach_node_sysfs" > >> added a missing of_node_get() to __of_attach_node_sysfs(). This > >> results in a refcount imbalance for nodes attached with > >> dlpar_attach_node(). The calling sequence from dlpar_attach_node() > >> to __of_attach_node_sysfs() is: > >> > >> dlpar_attach_node() > >> of_attach_node() > >> __of_attach_node_sysfs() > > > > IIRC, there's a long standing item in the todo (Grant's) to convert the > > open coded dlpar code. Maybe you want to do that first? > > I'd like to avoid extra delays to getting the current (with necesary > fixes) series accepted because the series is rather intrusive and > could have conflicts with other patches. > > I'm also worried that I don't have access to any of the systems that > use the dynamic overlay code, and I don't have any way to test the > changes. Mainly I was thinking you are asking them to test changes now, so I was thinking better to do that once than twice. Either way is fine though. > Can we encourage the users of this code to convert the open coded > dlpar code? That would be ideal... Rob