Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 19 Oct 2018 20:30:57 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Peng Hao <penghao122@sina.com.cn>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org,
        Peng Hao <peng.hao2@zte.com.cn>
Subject: Re: [PATCH]  sched/fair : modify comment of fbq_type description
Message-ID: <20181019183057.GA31016@hirez.programming.kicks-ass.net>
References: <1539967494-12493-1-git-send-email-penghao122@sina.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1539967494-12493-1-git-send-email-penghao122@sina.com.cn>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Oct 19, 2018 at 12:44:54PM -0400, Peng Hao wrote:
> 
> From: Peng Hao <peng.hao2@zte.com.cn>
> 
> for type 'all', the comment 'there is no distinction' is vague.
> make it clearer.
> 
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>  kernel/sched/fair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index f808ddf..3a0543f 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -8304,7 +8304,7 @@ static struct rq *find_busiest_queue(struct lb_env *env,
>  		 * We classify groups/runqueues into three groups:
>  		 *  - regular: there are !numa tasks
>  		 *  - remote:  there are numa tasks that run on the 'wrong' node
> -		 *  - all:     there is no distinction
> +		 *  - all:     there are numa tasks that run on the 'right' node

No, that is actively wrong. Both the previous cases inlcude that.

If anything, it should be: all tasks are numa tasks and run on the
'right' node.