Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3507287imm; Fri, 19 Oct 2018 11:45:42 -0700 (PDT) X-Google-Smtp-Source: ACcGV60N6k1VVHnuV5nJtH+CqGD/Eq04OFLKVawzi646Rx914LjyxwgxK9rPAP+U9QqEWFw0V0ZH X-Received: by 2002:a65:5cc3:: with SMTP id b3-v6mr33641382pgt.277.1539974742546; Fri, 19 Oct 2018 11:45:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539974742; cv=none; d=google.com; s=arc-20160816; b=wcSrRmKdVWmFVhxBfEt7aOqJQ/A+A8dRFPIuDIMJIXbnPfg2CEe0rpT64c9leZXibA JIGEgWbfdWn61RcA2IEjty64JDkczmgik5/OwySuMnpYPK1O+P0wMbu0rPjxsTiy0UVK vCxul8WcN12368E4A+qXiylQ7EdY8VoGKp9NBbw6pHFmsc21peNF5A4HQ0Rm/DGMKZFx EzUhcli529b659fms8J0sb9q54pKBOhYNa0iUT9Fte1rVYOcRyvLVn5J07Zb/nZianux Gf0osPvGSp/uvj7eqw1lHb0JsvfKDTE/MZzDKvqBAljDq7UrIMJ8CLQx7J8ZIMGs5UnD qZUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date; bh=36RMnObaxrUTCIiHFISL4eDFTjKNMFJuHM4RH5zTLZE=; b=KwcG6kFi6Yj/22plLEItpc/aCHHX8cBv/dt+cduJ4n8RhKwkwDGB8lMQlpdWlpUp/d 2kdml+aoXLHCJNhz/RcXLbUZ8fyLCBnh74bdI4dUUugWQMqy7ztT3gQWzrTYSDbeEuWj 5itfF6n2zYTMLgGs1H9yOUmb/axRJqZ6CfzPYeS4Us3M1bq9mtudgLWZJKq2Jj4MEjPG oBfZd68mFSfm+p7XQfWV8B7HAS8ROlnbpTg1mIE4DiW3UU+kaUsq4PsPt0ewkx8fthub jK73swK+9Ebk9EKDCNux1CBUo5Lf/SYfu2XM2AKQ/IPzqjvK7ZGf+oLKUGKDbbJY02D0 X/MA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c3-v6si18795721pld.3.2018.10.19.11.45.26; Fri, 19 Oct 2018 11:45:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727772AbeJTCvu (ORCPT + 99 others); Fri, 19 Oct 2018 22:51:50 -0400 Received: from gateway23.websitewelcome.com ([192.185.50.161]:29858 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727705AbeJTCvu (ORCPT ); Fri, 19 Oct 2018 22:51:50 -0400 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 49BFFA9F8 for ; Fri, 19 Oct 2018 13:44:32 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id DZkzg2DIbaSeyDZl5gMMWv; Fri, 19 Oct 2018 13:44:31 -0500 X-Authority-Reason: nr=8 Received: from lfbn-1-466-13.w86-245.abo.wanadoo.fr ([86.245.173.13]:60794 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1gDZky-001Pga-0Z; Fri, 19 Oct 2018 13:44:20 -0500 Date: Fri, 19 Oct 2018 20:44:17 +0200 From: "Gustavo A. R. Silva" To: Bart Van Assche , Jens Axboe , Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] skd: fix unchecked return values Message-ID: <20181019184417.GA21154@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 86.245.173.13 X-Source-L: No X-Exim-ID: 1gDZky-001Pga-0Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: lfbn-1-466-13.w86-245.abo.wanadoo.fr (embeddedor) [86.245.173.13]:60794 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check return values of dma_set_mask_and_coherent(). Otherwise, if dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); fails, the following piece of code will be executed even when the call to dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); returns 0: dev_err(&pdev->dev, "DMA mask error %d\n", rc); goto err_out_regions; Addresses-Coverity-ID: 1474553 ("Unchecked return value") Fixes: 138126214868 ("skd: switch to the generic DMA API") Signed-off-by: Gustavo A. R. Silva --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 7c5fc69..2459dcc 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -3175,7 +3175,7 @@ static int skd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_out; rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (rc) - dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); + rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (rc) { dev_err(&pdev->dev, "DMA mask error %d\n", rc); goto err_out_regions; @@ -3364,7 +3364,7 @@ static int skd_pci_resume(struct pci_dev *pdev) goto err_out; rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (rc) - dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); + rc = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (rc) { dev_err(&pdev->dev, "DMA mask error %d\n", rc); goto err_out_regions; -- 2.7.4