Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp634972ima; Sat, 20 Oct 2018 15:25:18 -0700 (PDT) X-Google-Smtp-Source: AJdET5e2cAKa8Zl208gEhASzNNjrgd9xwh5c0Ekev/Ci2T8Cg84gu1S2BYSy7p+bQxfYSSIEAJb5 X-Received: by 2002:a65:4208:: with SMTP id c8-v6mr1980283pgq.335.1540074318867; Sat, 20 Oct 2018 15:25:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540074318; cv=none; d=google.com; s=arc-20160816; b=a6I/FWpatPXdL9zHx4I9zPbeLSsq2x/z3w/2iG9KY2WZTqB5bz7Z0SwLQ1+/MEQC7E gsbQmt36pkczCUMB/5jTelY0oEVOODVUubv3Xh/9SSZmEWCJbqmdsktmRv019rfky7Fb WwM84DsMbbmW3k8M5wmVy5F54eaaWq66wG3Rm61qVFW2PUPse9HXIc8QXF8kPcZ3B3cl rLrdgFjutZEOpdmkYxYZXPb4nNbbUw20FCrV4SXJG/MMfSOfMU3YyZ7ZwX2x7UTTvuLW Gi6tXM2MRdY9akqTNpZzmzkn9sGoe6eS1yP8x6E+Fc0mGsZbuwVaFUVbxQK3DSV4jb5b QhDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=VOpaiw0h6SSUdC7AEF1d75cT1KlkJgcOQwyEftiBPVU=; b=No3OgPUW99D7sIQUGsZvQ5MIvQ7XD/WiFtr0MJ2i1Z8V0b5Fg/T960wu86C97g3c3v cbMWL27tDJIjIqIvkGLqPP3zO1mmoX5r4EUIVtzbQC7f4dkmthouOesaLx/isl7aalYa +zzrKmjpIYyQhclxkbYK4jIoHe8Bfa2cvwOupS/vMWYEd7oj3sfTD6ONApNJX/U1HRtv u+MQdfmwrTLL6Y0WAHKRINSKMxvU3otz37J8uidM/C66BqXDToLvrv+3CiN0GeP2e6nq tUsWCcg8fMv+UYkebMDiM5XzadCAM+c+ItEtcC1ozstPRxAgBt4aDRX2KdyhqfIp5mzu P/Qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b=uCgKQDHz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u189-v6si7408013pgd.390.2018.10.20.15.25.04; Sat, 20 Oct 2018 15:25:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.de header.s=amazon201209 header.b=uCgKQDHz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727861AbeJUGgA (ORCPT + 99 others); Sun, 21 Oct 2018 02:36:00 -0400 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]:56397 "EHLO smtp-fw-6001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727173AbeJUGfB (ORCPT ); Sun, 21 Oct 2018 02:35:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1540074183; x=1571610183; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=VOpaiw0h6SSUdC7AEF1d75cT1KlkJgcOQwyEftiBPVU=; b=uCgKQDHztTCsfym9ImE+nJTM+GPdg2x+LZ0gkdvE43+rc1Hv9mOfuiH5 cOfzXKo3szoN/8h7t/R+SeDiJzTubi+ye+WVeT1fvcemqL2B2bolj8e7F KtkYx+Mfm4wMkZbBW6W9h2rg0HYccRV0OjFhfQUSNziNEEXHgrlcdWYfC 4=; X-IronPort-AV: E=Sophos;i="5.54,405,1534809600"; d="scan'208";a="364167582" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Oct 2018 22:23:03 +0000 Received: from u54e1ad5160425a4b64ea.ant.amazon.com (iad7-ws-svc-lb50-vlan2.amazon.com [10.0.93.210]) by email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com (8.14.7/8.14.7) with ESMTP id w9KMMuaO002668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 20 Oct 2018 22:22:58 GMT Received: from u54e1ad5160425a4b64ea.ant.amazon.com (localhost [127.0.0.1]) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Debian-3) with ESMTP id w9KMMt4w031654; Sun, 21 Oct 2018 00:22:55 +0200 Received: (from karahmed@localhost) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Submit) id w9KMMsaY031650; Sun, 21 Oct 2018 00:22:54 +0200 From: KarimAllah Ahmed To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, rkrcmar@redhat.com Cc: KarimAllah Ahmed Subject: [PATCH v3 11/13] KVM/X86: hyperv: Use kvm_vcpu_map in synic_deliver_msg Date: Sun, 21 Oct 2018 00:22:23 +0200 Message-Id: <1540074145-31285-12-git-send-email-karahmed@amazon.de> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1540074145-31285-1-git-send-email-karahmed@amazon.de> References: <1540074145-31285-1-git-send-email-karahmed@amazon.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use kvm_vcpu_map in synic_deliver_msg since using kvm_vcpu_gpa_to_page() and kmap() will only work for guest memory that has a "struct page". Signed-off-by: KarimAllah Ahmed --- v1 -> v2: - Update to match the new API return codes --- arch/x86/kvm/hyperv.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c index 8bdc78d..5310b8b 100644 --- a/arch/x86/kvm/hyperv.c +++ b/arch/x86/kvm/hyperv.c @@ -581,7 +581,7 @@ static int synic_deliver_msg(struct kvm_vcpu_hv_synic *synic, u32 sint, struct hv_message *src_msg) { struct kvm_vcpu *vcpu = synic_to_vcpu(synic); - struct page *page; + struct kvm_host_map map; gpa_t gpa; struct hv_message *dst_msg; int r; @@ -591,11 +591,11 @@ static int synic_deliver_msg(struct kvm_vcpu_hv_synic *synic, u32 sint, return -ENOENT; gpa = synic->msg_page & PAGE_MASK; - page = kvm_vcpu_gfn_to_page(vcpu, gpa >> PAGE_SHIFT); - if (is_error_page(page)) + + if (kvm_vcpu_map(vcpu, gpa_to_gfn(gpa), &map)) return -EFAULT; - msg_page = kmap_atomic(page); + msg_page = map.hva; dst_msg = &msg_page->sint_message[sint]; if (sync_cmpxchg(&dst_msg->header.message_type, HVMSG_NONE, src_msg->header.message_type) != HVMSG_NONE) { @@ -612,8 +612,8 @@ static int synic_deliver_msg(struct kvm_vcpu_hv_synic *synic, u32 sint, else if (r == 0) r = -EFAULT; } - kunmap_atomic(msg_page); - kvm_release_page_dirty(page); + + kvm_vcpu_unmap(&map); kvm_vcpu_mark_page_dirty(vcpu, gpa >> PAGE_SHIFT); return r; } -- 2.7.4