Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 21 Oct 2018 20:41:33 +1100
From:   Aleksa Sarai <cyphar@cyphar.com>
To:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Robert Richter <rric@kernel.org>,
        Brendan Gregg <bgregg@netflix.com>
Cc:     linux-kernel@vger.kernel.org, oprofile-list@lists.sf.net
Subject: Re: [RFC] Merging ftrace_stack, perf_callchain, oprofile->backtrace
 and stack_trace
Message-ID: <20181021094133.nvqhs73khwx2xe4a@ryuk>
References: <20181021093106.mhjpb2rnx6kstjki@ryuk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ustoeia7qk475mn7"
Content-Disposition: inline
In-Reply-To: <20181021093106.mhjpb2rnx6kstjki@ryuk>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ustoeia7qk475mn7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2018-10-21, Aleksa Sarai <cyphar@cyphar.com> wrote:
> However, in working on this patch, I've noticed that there appear to be
> several different implementations of "get the stack trace from this
> pt_regs" which all appear quite similar. Namely:
>=20
>   * struct ftrace_stack;

Sorry, I made a mistake here. ftrace_stack *does* use stack_trace under
the hood, and so it can be easily modified to use the saved kretprobe
stack. The only issue is with perf_callchain_entry (which affects
bpf_get_stack).

--=20
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

--ustoeia7qk475mn7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEXzbGxhtUYBJKdfWmnhiqJn3bjbQFAlvMSc0ACgkQnhiqJn3b
jbTuphAAkiKfKR9J5ssmyXI+RCDaxUD/54cJIy8sN2E45o2FnQZ7MOzLS8dNk4OK
ZNsYcOM8/TkA/rsrDfFqdqk6dfzFRbRwu3kAxDqDwmGVEmMWaRUZ/tpvijpEXYYI
KJ+U1hT8rd6yRL+QaGqswi0PylEMm8yo/PnGGyb7cVj8Exc7GKeg2dast5DE3kTE
X82Az5h5SHDHGrE/o59WW7vhpHETeDdf1Qb7acVPa5X+4S/nE/ss5mvlBWiSa9Xx
Sw/32ZCwKpflcXsM+KLrj7nGuJXA9T2pir5Q60dwihwjFMzOx+AR4+zGF9Co/AB8
jcr8aYHNuUnbDrzh1ZHeKLFXzwoq4kMQq7YmkIq6JDuj3f+X8qpLY0BLnnO2PMmd
DyRkGDQja7EWGQP2yUfBZYILe1HkE8EH0LF0bpWcS38DcpXTjG8hGxMPqgxVIiBa
0ejPKwT3yJNON9ngg7ja5XebDLC5Y8IXFNm2lcq1miglJSt8zC1MZCCgBw/Mx6y8
cO9joIIoUlKc+2pRWRJ5tVeYu4jM3G7S+PRg5Voh/yxs1+InlMw7QskuSZwBg9lM
ivtySt6Uih43/JfYd0NP4ICYUPVcc4/CBugGbXu+rqHXRJZli8zaVpRAXn6T/r+A
rgO8FclHNE9aDd8dACHXxUaoZ8yKweaKQfAVeSWbu/Hg8EbyJzs=
=+R3e
-----END PGP SIGNATURE-----

--ustoeia7qk475mn7--