Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 21 Oct 2018 12:23:01 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Jon Hunter <jonathanh@nvidia.com>
Cc:     Marcel Ziswiler <marcel@ziswiler.com>, alsa-devel@alsa-project.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node
 assignement
Message-ID: <20181021112301.GC8554@sirena.org.uk>
References: <20181018111829.27056-1-marcel@ziswiler.com>
 <20181018111829.27056-4-marcel@ziswiler.com>
 <e25a7463-9ce0-d7f9-e77b-2bbaab2e0b25@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CblX+4bnyfN0pR09"
Content-Disposition: inline
In-Reply-To: <e25a7463-9ce0-d7f9-e77b-2bbaab2e0b25@nvidia.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--CblX+4bnyfN0pR09
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Oct 19, 2018 at 11:22:46AM +0100, Jon Hunter wrote:

> Looking at snd_soc_init_platform(), it seems that the platform pointer
> can be allocated by the machine driver and so if it is not allocated by
> the core, then I don't think we should clear it here. Seems we need a
> way to determine if this was allocated by the core.

Indeed, this is a bit of a mess.  We probably shouldn't be modifying the
data that the drivers passed in, otherwise we get into trouble like
this.   That suggests that we should copy the data, probably all of it.
I will try to have a proper look at this next week.

> Furthermore, it seems that it is possible that there is more than one
> link that might be to be cleared.

Yes, that's an issue as well.

--CblX+4bnyfN0pR09
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlvMYZQACgkQJNaLcl1U
h9Btfwf/dFxAtQI/Mhc7ISVGXuzVPNSrMX9GIpvPLgmAYOMav0sAv/Hwuc5l8yQn
lezhE0TDqs7mjjnBcjSkNlMX+8DRzlr/ROGKmnew4bQUwww+rEex1damDp6JS3b2
fdYqhq42yAVjh09z3ofdX8oa3Y3glbNAp3zR527TajqzSZHOpUOMAFJBxCByDQGH
+8JNd5A7LsccEA29oKULq6OnlsthVbLNEhirU8SE1qaUSadHAZLB8o5IQRmIGnIH
2SmmerTwmMCQE5AHwo0H5HY5M/h6wGYlDNJK2n2mSKohDvN4hKiFBb8lhFb+K15Y
V1l48FNy1pCQpsD7aeTSHFBmh3XhRg==
=q3BQ
-----END PGP SIGNATURE-----

--CblX+4bnyfN0pR09--