Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180625161303.7991-1-federico.vaga@cern.ch> <20180625161303.7991-3-federico.vaga@cern.ch>
In-Reply-To: <20180625161303.7991-3-federico.vaga@cern.ch>
From:   Peter Korsgaard <jacmet@sunsite.dk>
Date:   Sun, 21 Oct 2018 16:12:10 +0200
Message-ID: <CACXmViZZ3SBPbV4AXK6EsJPfD5TJqEU_-Q36+vz5LxTk_pzq4A@mail.gmail.com>
Subject: Re: [PATCH 2/3] i2c:ocores: do not handle IRQ if IF is not set
To:     Federico Vaga <federico.vaga@cern.ch>
Cc:     linux-i2c <linux-i2c@vger.kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 25, 2018 at 6:14 PM Federico Vaga <federico.vaga@cern.ch> wrote:
>
> If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
> - the line can be shared with other devices
> - it can be a spurious interrupt
>
> To avoid reading twice the status register, the ocores_process() function
> expects it to be read by the caller.
>
> Signed-off-by: Federico Vaga <federico.vaga@cern.ch>

Looks good.

Acked-by: Peter Korsgaard <peter@korsgaard.com>

-- 
Bye, Peter Korsgaard