Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp1864555ima; Sun, 21 Oct 2018 23:12:48 -0700 (PDT) X-Google-Smtp-Source: ACcGV63JKPmZ2tMT7qCJzut57y3g8CP6u+AeQQ2g/MyOlz61U2iHKoVwBesDO4/1Afnt049uud3J X-Received: by 2002:a63:4045:: with SMTP id n66-v6mr19047992pga.244.1540188768530; Sun, 21 Oct 2018 23:12:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540188768; cv=none; d=google.com; s=arc-20160816; b=HNGR9EhKVT3PFLzJsD9GeaNM5RTeOFavrpYW+eP7KI3Zb+Q20DfIkcf1yZlJVUtt6l JlSrF81x/ca6vwGNjiIGEsMkIyGcN4pO1IYXlWUt2/7vzy6mAZxcAlVp02YpeqF5W2CH 6RlacIY1dDD6sooYxp0+lo1c6pF5tQqxgX6sVa82pmFM0bGPHRwwR9cZOpF862Xhpezr NO1x2LMRbJz+C8aFfnmObXqi/s9o0aJFmCidFrgBv/bafqbunff1dQ8yLUY4ekXjuEw4 GgBQxgxZ4aq/ZDiatngO+TDo3VDLVtnXJw5rqvx0Nl02GvxykiWW5u2f4NuLaH/chiTp RviQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=BYyyvi/VaILsseW1EDGNSh8LVoqGPjroy86wFFrKcgU=; b=Hhimb0KTtFvfwfezjpbKlGqqe1/5a1ZtuoQdOtZPLLyvLjZwJ+CWPHdBzajIlamkRT aTU/nDeGxsL8gheIaZBuHNtgPyyXGbtRDLpvuBqNOpPf3Bs9U0tgpufFmxag8L5lhbQj pzdgOOTI35r46FXm9EM5VzVUJL64mF7YQoEYRH5/seMgDrynLNqbRM37JkGmsdbRLHDC vEDkElM7vok5ViP0Lnl+mqFi5GDWF/jngFfwduRK3YE+Oxc5515/99TbN9xdcD2u4Zgi FBQfOZcslcqJgdFP4riyZGmNR6vgXlOkAqdScfACInbrU4WWUuE+7QRkrdV4mJb9cKZq n+nA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si35215463plk.294.2018.10.21.23.12.33; Sun, 21 Oct 2018 23:12:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727543AbeJVOQg (ORCPT + 99 others); Mon, 22 Oct 2018 10:16:36 -0400 Received: from mail-sh2.amlogic.com ([58.32.228.45]:36767 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727322AbeJVOQg (ORCPT ); Mon, 22 Oct 2018 10:16:36 -0400 Received: from [10.18.29.185] (10.18.29.185) by mail-sh2.amlogic.com (10.18.11.6) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 22 Oct 2018 13:59:18 +0800 Subject: Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver To: Stephen Boyd , Jerome Brunet , Neil Armstrong CC: Yixun Lan , Kevin Hilman , Carlo Caione , Michael Turquette , Rob Herring , Miquel Raynal , Boris Brezillon , Martin Blumenstingl , Liang Yang , Jian Hu , Qiufang Dai , Hanjie Lin , Victor Wan , , , , References: <1539839245-13793-1-git-send-email-jianxin.pan@amlogic.com> <1539839245-13793-4-git-send-email-jianxin.pan@amlogic.com> <153988282130.5275.17528969137837015544@swboyd.mtv.corp.google.com> <01d07c83-b17e-70b5-6e9b-8150ee3aedf2@amlogic.com> <153997220960.53599.2059896905852359614@swboyd.mtv.corp.google.com> From: Jianxin Pan Message-ID: <9ddb0f0f-994c-b743-99cd-05ec094a6afc@amlogic.com> Date: Mon, 22 Oct 2018 13:59:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <153997220960.53599.2059896905852359614@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.18.29.185] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/10/20 2:03, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-19 09:12:53) >> On 2018/10/19 1:13, Stephen Boyd wrote: >>> Quoting Jianxin Pan (2018-10-17 22:07:25) >>>> diff --git a/drivers/clk/meson/clk-regmap.c b/drivers/clk/meson/clk-regmap.c >>>> index 305ee30..f96314d 100644 >>>> --- a/drivers/clk/meson/clk-regmap.c >>>> +++ b/drivers/clk/meson/clk-regmap.c >>>> @@ -113,8 +113,25 @@ static int clk_regmap_div_set_rate(struct clk_hw *hw, unsigned long rate, >>>> clk_div_mask(div->width) << div->shift, val); >>>> }; >>>> >>>> -/* Would prefer clk_regmap_div_ro_ops but clashes with qcom */ >>>> +static void clk_regmap_div_init(struct clk_hw *hw) >>>> +{ >>>> + struct clk_regmap *clk = to_clk_regmap(hw); >>>> + struct clk_regmap_div_data *div = clk_get_regmap_div_data(clk); >>>> + unsigned int val; >>>> + int ret; >>>> + >>>> + ret = regmap_read(clk->map, div->offset, &val); >>>> + if (ret) >>>> + return; >>>> >>>> + val &= (clk_div_mask(div->width) << div->shift); >>>> + if (!val) >>>> + regmap_update_bits(clk->map, div->offset, >>>> + clk_div_mask(div->width) << div->shift, >>>> + clk_div_mask(div->width)); >>>> +} >>>> + >>>> +/* Would prefer clk_regmap_div_ro_ops but clashes with qcom */ >>> >>> We should add a patch to rename the symbol for qcom, i.e. >>> qcom_clk_regmap_div_ro_ops, and then any symbols in this directory >>> should be meson_clk_regmap_div_ro_ops. >> "/* Would prefer clk_regmap_div_ro_ops but clashes with qcom */" >> This comment is not introduced in this patch. >> I followed the naming style in this file and add clk_regmap_divider_with_init_ops. >> >> @Jerome, What's your suggestion about this? > > Yes you don't need to fix anything in this series. Just saying that in > the future we should work on cleaning this up. > OK. Thank you! > . >