Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp2006704ima; Mon, 22 Oct 2018 02:31:56 -0700 (PDT) X-Google-Smtp-Source: ACcGV61lSzor6jjYydh/cEoZRe9aobM0IWETdE4qSqz5iEv1KdWRYr52XrDXudbRcmlyiLmJhvOS X-Received: by 2002:a17:902:5e3:: with SMTP id f90-v6mr45089437plf.286.1540200716546; Mon, 22 Oct 2018 02:31:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540200716; cv=none; d=google.com; s=arc-20160816; b=WV2YYVRk0aGI08Rgi2ZhDErlwmqJiP8utQbi4XOGo0qLP0VoowAWHTNPSHXaEm8aas fG55o2h8oZJKl7Wu9x/16tVxArhujCe0iqY4X1nUjcksHQFWzWHvCKjxtVRCR2EQOri0 PhRmVHuB5seyk/vnH+bUHBD25BF9TOdI/iDTunduqlLIdue3sHATEAXfvvmWNfEeWPxN c84aNyMAUVVdfWRTA6tDTX4pEr9F2MH86agzD0q37Sl9naTt58d0eojkYzIZS+TYj08A XDgf97I6NqfRpHdlD9lLlk46kZBeMLdyI1j1A0pZgCoG7Ninatjw8PiHLXdHvDHapHPp qctQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=TgYV21L+Uxk+9jWdZh3WvrG0c3Ac2VYw9fXWO94+ex4=; b=oC2U2YygDrkFQ93YpcbhVW0w4hRfcyv68veZ5uXmIDfsgPXj9EF3AaV9FLxITxPXk/ I8vsQomfmkQebS4NLFmWF/t+RFwuqI4aSXfLRgnCN2QzUlq4YwPEHnwToc4sjnZz0Wbq rp1GZtvO3WtWbFTeUP/FGL44uzZKA+Se/Ojz1K/6qYsyPUuBNjAZYT4W3+k9h3nNbcg8 P02yiUoiFCJMneulM7ykt5hd6jnlMLxmL3+I1zlA44fBA4NwqG+K1wMkjxMx8aRUASWL eFTrAUUTarysnvnvLtmABQfROHoCRNt2a4MQCsuj/oFleCgoWSOenRwJr8QmdiK6hnRL zsHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 16-v6si39130523pfc.21.2018.10.22.02.31.41; Mon, 22 Oct 2018 02:31:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728237AbeJVRdg (ORCPT + 99 others); Mon, 22 Oct 2018 13:33:36 -0400 Received: from mail.bootlin.com ([62.4.15.54]:44073 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727218AbeJVRdg (ORCPT ); Mon, 22 Oct 2018 13:33:36 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 6DCFC208C7; Mon, 22 Oct 2018 11:15:53 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from bbrezillon (aaubervilliers-681-1-25-52.w90-88.abo.wanadoo.fr [90.88.145.52]) by mail.bootlin.com (Postfix) with ESMTPSA id 0D7442079D; Mon, 22 Oct 2018 11:15:43 +0200 (CEST) Date: Mon, 22 Oct 2018 11:15:43 +0200 From: Boris Brezillon To: Yogesh Narayan Gaur Cc: Tudor Ambarus , "richard@nod.at" , Mark Brown , "linux-kernel@vger.kernel.org" , "nicolas.ferre@microchip.com" , "marek.vasut@gmail.com" , "cyrille.pitchen@microchip.com" , "linux-mtd@lists.infradead.org" , "Cristian.Birsan@microchip.com" , Cyrille Pitchen , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories Message-ID: <20181022111543.2a607efc@bbrezillon> In-Reply-To: References: <20180911154007.17195-1-tudor.ambarus@microchip.com> <20180911154007.17195-2-tudor.ambarus@microchip.com> <31a8f6a9-1459-443a-6ef8-2b2c17769ae4@microchip.com> <20181017090724.12f2cd79@bbrezillon> <20181017091045.124e0266@bbrezillon> <20181017092941.3658bd9a@bbrezillon> <20181017115237.07310b74@bbrezillon> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Oct 2018 06:04:13 +0000 Yogesh Narayan Gaur wrote: > - /* Find the matching configuration map */ > - while (SMPT_MAP_ID(smpt[i]) != map_id) { > - if (smpt[i] & SMPT_DESC_END) > - goto out; > + if (map_id_is_valid) > + pr_info("%s:%i map_id=%d\n", __func__, __LINE__, map_id); > + else > + pr_info("%s:%i NO map_id\n", __func__, __LINE__); > + > + for (nmaps = 0; nmaps< smpt_len; nmaps++) { Why did you change this for loop? > + if(!(smpt[nmaps] & SMPT_DESC_TYPE_MAP)) > + continue; > + > + if(!map_id_is_valid) { > + if (nmaps) { With your change in the for () block, this test is no longer valid... Please keep the original patch and patch the if () condition as suggested. > + ret = NULL; > + break; > + } > + > + ret = smpt+nmaps; > + } else if (map_id == SMPT_MAP_ID(smpt[nmaps])) { > + ret = smpt+nmaps; > + break; > + } > + > /* increment the table index to the next map */ > - i += SMPT_MAP_REGION_COUNT(smpt[i]) + 1; > + nmaps += SMPT_MAP_REGION_COUNT(smpt[nmaps]) + 1; > } > > - ret = smpt + i; > /* fall through */ > out: > nor->addr_width = addr_width;