Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp2032731ima; Mon, 22 Oct 2018 03:04:54 -0700 (PDT) X-Google-Smtp-Source: ACcGV6271uxaRpAvCPmcF2CG0H9SJt06XKIpOkMYdoemQpCF6rfxqQyUWqGoOPZ/W3qGgwkSKan8 X-Received: by 2002:a62:cfc4:: with SMTP id b187-v6mr36047466pfg.249.1540202693945; Mon, 22 Oct 2018 03:04:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540202693; cv=none; d=google.com; s=arc-20160816; b=buUnrnIa2+V9KFhr7h168VCLXW9lGm0w3Qj9COsdtw3RhC8gPfan4fc8EvfPryV1gZ TIPuXn0503aUCK0id7bPelmH5QyxCEv79SjMKaxTRr2LuL5oViPcY99Rd1YkH7SW+Soy Vmgks8joINkuv3+TeZojTyqdNTQvmGUo3ep0dj6nCcw2PwVcBsDhuoF81J4k5eneNKIH uaD/VsO8W2e/ATrM0UNEOzlY8zIgTA1QdvrhGt5E63eiCPPr8Lu7CCeEN4+zmF498KZ/ l9kbScgZ5e4FpCKsDR5oUIMMITGdEzumn+XixBNrQJT70MsFSLiYU7O2pB8royPpqqKj CHTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=J8hKjGL9XnVpHdgJh2lZBsuf0iZHIAAdkctiupTtcM0=; b=sAYiyGN1p0SVHaDvXqV8GVA2D38PuuFqRRJBHd85uXAYqLfFqFO9H7X0N1vkIE+HsJ X2C2lYx+seOkLL6h6K0e/9s/I7nvPf91p5+Ky86kExKNU7hX9x/CyKGcp7FgBLbehDes K5RvxI4yHChGRJI+kUhdoVC2dClqK6wbnsYBbL86VjaD8uFcDjm/tcWIpf9nO6jsardX LBqVFmpW2BB09CZJqBPsFmYFswqYvzt4PL5AdTUwv0fyaB0flRL7Q7MlHqBvWyUnMDzo NRZ2fbx2IG8bn1Q97j34QGwmm4KngTVXAUAinwkf6BQIGXYSeNUWgRHlH5CEf8hs75s/ y3Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Mmv15kBq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x16-v6si33405801pgh.41.2018.10.22.03.04.36; Mon, 22 Oct 2018 03:04:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Mmv15kBq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728251AbeJVRem (ORCPT + 99 others); Mon, 22 Oct 2018 13:34:42 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:43893 "EHLO mail-qt1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727584AbeJVRel (ORCPT ); Mon, 22 Oct 2018 13:34:41 -0400 Received: by mail-qt1-f181.google.com with SMTP id q41-v6so45382861qtq.10 for ; Mon, 22 Oct 2018 02:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=J8hKjGL9XnVpHdgJh2lZBsuf0iZHIAAdkctiupTtcM0=; b=Mmv15kBqJB6K0IKzn027xvDs1elCxbhM9rfAP/qprdpykjT4p4K5gAMhXE4k7o3APc CvYkR20u5NtBbUoQQDofZD2j4ry4+FNGH3dDELtz516BsHuUWxy/rj/z4diJUpAqon2F gE9u9Y5JtKD5H8+FXXzij1XfyJPc2yUxzFRl8vltpEV5wA74psvsBMw5EKUWX2AudtVh a8KJVDYTvfmyvGZvK5Qw+aMvSDSsGxmrHUY00xn6FB1eAxh3kMryylGaSJSuO1c8PBkj hQzxS8eh5TfV6iB6/httUIvatQxvTgRO5SHjza8rm7apqimzjPV8/zpyEVPkdVRu6yHv 5ZEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J8hKjGL9XnVpHdgJh2lZBsuf0iZHIAAdkctiupTtcM0=; b=VVk/p8w3TB8PqVMbZoWgW27tMEUjSewVFgiaGh/ZzBsRX9ExrWm435E6x4urXcC8YA jUO/XpyWqjsdwlxwdeoGsv37+AlkPakTyIBRfnhtVuyL4wX1rSBroh155GAqjjUONqgD r35FQSjvApjQ/9nbsTzrzzIbklBUBma8E8rVcSr7SLTZZ8Pz9bI2c63VaGlFZVx/qn+V Vm9u1c3iPd4aKDJ3MyJ43/HzkDKbkUHiWHz+0vkgywAD3WCpmC8JNpr2204+vVWvIDw3 jQAM1DVwT7U9AO+fMCXZAVXhboxJwRNMoywhSUlEreHOkDbloH9Zs6iil1c4beL0FXKV F+Kw== X-Gm-Message-State: ABuFfohNpC4Z4f1psfVJuYID4LABGyjMrKWg6zZTaRr6yjQvCbRbKChd aOLjAXYe5wRy/XBwNXUHTcWdrqZ0r40= X-Received: by 2002:a0c:b5ed:: with SMTP id o45-v6mr28996215qvf.12.1540199820348; Mon, 22 Oct 2018 02:17:00 -0700 (PDT) Received: from [172.20.10.3] (mobile-166-172-59-201.mycingular.net. [166.172.59.201]) by smtp.gmail.com with ESMTPSA id 5-v6sm5327437qtz.8.2018.10.22.02.16.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 02:16:59 -0700 (PDT) Subject: Re: [PATCH] skd: fix unchecked return values To: "Gustavo A. R. Silva" , Bart Van Assche , Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20181019184417.GA21154@embeddedor.com> From: Jens Axboe Message-ID: Date: Mon, 22 Oct 2018 03:16:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181019184417.GA21154@embeddedor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/18 12:44 PM, Gustavo A. R. Silva wrote: > Check return values of dma_set_mask_and_coherent(). > > Otherwise, if dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); > fails, the following piece of code will be executed even when the call > to dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); returns 0: > > dev_err(&pdev->dev, "DMA mask error %d\n", rc); > goto err_out_regions; Applied, thanks. -- Jens Axboe