Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp2040649ima; Mon, 22 Oct 2018 03:13:51 -0700 (PDT) X-Google-Smtp-Source: ACcGV62B2uKMgNaIA/MW+93DfQkK7szMUClGf0ziSNiunjQm+vLchLxo2q171q/9W66ydKDbUrr3 X-Received: by 2002:a62:7e81:: with SMTP id z123-v6mr44919189pfc.139.1540203231811; Mon, 22 Oct 2018 03:13:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540203231; cv=none; d=google.com; s=arc-20160816; b=fP358qswiPtxyYUKi7w9uUum0Xa2TIZ84NCEVSQv5EhCYd5QouBEbKY4sy/FweNoN0 UoZc2sGOcjXgXrPVUjbRpOE53UqO/P6JlYHLEdzdZLVv6sja514IceMUNADSGMNSA/+2 +4geWizr/WFclv9SBXu7Wz1IXLR4ufhUZf6zH4vGSNM2KLMxHtg+Bgc0FN3etlERajBv K4K04kg0WxwgpLuIiahtPs9V+FjMnzjCg4BlzwqmRPThqbihvIwz7t6vtFbUyjXb34L4 aXWMPmKzUButEb6yj4ymMo5SHrIGN3k9GL152f9wJ97VkO66tVkyktOGeWo6gFIpnQwA 7C9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=hdslxpS74+unfKK4SFwGWQQWL6YcxUuijb0tqyxkRB0=; b=le1UTZ6UQQKUv7tLqf+RzfkrBCMvYDdqPTGA4ctJq3UqfWbKRy2utWGoIwi1izIQ9o G6tpDuE4K4Zf15dYIDsAuDLWYtzYzDW9nuD6zuJrB5Jj0MJEIpiM1gnh7rT18o1NfGm1 KqNiipnrXYQe2XCORWhhgLHhELdoz9hD3oJipys2FrwnJVYvkz+xq0b0nPGTXURmRfn2 41dtST2tooq3JA7ExtGI+g3wQCKOIGwpLxN/HE0B/C4SIFUFoLbn7POOE7BU3+DfB0pD rT2kvfrzJLJkoNVNRT+AmwOolHhfj6LXNiaAsNQSBeIpPMnx7Zous+de0hx9CtV3xSnX VShQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 101-v6si36640230ple.326.2018.10.22.03.13.36; Mon, 22 Oct 2018 03:13:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728334AbeJVRzO (ORCPT + 99 others); Mon, 22 Oct 2018 13:55:14 -0400 Received: from ozlabs.org ([203.11.71.1]:39869 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727519AbeJVRzO (ORCPT ); Mon, 22 Oct 2018 13:55:14 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 42dryv3v1yz9sDC; Mon, 22 Oct 2018 20:37:27 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: daf00ae71dad8aa05965713c62558aeebf2df48e In-Reply-To: To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , npiggin@gmail.com From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: powerpc/traps: restore recoverability of machine_check interrupts Message-Id: <42dryv3v1yz9sDC@ozlabs.org> Date: Mon, 22 Oct 2018 20:37:27 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2018-10-13 at 09:16:22 UTC, Christophe Leroy wrote: > commit b96672dd840f ("powerpc: Machine check interrupt is a non- > maskable interrupt") added a call to nmi_enter() at the beginning of > machine check restart exception handler. Due to that, in_interrupt() > always returns true regardless of the state before entering the > exception, and die() panics even when the system was not already in > interrupt. > > This patch calls nmi_exit() before calling die() in order to restore > the interrupt state we had before calling nmi_enter() > > Fixes: b96672dd840f ("powerpc: Machine check interrupt is a non-maskable interrupt") > Signed-off-by: Christophe Leroy > Reviewed-by: Nicholas Piggin Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/daf00ae71dad8aa05965713c62558a cheers