Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp2667896ima; Mon, 22 Oct 2018 13:48:28 -0700 (PDT) X-Google-Smtp-Source: AJdET5dmpr5i+WNrs5icHi+Cu0O3d4jdAhJbXaBe1573D/EzmBwBPiXNzlw6FwMvxXJCyFG6AYU0 X-Received: by 2002:a17:902:9004:: with SMTP id a4-v6mr3382199plp.334.1540241308396; Mon, 22 Oct 2018 13:48:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540241308; cv=none; d=google.com; s=arc-20160816; b=i25RNxm9lkQgS8xJXaStVonPKOmAMaHENagUdnjHUvi13PG2R/f6lfS9kLhNbkDc/k 5VKh/ZJThEAk9kLszsurwGRNkrBvW0yeRl6fgcR7CkyTgSMo/Y5wCy2Z1Oj0jmHXFdzy +oA+ikOXPv/YDHKOhwqrfxKxTyr8e/n56SpdLNKlZ7mtZBx6xCEbe0t8n7HBPBscBRSA NUinDbpr6nrrw3gJEi1BQXbjVW7z8kPKq3p5GHQ6Jhsf+L3CogMF15uEM/BekO78qQdg YFGA+j36k6KzSuy3pvirOuVll81FhT4p3UZ3LzLIErFWFCQAUBHs4jGnGjK8NCZqJueC E/cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=A9bOyAhDPf1xxfkhksQkvqzGEC53FBoyW1azMWssZT0=; b=SyC7fJVhB5J50dGslHLOqSn2zA6Eu7YzRypa/FCIhdkM8BpuxamF0H4uvd6ntJD0Vq QwbdcdspwKGeHvMWDDIQHfw9ICYWvhUE7KQeij9RwCOAIaOErXSouIP0sNYYZWlhGRig hfeFuuODdEbcLSDwKWlwq6HJdfJ07YzhM7iWALhA4vPAa3zM0i0R/fc+lmJAIkAAU3gh merSUBBX1Ad6fEaaIxdegb4KK+j+Mm3xRYDTt5+zo/cSj6Z8YlUDD+GroXJEPFAZuBkD ycsVUU0ouW0xECwXO2Zazm0VOuce5VeXLeZqfxmY8E6UFXqE7y9ls1afJnedjD3tPlLj 5/Ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w15-v6si34222252pgg.529.2018.10.22.13.48.12; Mon, 22 Oct 2018 13:48:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729078AbeJWFGU (ORCPT + 99 others); Tue, 23 Oct 2018 01:06:20 -0400 Received: from gateway36.websitewelcome.com ([192.185.184.18]:29978 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbeJWFGU (ORCPT ); Tue, 23 Oct 2018 01:06:20 -0400 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 33F824014FC17 for ; Mon, 22 Oct 2018 14:53:38 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id Eh5TgYqDLBcCXEh5YgnwLh; Mon, 22 Oct 2018 15:46:15 -0500 X-Authority-Reason: nr=8 Received: from lfbn-1-466-13.w86-245.abo.wanadoo.fr ([86.245.173.13]:51064 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1gEh5S-0025do-ER; Mon, 22 Oct 2018 15:46:06 -0500 Date: Mon, 22 Oct 2018 22:46:03 +0200 From: "Gustavo A. R. Silva" To: Stanislaw Gruszka , Helmut Schaa Cc: Kalle Valo , linux-wireless@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH 16/20] rt2x00: rt2800lib: mark expected switch fall-throughs Message-ID: <85711e291a870ba4a36373bcbdcc3eb2f7d3171f.1540239684.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 86.245.173.13 X-Source-L: No X-Exim-ID: 1gEh5S-0025do-ER X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: lfbn-1-466-13.w86-245.abo.wanadoo.fr (embeddedor) [86.245.173.13]:51064 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 117 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 145198 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c index 9e7b893..0e95555 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c @@ -2482,6 +2482,7 @@ static void rt2800_config_channel_rf3052(struct rt2x00_dev *rt2x00dev, switch (rt2x00dev->default_ant.tx_chain_num) { case 1: rt2x00_set_field8(&rfcsr, RFCSR1_TX1_PD, 1); + /* fall through */ case 2: rt2x00_set_field8(&rfcsr, RFCSR1_TX2_PD, 1); break; @@ -2490,6 +2491,7 @@ static void rt2800_config_channel_rf3052(struct rt2x00_dev *rt2x00dev, switch (rt2x00dev->default_ant.rx_chain_num) { case 1: rt2x00_set_field8(&rfcsr, RFCSR1_RX1_PD, 1); + /* fall through */ case 2: rt2x00_set_field8(&rfcsr, RFCSR1_RX2_PD, 1); break; @@ -9457,8 +9459,10 @@ static int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev) switch (rx_chains) { case 3: spec->ht.mcs.rx_mask[2] = 0xff; + /* fall through */ case 2: spec->ht.mcs.rx_mask[1] = 0xff; + /* fall through */ case 1: spec->ht.mcs.rx_mask[0] = 0xff; spec->ht.mcs.rx_mask[4] = 0x1; /* MCS32 */ -- 2.7.4