Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5BCEDA77.9010505@huawei.com>
Date:   Tue, 23 Oct 2018 16:23:19 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     Pkshih <pkshih@realtek.com>
CC:     "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: remove set but not used variable 'radiob_array_table'
 and 'radiob_arraylen'
References: <1540273651-64688-1-git-send-email-zhongjiang@huawei.com> <1540281873.25715.2.camel@realtek.com>
In-Reply-To: <1540281873.25715.2.camel@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/10/23 16:05, Pkshih wrote:
> On Tue, 2018-10-23 at 13:47 +0800, zhong jiang wrote:
>> 'radiob_array_table' and 'radiob_arraylen' is not used after setting its
>> value.
>> It is safe to remove the unused variable.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> index 5cf29f5..3f33278 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
>> @@ -509,13 +509,10 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct
>> ieee80211_hw *hw,
>>  	int i;
>>  	bool rtstatus = true;
>>  	u32 *radioa_array_table;
>> -	u32 *radiob_array_table;
>> -	u16 radioa_arraylen, radiob_arraylen;
>> +	u16 radioa_arraylen;
>>  
>>  	radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
>>  	radioa_array_table = RTL8723E_RADIOA_1TARRAY;
>> -	radiob_arraylen = RTL8723E_RADIOB_1TARRAYLENGTH;
>> -	radiob_array_table = RTL8723E_RADIOB_1TARRAY;
>>  
>>  	rtstatus = true;
>>  
> I think 8723ae has only one antenna, so you can remove radio B array as well.
>
Yep,  Will do.

Thanks,
zhong jiang