Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp3199348ima; Tue, 23 Oct 2018 01:52:20 -0700 (PDT) X-Google-Smtp-Source: ACcGV61PLQ1+MtJgdFJq5mrWZIxFsiLrxUOPCOV/oYudNH1Eau8SNSnRGSXvJGvpJ2mqpGBAinnA X-Received: by 2002:a63:2c0e:: with SMTP id s14-v6mr24612011pgs.70.1540284740030; Tue, 23 Oct 2018 01:52:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540284740; cv=none; d=google.com; s=arc-20160816; b=lUL9xECx8pvQX5yhm+mPb9zy4sajhZr9faom8viXnPjBtx+VdbaA0AP16dsZaB193w 9SMPqR0k3H0z5+njHWt4BiHlBfWbdjSaEUHBpr+Seg9Bn3kjQ6xTdT0jXrvClcrW2VVa 7N2jOBhEk6vuKq6xPO/Jptk5mBQM2/06DMT6tgF5JLGkE6mlZ71LZAC3KA9yXx0/mA2d 8gY/oJYo2VAImdx0QKr/o+Ey9Z+ygsbbhR7xI52dlQpezeL1EZf0O6s67a1Gqcen324P jUeD1i6cwRR8RkeVen4ITuM3+51sMGYpmOhpfzcjPgFHCM2ioqBZi07BoQw1m2TW+iiZ BfFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5O5EUWCTYX4TgB0xqILhK7k+WaSQy4FSABRtisgyZT0=; b=yQ5M/BBO8S/Jucu5fuak4BtDhvpEtb0UvcxXc8NdXf9lxhQUx2XrUSc3pSqq9ejaEB LMPhX2Lkijqw9vAxk48wAry1VXJYgjiLkTv8CEvZlxQ8bDs1Kk5Nwi+WWfJM8CQgYNJR Hck+S4yoDkDb6u4X57HBx7h/PvyufASCskDoasdRDIsYXiwphM48By4abYSDVqzgNtWd 3dIFeL2+MFzzli1wuO0aQDXa+XTGx9bmbXPznZVg5X101IJ+imFGK0AZXRjZNL1QrQcI Li0QyxOhNp7O5NA3ltBR/SW88XosgdKHaX/PMfsz+YlKglFv+O8eJt+00wlWt8SlUQLp pnfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=oXsPxpxs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v28-v6si720788pgo.217.2018.10.23.01.52.04; Tue, 23 Oct 2018 01:52:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=oXsPxpxs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727869AbeJWROF (ORCPT + 99 others); Tue, 23 Oct 2018 13:14:05 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:47840 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727352AbeJWROF (ORCPT ); Tue, 23 Oct 2018 13:14:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5O5EUWCTYX4TgB0xqILhK7k+WaSQy4FSABRtisgyZT0=; b=oXsPxpxswdyp1yeiLHNOFO0Af WjK4nIFSeA7vB8QyznXi7lhjtibZiPXw+bn8SOFzDB7F1fB5IHdr4l45lCk1kaHTDHGrFsw41+vRr xy69QURCWDtGR51gWrEw49QU44dIof2D5UUZWSs0uAqy1CnF1sTtNUDjQ9XvxgcCBV5sfj+DNbtdM MxCUar6PjiaHydwc/OGyLlcl6p0ZJRv3Tv+GtRwJQKAw3WKAuRzxjDzNJqDLqD5VrD/FvAjyzh1S6 4dYB5QUHQdzcqZ9tVv/qse3mgA4WyNHrxVUFNyfmw2+yIIb9sn5ffj5rdPfYmibrNDe0FWmiliMfv dfUF9Wfxw==; Received: from [185.7.230.213] (helo=worktop) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gEsPR-0001Zl-TW; Tue, 23 Oct 2018 08:51:30 +0000 Received: by worktop (Postfix, from userid 1000) id 9B2476E08AB; Tue, 23 Oct 2018 10:51:27 +0200 (CEST) Date: Tue, 23 Oct 2018 10:51:27 +0200 From: Peter Zijlstra To: Yi Sun Cc: Waiman Long , Juergen Gross , linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, chao.p.peng@intel.com, chao.gao@intel.com, isaku.yamahata@intel.com, michael.h.kelley@microsoft.com, tianyu.lan@microsoft.com, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , "mingo@redhat.com" , Will Deacon Subject: Re: [PATCH v1 2/2] x86/hyperv: make HvNotifyLongSpinWait hypercall Message-ID: <20181023085127.GG3109@worktop.c.hoisthospitality.com> References: <1539954835-34035-1-git-send-email-yi.y.sun@linux.intel.com> <1539954835-34035-3-git-send-email-yi.y.sun@linux.intel.com> <20181022015342.GK11769@yi.y.sun> <2e0d62cb-b706-a5b4-65f7-982a913fb32b@suse.com> <20181022171516.GH3117@worktop.programming.kicks-ass.net> <20181023025740.GL11769@yi.y.sun> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181023025740.GL11769@yi.y.sun> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 23, 2018 at 10:57:40AM +0800, Yi Sun wrote: > On 18-10-22 19:15:16, Peter Zijlstra wrote: > > > >>>> +#if defined(CONFIG_X86_64) && defined(CONFIG_PARAVIRT_SPINLOCKS) && IS_ENABLED(CONFIG_HYPERV) > > > >>>> + if (!hv_notify_long_spin_wait(SPIN_THRESHOLD - loop)) > > > >>>> + break; > > > >>>> +#endif > > > > Secondly; how come you thought that was acceptable in any way shape or > > form? > > > Sorry for that. Will try another way. Can you try and explain why vcpu_is_preempted() doesn't work for you?