Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp3206847ima; Tue, 23 Oct 2018 02:01:37 -0700 (PDT) X-Google-Smtp-Source: AJdET5cmHvN5SO5y1KOxxHwBHZnzpFE/V/97GT6vJhqgpOTekEcMF/ONLywZeun/5SIe7/DHVgsP X-Received: by 2002:a63:6302:: with SMTP id x2mr5500377pgb.183.1540285297719; Tue, 23 Oct 2018 02:01:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540285297; cv=none; d=google.com; s=arc-20160816; b=WeoodqSR8HmoNmQAZ6lN2AlZk7sKvPx0rNAGIXLSeDdcyDyhOBZO2KaLynyvFlOJfU 9S9TKfEL4JLFyh9crZcokrvt2Umpn2IURJkwVY2tZPRUJROD3c2bKSTStQTU825zTYW3 ZQUhJJInuVlFJJwNeKXxVAFcS3ASxcyu1olpJzr7TUXffgI3AwOrY5/k2Mhbe41pODqO HWT6vjCmo9GEFVhLP2fo/oq7xdwjRmHXkQH2EsTbaokdJ0JRwdTJS6D0NiVlCsK8dx3/ hch3l40lD+SggudqhLviBsyDJTgwSm+q3iTbxztkZNnh16dPzQ5b/kj01nKZVsH1vNVc mQkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:dkim-signature; bh=fylEEco5pjLtGsGjHcHhLfPg0yEgdiOJYTFObVPB6QM=; b=S0pQf4Mdph3KR0rGsSjQIIdbUdigO493QehBoAdXUOp+A6KxodhYAue2h2e35D+EYv fpqnn8jjpu54gkzgicVVELq6tazgrABWzEzZR80w9R+8pPO1Gz1zHFAZNx2P9Vdgj51E JelwgboRJeriDLZvDN/rc/m/yZFEYDFW5Qhxrc03h8M5MiAhQf8Br3sYvCrgvMK3N6K5 rqr1RdtzYAzooVkk53xNd4FhnGNf+TYJzEDZ+DeCI6Pl6L28Z+W8R5gsj3ZMbrfrt6xf 840koTDWo3/bwBukvMiDp50ioj2k+FNWyAhXPq+bIzgXzcTYN1sl2panoOACyVpgfRwG yifg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KTQY3vRD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r23-v6si707248pgk.225.2018.10.23.02.01.21; Tue, 23 Oct 2018 02:01:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KTQY3vRD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728382AbeJWRXI (ORCPT + 99 others); Tue, 23 Oct 2018 13:23:08 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:46301 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727470AbeJWRXH (ORCPT ); Tue, 23 Oct 2018 13:23:07 -0400 Received: by mail-pf1-f194.google.com with SMTP id r64-v6so323587pfb.13 for ; Tue, 23 Oct 2018 02:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:to:from:in-reply-to:cc :references:message-id:user-agent:subject:date; bh=fylEEco5pjLtGsGjHcHhLfPg0yEgdiOJYTFObVPB6QM=; b=KTQY3vRDe4rFZu9V/AkUQuRLelYh7eb6/RRPAvYzYHef+F9yk/gdxtyNP0lT0ceqtU PmdlfcOdxqHshVKYkZ3qYyYDAbkvn8s/0YjVVc/N21FNDL/CRmjSo7TgpkntizZZMWZV gHdcfRbOGv5C/kisYK3h2YO1bjpswlL0uolWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:to:from :in-reply-to:cc:references:message-id:user-agent:subject:date; bh=fylEEco5pjLtGsGjHcHhLfPg0yEgdiOJYTFObVPB6QM=; b=EBQMqhzcVt1Ke/HSIEkkfOWE5kA7MdTc8gOURXZ0V3bsdS0UgYwI1Y5cT7cxb7gnu0 +Y+lMZehJjzhfheB5ba9uBU0vzAMEPfZ1GNVouBuuNLWNkkm7aAmTkbTQmTFT7mp2rAA wcQJ+eSrQdJSsvkVICAaxSjGCxol2zC2RYoTeEtnHh9O60k3CtL2NzAwDTPfbc8avFnZ k42RVc0fYwPkmwzGG0gFlXjnVVHNE+RAu9qF68GYlRE/hM3dhmyKnGOP4BWdt+npH7pK QIWKoky9hrAcbg/up5QrOWxJvkEvuYv8tIRr7+mLgZyXftd8TD3Zowv0lzcAeSZ4p6/Q WAsw== X-Gm-Message-State: ABuFfoiJbCzI/dhGLUIowzEh7SU5R1CELN3YiMJa+MJ18emqk/nigdn0 bXg1RYhHUFbBr9NKnK+6Yr/ZGw== X-Received: by 2002:a65:655a:: with SMTP id a26-v6mr45757369pgw.389.1540285239970; Tue, 23 Oct 2018 02:00:39 -0700 (PDT) Received: from localhost ([2620:15c:202:1:fed3:9637:a13a:6c15]) by smtp.gmail.com with ESMTPSA id 145-v6sm4125549pfw.17.2018.10.23.02.00.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Oct 2018 02:00:38 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Mark Brown , Ryan Case From: Stephen Boyd In-Reply-To: <20181023010707.153647-1-ryandcase@chromium.org> Cc: linux-arm-msm@vger.kernel.org, Doug Anderson , Ryan Case , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org References: <20181023010707.153647-1-ryandcase@chromium.org> Message-ID: <154028523769.53599.11047318773748957636@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits Date: Tue, 23 Oct 2018 02:00:37 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Ryan Case (2018-10-22 18:07:07) > Address remaining comments from original driver patch series > = > * Move RD_FIFO_CFG to be ordered corretly > * Expand spinlock comment > = > Signed-off-by: Ryan Case > --- Reviewed-by: Stephen Boyd