Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1539965871-22410-1-git-send-email-vincent.guittot@linaro.org>
 <1539965871-22410-3-git-send-email-vincent.guittot@linaro.org> <20181023100057.GJ3109@worktop.c.hoisthospitality.com>
In-Reply-To: <20181023100057.GJ3109@worktop.c.hoisthospitality.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Tue, 23 Oct 2018 14:15:46 +0200
Message-ID: <CAKfTPtAVODuDsvFsGpdnxQjGffOa=WKBEcnqo-vGkmaMs=UcAQ@mail.gmail.com>
Subject: Re: [PATCH v4 2/2] sched/fair: update scale invariance of PELT
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Morten Rasmussen <Morten.Rasmussen@arm.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>,
        Paul Turner <pjt@google.com>, Ben Segall <bsegall@google.com>,
        Thara Gopinath <thara.gopinath@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 23 Oct 2018 at 12:01, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Fri, Oct 19, 2018 at 06:17:51PM +0200, Vincent Guittot wrote:
> > In order to achieve this time scaling, a new clock_pelt is created per rq.
>
>
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index 3990818..d987f50 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -848,6 +848,8 @@ struct rq {
> >       unsigned int            clock_update_flags;
> >       u64                     clock;
> >       u64                     clock_task;
> > +     u64                     clock_pelt;
> > +     unsigned long           lost_idle_time;
>
> Very clever that. Seems to work out nicely. We should maybe look at

Thanks

> ensuring all these clock fields are indeed on the same cacheline.

yes good point