Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp3754266ima; Tue, 23 Oct 2018 10:42:28 -0700 (PDT) X-Google-Smtp-Source: ACcGV60cCSKmSo3cs6A3cpVSuyfLFIBJWoBj+hZ2PSotvrDSVhmqIwfPMnXZL72/6VwuWVqwXJqc X-Received: by 2002:a62:564e:: with SMTP id k75-v6mr50773223pfb.33.1540316548093; Tue, 23 Oct 2018 10:42:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540316548; cv=none; d=google.com; s=arc-20160816; b=Q/wAYRjYCnvwoycIPSneHn6SJoyamHbDwNvbpeIbNftYNcLThG2JPj0gnujpacsHU+ WGqoT5JoT0up/quMvsYBtBGHO32Iq4rAmG/wUiaEDZauICyX7SUnEVi15WkYaT5PgBLK IKv3Yo6mhIIATjR0Ufnu/HkiWR3mcV+BPqUnB4datuZwPv+lksNA48WE64ATxpLWC54N eWAx8eVdx7v44zaYebXJDDRWDsAkOhLvgPlG9ur3bthzrMqEDU+/tm3sjwRIbe8tF82A wsrgRQALWixFVXHyDZuhHbmv7ma67RHpB2zGKUJISm9acV7wHVR4TFXUUDlIhb9S9VdX 5Ltg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Uog6eWWZwx7byoO4QTXFhNFrwph/6sU7PgE6Aph2Xh4=; b=ayiyV/h9op2QQSQON6Hk00O6gitEBybHkSVCxZ2dkpqU032hoclT7Z7jRhCD8WS3qf Jje248CAFY0qL3CxZ6UY2O01wGRpl3EgpZzhZDMOs3tAJ10P4CisZOnhPk+F/W/RciIe XMzj6fSXOgs8QdTGdPqDujmD0VMnKl5A15etKChbYmzKgsjvPrl1KBEl0WFV12QNlasb PxYmrN4K+nWZkFK+nkBBfAygI1GhGifUAxbHL0HwsHrz+vzk9RHxkcKD7SEAb+4CO7LD 4KxVB5HEIkJi0hqPtMcycZ+u0ifxQthm1XMU7e12Qf7SblDIfimC024x8smA1x4goKdc +H8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=AHDkosGo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l4-v6si1932016pgf.344.2018.10.23.10.42.11; Tue, 23 Oct 2018 10:42:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=AHDkosGo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728563AbeJXCFv (ORCPT + 99 others); Tue, 23 Oct 2018 22:05:51 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57556 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726865AbeJXCFv (ORCPT ); Tue, 23 Oct 2018 22:05:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Uog6eWWZwx7byoO4QTXFhNFrwph/6sU7PgE6Aph2Xh4=; b=AHDkosGoeBQzipN/52F55Iy6f R52Kw9Hj8ODg216rwYNcfbxJq+dSYo2gqsTpF7tkkF7sK/uRLXcwu7b2bLCi06x9l6pYF7MSeCX+n uKXflitnbhLmV99Se8UxIOcNAPlbbR17RnGFrnIYyLlxNYpcf122ZQqr1nxJF/DKwiSIw1Bh0MPq8 BT999Z7RTHLYfZGXcBj8LRWEoGlsvhODfIqL2yCVqDYJBrjCN4xc12VMAYa+3qEKpZXot2HcTVeVa NjbrEZ3hY3wVdyjz+GoqtGZl92gJXogD+VsXCiZ/WQARbaX99s20vsP4IOa6K944ISd852KbjmX5r PCg8jJucQ==; Received: from [167.98.65.38] (helo=worktop) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gF0gD-0006ft-FB; Tue, 23 Oct 2018 17:41:21 +0000 Received: by worktop (Postfix, from userid 1000) id 61DD36E08B3; Tue, 23 Oct 2018 19:41:15 +0200 (CEST) Date: Tue, 23 Oct 2018 19:41:15 +0200 From: Peter Zijlstra To: Johannes Weiner Cc: Andrew Morton , Ingo Molnar , Linus Torvalds , Tejun Heo , Suren Baghdasaryan , Daniel Drake , Vinayak Menon , Christopher Lameter , Peter Enderborg , Shakeel Butt , Mike Galbraith , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/9] psi: pressure stall information for CPU, memory, and IO v4 Message-ID: <20181023174115.GB3126@worktop.c.hoisthospitality.com> References: <20180828172258.3185-1-hannes@cmpxchg.org> <20181018190710.fcea1c5f9c3b0c15d37ee762@linux-foundation.org> <20181023172937.GA21443@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181023172937.GA21443@cmpxchg.org> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 23, 2018 at 01:29:37PM -0400, Johannes Weiner wrote: > On Thu, Oct 18, 2018 at 07:07:10PM -0700, Andrew Morton wrote: > > On Tue, 28 Aug 2018 13:22:49 -0400 Johannes Weiner wrote: > > > > > This version 4 of the PSI series incorporates feedback from Peter and > > > fixes two races in the lockless aggregator that Suren found in his > > > testing and which caused the sample calculation to sometimes underflow > > > and record bogusly large samples; details at the bottom of this email. > > > > We've had very little in the way of review activity for the PSI > > patchset. According to the changelog tags, anyway. > > Peter reviewed it quite extensively over all revisions, and acked the > final version. Peter, can we add your acked-by or reviewed-by tag(s)? I don't really do reviewed by; but yes, I thought I already did; lemme find. > The scheduler part accounts for 99% of the complexity in those > patches. The mm bits, while somewhat sprawling, are mostly mechanical. Ah, I now see my mistake; https://lkml.kernel.org/r/20180907110407.GQ24106@hirez.programming.kicks-ass.net I forgot to include an actual tag therein. My bad. Acked-by: Peter Zijlstra (Intel)