Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp3776637ima; Tue, 23 Oct 2018 11:04:45 -0700 (PDT) X-Google-Smtp-Source: AJdET5c3PfL0jhKM4HOXeP9d7ZA+Sd7AchPs1ZS0GTzGgJSwskzUhNST2IYo+Gu3fJOM/9bQs3Fu X-Received: by 2002:a17:902:650f:: with SMTP id b15-v6mr7746631plk.2.1540317885115; Tue, 23 Oct 2018 11:04:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540317885; cv=none; d=google.com; s=arc-20160816; b=e/QPCC3eE0wzUDnfBJhBB7YnMXSfuLtbGTzd8e+ZAEGdj/07/8CNRRJa+h60Hwu+Lf dGMVc3LiIuKR6UOVrchnIC0zKMR1Wfk4/ZNm+X1cyPboHZ6npFp96mSmOFPrEwsY7NZ/ zdi0IS9f9T58kYFOKiWQUWsO1kM0M6hXQtY4nXbgRZf5mXW9D340oh8VY/CqdgG3HzVv 8D5e0Q8cvtQ0IdHLI22ztw7Ah/7bqA3AUhp1O9LLazYvOqTY+1yBo2fpXtZedP0JU+9w vxvly7exHgH5UURIYRr8rtvHB/gE6DkBUIc/ihwxy+N7MaJ5oOUBFDKUm+BAQYiW9lwc g1nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=+FcgpOfigPjNLyZguggSQl3RJJvdSs5VvacxO9LnRrc=; b=BKLOvBvn3nvboUHqGQqU3ZQlux6XTPUdYsZBTuvQTDVUglN+xo41sFrpwqGteSRicH OlO0q2FcBkjC/nxbmdd451Pt1INEbdJTZw6oAi9t6Z6vDpMiBi2g0pFmd4QgAunKRE6A vU/231BxkLK70XQ7FEqsQZ+YLTmunRwNu098Vb+i6tbMrcRcV2GhQp5N8I3UAaESB1Et 1SaA/fAQSDoAzgGYJ82rHSvHLmHXb0EvbcLktZYZ7HZxcmrphODeahLcjfYYNjCOhhav G8jfcLsAKKG/prby8m2wYO4mYM1TDm97oBqqW5EZ2eJQWKyMG5vM9Hm5QYRhVKu7vo4E ssSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s12-v6si1737907plr.307.2018.10.23.11.04.23; Tue, 23 Oct 2018 11:04:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728669AbeJXC1c (ORCPT + 99 others); Tue, 23 Oct 2018 22:27:32 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50930 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727758AbeJXC1c (ORCPT ); Tue, 23 Oct 2018 22:27:32 -0400 Received: from localhost (c-67-183-62-245.hsd1.wa.comcast.net [67.183.62.245]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D88021472357E; Tue, 23 Oct 2018 11:03:05 -0700 (PDT) Date: Tue, 23 Oct 2018 11:03:05 -0700 (PDT) Message-Id: <20181023.110305.461689764889182451.davem@davemloft.net> To: ivecera@redhat.com Cc: netdev@vger.kernel.org, sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "be2net: remove desc field from be_eq_obj" From: David Miller In-Reply-To: <20181023144026.26180-1-ivecera@redhat.com> References: <20181023144026.26180-1-ivecera@redhat.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Oct 2018 11:03:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ivan Vecera Date: Tue, 23 Oct 2018 16:40:26 +0200 > The mentioned commit needs to be reverted because we cannot pass > string allocated on stack to request_irq(). This function stores > uses this pointer for later use (e.g. /proc/interrupts) so we need > to keep this string persistently. > > Fixes: d6d9704af8f4 ("be2net: remove desc field from be_eq_obj") > > Signed-off-by: Ivan Vecera Please do not put empty lines between Fixes and the other tags, all tags should appear together as one contiguous group. Fixed and applied and queued up for -stable.