Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20181023110837.27840-1-efremov@linux.com>
References: <20181023110837.27840-1-efremov@linux.com>
From:   Kees Cook <keescook@chromium.org>
Date:   Tue, 23 Oct 2018 12:28:01 -0700
Message-ID: <CAGXu5j+nJM6RWZJZNBsvVSbS7=UkyGFEnO_rM+phFtLvxYuRYA@mail.gmail.com>
Subject: Re: [PATCH 3/9] security: fix documentation for the
 socket_post_create hook
To:     efremov@linux.com
Cc:     James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Eric Paris <eparis@redhat.com>,
        Paul Moore <paul@paul-moore.com>,
        John Johansen <john.johansen@canonical.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 23, 2018 at 4:08 AM,  <efremov@linux.com> wrote:
> From: Denis Efremov <efremov@linux.com>
>
> This patch slightly fixes the documentation for the
> socket_post_create hook. The documentation states that
> i_security field is accessible through inode field of socket
> structure (i.e., 'sock->inode->i_security'). There is no inode
> field in the socket structure. The i_security field is accessible
> through SOCK_INODE macro. The patch fixes the documentation accordingly.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  include/linux/lsm_hooks.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index 8f84ef819e00..accf6f34ac8e 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -752,9 +752,9 @@
>   *     socket structure, but rather, the socket security information is stored
>   *     in the associated inode.  Typically, the inode alloc_security hook will
>   *     allocate and and attach security information to
> - *     sock->inode->i_security.  This hook may be used to update the
> - *     sock->inode->i_security field with additional information that wasn't
> - *     available when the inode was allocated.
> + *     SOCK_INODE(sock)->i_security.  This hook may be used to update the
> + *     SOCK_INODE(sock)->i_security field with additional information that
> + *     wasn't available when the inode was allocated.
>   *     @sock contains the newly created socket structure.
>   *     @family contains the requested protocol family.
>   *     @type contains the requested communications type.
> --
> 2.17.2
>


-- 
Kees Cook