Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20181023111450.31837-1-efremov@linux.com>
References: <20181023111450.31837-1-efremov@linux.com>
From:   Kees Cook <keescook@chromium.org>
Date:   Tue, 23 Oct 2018 12:28:49 -0700
Message-ID: <CAGXu5jL_WTxSJYVCuWDbPZxTnJnuakZeCr52ZKPMcc-H245bxw@mail.gmail.com>
Subject: Re: [PATCH] security: fix documentation for the socket_getpeersec_dgram
 hook
To:     efremov@linux.com
Cc:     James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Eric Paris <eparis@redhat.com>,
        Paul Moore <paul@paul-moore.com>,
        John Johansen <john.johansen@canonical.com>,
        Catherine Zhang <cxzhang@watson.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 23, 2018 at 4:14 AM,  <efremov@linux.com> wrote:
> From: Denis Efremov <efremov@linux.com>
>
> The socket_getpeersec_dgram hook was changed in the commit
> "[AF_UNIX]: Kernel memory leak fix for af_unix datagram getpeersec patch"
> (dc49c1f94e34). The arguments @secdata and @seclen were changed to @sock
> and @secid. This patch updates the documentation accordingly.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  include/linux/lsm_hooks.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index ae3766720264..a598e601ccb3 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -861,9 +861,9 @@
>   *     the IP_PASSSEC option via getsockopt.  It can then retrieve the
>   *     security state returned by this hook for a packet via the SCM_SECURITY
>   *     ancillary message type.
> - *     @skb is the skbuff for the packet being queried
> - *     @secdata is a pointer to a buffer in which to copy the security data
> - *     @seclen is the maximum length for @secdata
> + *     @sock contains the socket structure.
> + *     @skb is the skbuff for the packet being queried.
> + *     @secid: pointer to where to put the secid of the packet.
>   *     Return 0 on success, error on failure.
>   * @sk_alloc_security:
>   *     Allocate and attach a security structure to the sk->sk_security field,
> --
> 2.17.2
>


-- 
Kees Cook