Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20181023111255.30446-1-efremov@linux.com>
References: <20181023111255.30446-1-efremov@linux.com>
From:   Kees Cook <keescook@chromium.org>
Date:   Tue, 23 Oct 2018 12:28:21 -0700
Message-ID: <CAGXu5jJp-FeGG37ZqVbaj+Gs6NuJac=Kcs-VAK_X4N5OOU9O=g@mail.gmail.com>
Subject: Re: [PATCH] security: fix documentation for the task_setscheduler hook
To:     efremov@linux.com
Cc:     KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
        James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Eric Paris <eparis@redhat.com>,
        Paul Moore <paul@paul-moore.com>,
        John Johansen <john.johansen@canonical.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 23, 2018 at 4:12 AM,  <efremov@linux.com> wrote:
> From: Denis Efremov <efremov@linux.com>
>
> The task_setscheduler hook was changed in the commit
> "security: remove unused parameter from security_task_setscheduler()"
> (b0ae19811375). The arguments @policy, @lp were removed from the hook.
> This patch updates the documentation accordingly.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  include/linux/lsm_hooks.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index accf6f34ac8e..ae3766720264 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -655,10 +655,8 @@
>   *     Return 0 if permission is granted.
>   * @task_setscheduler:
>   *     Check permission before setting scheduling policy and/or parameters of
> - *     process @p based on @policy and @lp.
> + *     process @p.
>   *     @p contains the task_struct for process.
> - *     @policy contains the scheduling policy.
> - *     @lp contains the scheduling parameters.
>   *     Return 0 if permission is granted.
>   * @task_getscheduler:
>   *     Check permission before obtaining scheduling information for process
> --
> 2.17.2
>


-- 
Kees Cook