Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5BCFD310.90305@huawei.com>
Date:   Wed, 24 Oct 2018 10:04:00 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     Pkshih <pkshih@realtek.com>, "joe@perches.com" <joe@perches.com>
CC:     "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table'
 and 'radiob_arraylen'
References: <1540283282-9772-1-git-send-email-zhongjiang@huawei.com>  <19b16ca89b5cde607338513638d4ef8e3a3d2802.camel@perches.com> <1540342331.2495.1.camel@realtek.com>
In-Reply-To: <1540342331.2495.1.camel@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/10/24 8:52, Pkshih wrote:
> On Tue, 2018-10-23 at 12:33 -0700, Joe Perches wrote:
>> On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote:
>>> radiob_array_table' and 'radiob_arraylen' are not used after setting its
>> value.
>>> It is safe to remove the unused variable. Meanwhile, radio B radio should be
>>> removed as well. because it will no longer be referenced.
>> The patch subject is a bit off and too generic here.
>>
>> This is specific to rtl8723ae and not rtlwifi so it is
>> probably better for the subject to be something like:
>>
>> [PATCH] rtl8723ae: Remove set but not used variables and #defines
> I'd like 'rtlwifi: rtl8723ae: ' as subject prefix.
Thanks for your suggestion. Will change the subject and resend.

[PATCH] rtlwifi: rtl8723ae: Remove set but not used variables and #defines


Thanks,
zhong jiang
>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>>> ---
>>>   drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c   | 5 +----
>>>   drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ----
>>>   drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 --
>>
>> ------Please consider the environment before printing this e-mail.