Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp75138ima; Tue, 23 Oct 2018 19:50:36 -0700 (PDT) X-Google-Smtp-Source: AJdET5dkCiLtgjWO31ux7jSFSR/6AFAgvt2pZ6jtoX8nxSyzaj06ihJn7C7r58eNTB/wa5EfZZMJ X-Received: by 2002:a62:cd8a:: with SMTP id o132-v6mr870316pfg.12.1540349436722; Tue, 23 Oct 2018 19:50:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540349436; cv=none; d=google.com; s=arc-20160816; b=vqIPsYsqOkyJMU4rhZkhvIRVuexrXoz0dlOyIO6YWjOpEkqexfCFM9LkpnyizsW5/Z 7Am95zkpPzSmVdmqq/ZFr+xPDBrkNs9rtZGjVfvn6Or/DHcJUFHFs4CIL7qgHstbDTRm EWAKzbRXTpvsa+qpqyscBOt/C4vOOIxFXYGthwrYK5QVAV5GelEJNrkovGN8qXc6BfDZ gxyKQrvNEcZKyUcvlYfweEMzeUTM1qFr3/obC2/Wt1c1kz0Oo2wHJWyHoQXr+DATNPjI FW1Rl6u/eeObZOTLj9G2upzdy1lYi2u7hmCsS2SeEzN8w7xXstkV4DuFBz0OWy4nGmJV wJQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=+sRKo1CvoxOWBf9OKY4Pte9xswQoeMWZn17dQx5Ipxc=; b=ANKn0gfbiP/Tr+DwdRRvSsMGStcpIqTWjvnKoLS3sGUgOjA1TZjRuvDLThG9TCyEEC IQ6rrk/noRX7h/0nZqX7r5b2FK5x3McfIxP6TUW9He9iObUr296+TzRSwl4fXdjV2rZa e1RwNgXcTORT3Jb3regHEl/uuzzszlHKI+G+fZfNd1PvrOonjtY4Pj1LhdaFzo9xvjs+ iZ+Pb7nB3KOtwAiL2vBmsXjjfN5kC7Z0zYEBJSlJXJ5TbSi2tth153Wmso94o9Ffo+6i oE/ycrqAWbJuN/cg8WIX5YCxVK3w1S/24167kRUNtvuBQMF/yDVUfwAiWYSMI5GnYoyl vonA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u189-v6si3399733pfu.263.2018.10.23.19.50.21; Tue, 23 Oct 2018 19:50:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727033AbeJXLPo (ORCPT + 99 others); Wed, 24 Oct 2018 07:15:44 -0400 Received: from mga11.intel.com ([192.55.52.93]:41763 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbeJXLPl (ORCPT ); Wed, 24 Oct 2018 07:15:41 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 19:22:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,418,1534834800"; d="scan'208";a="102098596" Received: from jhli-desk1.jf.intel.com ([10.7.198.167]) by orsmga001.jf.intel.com with ESMTP; 23 Oct 2018 19:22:30 -0700 From: Juston Li To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: lyude@redhat.com, clinton.a.taylor@intel.com, nathan.d.ciobanu@intel.com, mario.limonciello@dell.com, jared_dominguez@dell.com, linux-kernel@vger.kernel.org, Lyude , stable@vger.kernel.org, Juston Li Subject: [RESEND PATCH v2 2/2] drm/i915/mst: Reset MST after resume when necessary Date: Tue, 23 Oct 2018 19:19:25 -0700 Message-Id: <20181024021925.27026-3-juston.li@intel.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181024021925.27026-1-juston.li@intel.com> References: <20181024021925.27026-1-juston.li@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lyude A follow-up to the previous commit, we skip checking the status of the MST device and completely reprobe it if drm_dp_mst_topology_mgr_resume() returns -EINVAL. Cc: stable@vger.kernel.org Signed-off-by: Lyude Signed-off-by: Juston Li --- drivers/gpu/drm/i915/intel_dp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 8c38efef77a1..cb5ffec73094 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -6793,7 +6793,12 @@ void intel_dp_mst_resume(struct drm_i915_private *dev_priv) continue; ret = drm_dp_mst_topology_mgr_resume(&intel_dp->mst_mgr); - if (ret) + /* A full reset is required */ + if (ret == -EINVAL) { + drm_dp_mst_topology_mgr_set_mst(&intel_dp->mst_mgr, false); + intel_dp_configure_mst(intel_dp); + } else if (ret != 0) { intel_dp_check_mst_status(intel_dp); + } } } -- 2.17.2