Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp77907ima; Tue, 23 Oct 2018 19:54:57 -0700 (PDT) X-Google-Smtp-Source: AJdET5dqa9fb5Q55WV+vYMk5VcV42tZgpsrqQdc0+ix7TaCAAjY4uHy5MZxl5A+kOPV6rjEFy7q8 X-Received: by 2002:a63:3204:: with SMTP id y4mr818657pgy.41.1540349697579; Tue, 23 Oct 2018 19:54:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540349697; cv=none; d=google.com; s=arc-20160816; b=C2BODY43dSEbQwi4B0OskZXPvH8lSJeMljlOQC49VM0+8VH8/cpaEr55YYXNF8S4su lmhR+bvD2qjXfpHnRebcXRJuj/S57fMP3juvCZJtfjoKMdWHehnSP3STrvAiAg2CVsAk Iy7pYqGz2Eq45xfFr8cnqBChBV2u9oH0m5L8j8bB8dz4juHMgiactyvvrTYHxXs34hZQ 2tqvXJ0z5Rt7qVvuOX5vwpe27dFXCy8nXqIHvcQ/WYZlo5MQAVtrSA2xQafFwKAoqChT DsSShxYdnuElKTgWfxamoEV7owUGraYpCSCZVkmU5hpRVkvMKR79n0bv/icJdIZ8hGye To1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=tnJTr6pRflEMEfp6xo/701AUEi8OZJzcxHw2leh1SWg=; b=wSduB8Rz1dZ1JVNJIXPY4hHN8vLh5RWU01id8TCIW2ZF+WqfqlQ5gXiqpWWkUNxzHn kmBjUGPsnhc66UnNC8FtSkG4j7dDqoWsBZov+3yAUr+jLqXvVBDO4ijj8cGvave07MbU WxfGrER79eh8NW2p9xeTM8vndC2cXe/yLoLrBAk8Z3IToh10V5Nn/HR5Bqszm5t2eOQy xhxTy3wmLvnRjmEBxf4+pPfU7pBdGMMZ+HFILFttrXuqwLvPK2NBQB/IjnBmxRFTWfQY hhsvBC8K8cpJ5fx3+ZCn1YRAGYvEctEipSCLq3fNrLHxWyQTLrph2OebjK3ZzB1eHr8p h14g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Eh3TDTHF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a6-v6si3337210pgi.160.2018.10.23.19.54.41; Tue, 23 Oct 2018 19:54:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Eh3TDTHF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726371AbeJXLUT (ORCPT + 99 others); Wed, 24 Oct 2018 07:20:19 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:46440 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbeJXLUT (ORCPT ); Wed, 24 Oct 2018 07:20:19 -0400 Received: by mail-oi1-f195.google.com with SMTP id k64-v6so2848348oia.13; Tue, 23 Oct 2018 19:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tnJTr6pRflEMEfp6xo/701AUEi8OZJzcxHw2leh1SWg=; b=Eh3TDTHFl5dJZ0DV5Kv8nQmBcTWii4ZnHo4hF7ojtlJOY/4s0qunJVZiQlLqs3+qtj HHWNyGR1ZFshhxN0y2MtObvN4MdZKwxS5cUSrCuKCuY4VHpoN/5GznSPw9F8P5M416bA Lz7akRfQ9nsGxmiWVOV27TAQdLP5SZGiQ0E3hC7oQRsl1W9RyCceW+2sXbojXNJcsv6J 1YtySurbUnmExMXJMNZnaWEmdfxa8gnLv/Dr+AKmVO1uhIJrAh2GfDp/ItWvfpIIPBJt SlLGbD9u7vS8xteneZ9JqhK+vYD0qggZzvuS97TMlldfLnCdjriMU4PenrNqyV9Jrtgi xwYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tnJTr6pRflEMEfp6xo/701AUEi8OZJzcxHw2leh1SWg=; b=YfVLgWmT2aeb5DdME9ZF657juTbb6Gyn/xWahKHWs1Mhl9U2w0mGfbcbv2xGft/7Yx 2YGJW5GbKisflvQxFC1vZdKNjVkZNGvJIVA2WG6PJM46Q3PeQ1jVxQbdaBSpHGxcwTm+ 7G/lLi1BGrI8HCxkXKMh34N1GYhWMxp/95X9KLpiqTj93yIJOEQketIKp5EVqdclqwcq zYrU1voi8bG91I3oyhHjNoLOrRfeD+W+pwxhIFFufT1ye+LededoP3xG+sthPoDNKHHc HsdIYZ7wvVB8B0bmHn+ONQZQVaU8S3hoHkcAJVkpxxnj7G4iztRj6ZU8jJ/Cln2StVFL /BmA== X-Gm-Message-State: AGRZ1gIzmNhI9d+MXlZ1/X5nmPF+hCSIswOruN8yjvrFj00mD1ZkSOur lijOyJCv+FP0MPd2NsFyLsiCTCMdzZM8f+tSex1O+mBF X-Received: by 2002:aca:538b:: with SMTP id h133-v6mr350009oib.355.1540345726141; Tue, 23 Oct 2018 18:48:46 -0700 (PDT) MIME-Version: 1.0 References: <20181023011042.GA6582@WindFlash> In-Reply-To: From: Leonardo Bras Date: Tue, 23 Oct 2018 22:48:34 -0300 Message-ID: Subject: Re: [PATCH v2 3/5] Creates macro to avoid variable shadowing To: helen@koikeco.de Cc: lkcamp@lists.libreplanetbr.org, Borislav Petkov , David.Laight@aculab.com, Andy Lutomirski , Ingo Molnar , Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Helen, On Tue, Oct 23, 2018 at 6:35 PM Helen Koike wrote: > Like this you are not changing the logic in this file, you are just > renaming the variable which is more then enough to solve the -Wshadow > warning. > I don't it is worthy changing the logic. You are right, that was what the patch was supposed to do. For some crazy reason I must have submitted the wrong commit as a patch. I will fix it and send you all a v3 ASAP. Sorry for the inconvenience. Thanks! Leonardo Br=C3=A1s