Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp103112ima; Tue, 23 Oct 2018 20:31:41 -0700 (PDT) X-Google-Smtp-Source: AJdET5fX6jx9wNpFMktLi/u6+uQc4WU42NpV4S6aGOqyowInH8xVPOotIOjSEzs7eiMnJpiCYH6H X-Received: by 2002:a17:902:16a4:: with SMTP id h33-v6mr902532plh.3.1540351901726; Tue, 23 Oct 2018 20:31:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540351901; cv=none; d=google.com; s=arc-20160816; b=mUN0PrD75gWxIjugPajTlwWMkN9p3gx+8yalL210bWLLEFB6gl6o72NOXWoJkuRclx 2xxuYwWhg7U6ORoXcOrqJzCcfV0Z17lL6l/KbIuafEdeDHbWZBevE3gCR2An7nhOEVfu nQZx4R+E/JvO69jPVAlvpPZZqGZ0uqsCWkLTXYM149WoVHSUBbj+rNMC2WFtTN8N5dHl hcT9r0cqCsclMK2+25QZbEvvKeOOvnyXiyyRA/sgfeaHScopPy+wf30cUk/6KulKssBv Knki5gvKmKg49VEKOd7D+OPprzwq1qKd1+rD+L6wRN6RcBxLLlmBjmFr6gnSL0vjPYjl Dwfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=ggV+ywjKf3q0Ak4QYOtHoDVSmG7i1LNnqaTdg3lP9vw=; b=sKkfiVoVRqB35f0LxU0LHzrhve614XjGhmHYASWKO2NR0ZSi4yoSRJc6/cYH/FdukZ 88ciYtZ0XP9lnTPK9OTp30ahqh4p4GNulODjn1ZxZQ+94OKtAlfaRVohl1VK7S2Td28S NrN5qeyM+oDiMG7eWK4tGGBOD9wdX2td5v1+JEaeycudYG0UZ5vmHiT8Lae0exSclxp7 9xvcq1bpQLfnFL/yOZkLzJ/wKBsO6IxmadpEsyDFGWhv8OCq7kNmwg3MGL2jmasGmslx qIhBETgdV5txbcVG73aYroQfemB798rsIZk7Av+dgyhtUuQhBLzDzoMWrtGKozarJqMZ sScQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SNli1Hum; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j3-v6si3119484pld.231.2018.10.23.20.31.26; Tue, 23 Oct 2018 20:31:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SNli1Hum; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726912AbeJXL4j (ORCPT + 99 others); Wed, 24 Oct 2018 07:56:39 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:41742 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725896AbeJXL4i (ORCPT ); Wed, 24 Oct 2018 07:56:38 -0400 Received: by mail-ot1-f67.google.com with SMTP id c32so3591111otb.8; Tue, 23 Oct 2018 20:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ggV+ywjKf3q0Ak4QYOtHoDVSmG7i1LNnqaTdg3lP9vw=; b=SNli1HumAxDYKEMrxn0IepzjbLvZtbAP4b1uKwWldCtlLkkIIOpP6ygnja9ckGchp2 zUcb0mAnY3x+92H4oeIGERY/4yNZijiZ4z8B/9E8TYSe3wCDqIHfZCUWvUgjbFeJ0F1z mpmvcmCh5ElKKiTM4x7Bd5AW8JnCsdBE+gXT+75SDyq5IslQY7ZUJXmgjLV2L4MMbzRu 7RZrsruUSb7a1q6dy/6kAHssY0M3vgyfMLWHiG6vkIL1OGVXezJnX+Bk4HfyWft6NMiH NLSXMTQUT/1veqws8bP5L6omVLULIJtQBh/L84VOvnFbBJVItfv4rkFaV9tOgbuF3w0J IelA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ggV+ywjKf3q0Ak4QYOtHoDVSmG7i1LNnqaTdg3lP9vw=; b=LifxeOjEOjwpV2vUEdo6YvRevRPoaOKyukQuQmlkZwvkdl83D1Xy6hVGU8rLbNrQps Bp9v9ibHMZgedB6cYCfK52ZBLtgvKxcJv+BfrN40T+546POQkb1wsi1/Vk45AHMp7QN0 5ZmlooTSfIvHJaJQMMlJid1dRrNLy4DnoYrcfiUmYLhCBaVGweHfRTs9r59h6osIzfEh jqPkr8qWttcg01GzLbrZnEKywZd/9v2lW6/wml9MMK9uMmUBjj3XIoG7oFURfr+Lo5ou Dt7Mbek4Pppj2bB9gt6Z+F9SCJrnbBNu1rMt2Q2p1fTkpnmxEQ0f91fqfXl7nKYB1ayG 9VVA== X-Gm-Message-State: AGRZ1gKqCIrhJSZlhsfjGUBluKtWL/UFZnT3VMMleZXdrfKY6WZH9z9i nz6l2pNgV5Tjj11Cw832RFgpraRnLag7lx1JqH72og== X-Received: by 2002:a9d:529:: with SMTP id 38mr304185otw.233.1540341584420; Tue, 23 Oct 2018 17:39:44 -0700 (PDT) MIME-Version: 1.0 References: <20181023011022.GA6574@WindFlash> <93692F0D-D25B-4225-B127-4988E43B4CE1@amacapital.net> In-Reply-To: <93692F0D-D25B-4225-B127-4988E43B4CE1@amacapital.net> From: Leonardo Bras Date: Tue, 23 Oct 2018 21:39:33 -0300 Message-ID: Subject: Re: [PATCH v2 1/5] x86/vdso: Renames variable to fix shadow warning. To: luto@amacapital.net Cc: lkcamp@lists.libreplanetbr.org, Borislav Petkov , David.Laight@aculab.com, Andy Lutomirski , Ingo Molnar , helen@koikeco.de, Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andy, Yeah, it's much better. I will replace this part of the commit message. It will be fixed for v3. Thank you! On Mon, Oct 22, 2018 at 11:13 PM Andy Lutomirski wrot= e: > How about =E2=80=9CThe go32() and go64() functions has an argument and a = local variable called =E2=80=98name=E2=80=99. Rename both to clarify the c= ode and to fix a warning with -Wshadow.=E2=80=9D > > Other than that, Acked-by: Andy Lutomirski