Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp140850ima; Tue, 23 Oct 2018 21:32:33 -0700 (PDT) X-Google-Smtp-Source: AJdET5cyyMnc6GtqN19GJxT4O74MAGWczV7vTo+b3A8FCU5SZaaAR32pLsPZk6MoHy1ax1D+aMBM X-Received: by 2002:a63:69c9:: with SMTP id e192-v6mr1084388pgc.143.1540355553394; Tue, 23 Oct 2018 21:32:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540355553; cv=none; d=google.com; s=arc-20160816; b=kE+U6w71wo+NgxaBDfXJ6U6EGzj0qZyykONpAlu1xtnGezXLbvdphpTcV2TgMcd/S1 zlv/syyOgJY4J+b6DWYUVQt1+wdx6t0y9ujItdn/9eXIs+b3ljt9eM9V5oiES/cgtBdc 9K5RgRKmelCHefU/t3fQydL92j2vakCAuOB9qJNR8sJl0Le4Z6++SoraLHz2n9FvFYAZ nNxb2s6Q3mniJzPbb1S3yY2jufL1Ox6WS/0gNN7DAm8Hg8Krnc9/tYsDUKh+YoNi82eb vYbU8ItPbLt0R2Z4vJSKzeanhz9mP9f8TehsACUhvzeGWfcwCDSw0hFJkKW9DWMFsRFh +b+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=pFCtZRVbQP+0gGVJRlYdvksoX2/l+VekidlcZqwN85o=; b=IDrDvT85yCN3ahRgHTcnmPVdg/JgYMDs13DSsuqTu2VobekZ2CfV3q5JPswVpO7/5R M9eS43QOJYuv5Xlp73leGhNyOuXwYocgWCfIWn712uQdvow3IDylTy0E5+P9XObVY8wL 6MHo2OVm7Kt8ASQlXg/pHobJoSuTK+0Biot3m2eUM/VUFHyFiF1V3DOt7fdAq1qrJOJS ZuzF4mH1ANphEbBOeIpQAC0sJOco94NfFvuTNuLKUh2Y9lC73bHNqBC5ieq+jQC1u1GI H4MKlRBqr7LDAMo+IiRXrPTt1s5fa/wtWe0VAAEO7xScQA99zMMCOwycxouo9Wx1tUh2 2KFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=GKiFZrBs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bf12-v6si3263969plb.22.2018.10.23.21.32.18; Tue, 23 Oct 2018 21:32:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=GKiFZrBs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726747AbeJXM6B (ORCPT + 99 others); Wed, 24 Oct 2018 08:58:01 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:51380 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726224AbeJXM6B (ORCPT ); Wed, 24 Oct 2018 08:58:01 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9O1Nqj1079773; Wed, 24 Oct 2018 01:29:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=pFCtZRVbQP+0gGVJRlYdvksoX2/l+VekidlcZqwN85o=; b=GKiFZrBsauRaIFDMjIspZ8VfwlV7asUJcWFPlH/57tFyuOeoO80n9OEsoc5vTpziWAIg uRE+Cw9i5eVf6liaFTWq3MPcS/HicnTBgusKcNRAUjLE+Su4wKapcKvAGG7iCG9hCuUo sawhRZyUaR5zlajDqP+GRmifYYG5UToP9ovfOkiWV2QnkK2wajcakR/cJUW3whR7jlSv iC7VUMX3WxoKnw4S/oSROJ7iFBpSjafALS68E1tya1+ZBvQEOLyAEhwJ1JQpP2a32wPP 43O9Yf1BphrAM36MdEsyY176Irrzc6sRDu7GexH7VGEZ8h4+2c1gDre41xXWEFb1UR15 Vw== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2n7vaq0mjq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Oct 2018 01:29:07 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w9O1T6GT017967 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Oct 2018 01:29:06 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9O1T5sj028302; Wed, 24 Oct 2018 01:29:06 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 23 Oct 2018 18:29:05 -0700 To: Nathan Chancellor Cc: Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: 3w-{sas,9xxx}: Use unsigned char for cdb From: "Martin K. Petersen" Organization: Oracle Corporation References: <20181018215541.4768-1-natechancellor@gmail.com> Date: Tue, 23 Oct 2018 21:29:03 -0400 In-Reply-To: <20181018215541.4768-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Thu, 18 Oct 2018 14:55:41 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9055 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=912 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810240010 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nathan, > Clang warns a few times: > > drivers/scsi/3w-sas.c:386:11: warning: implicit conversion from 'int' to > 'char' changes value from 128 to -128 [-Wconstant-conversion] > cdb[4] = TW_ALLOCATION_LENGTH; /* allocation length */ > ~ ^~~~~~~~~~~~~~~~~~~~ > > Update cdb's type to unsigned char, which matches the type of the cdb > member in struct TW_Command_Apache. Applied to 4.20/scsi-queue. Thank you. -- Martin K. Petersen Oracle Linux Engineering