Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp204829ima; Tue, 23 Oct 2018 23:05:38 -0700 (PDT) X-Google-Smtp-Source: AJdET5dCV99AM+M0EWUY5rW4Pni7IP/Ut/ovhsfpoGESe4AtRmj/jal88uVSpe+4bCbZpCCBrqxM X-Received: by 2002:a63:7044:: with SMTP id a4-v6mr1300215pgn.63.1540361138916; Tue, 23 Oct 2018 23:05:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540361138; cv=none; d=google.com; s=arc-20160816; b=EabNDRJz/6p+DuSWTLoaRzODrEHpj5APBVYzGpOc1oM3B1jvUuSHjJgyaOvhlG4/KY vYy44jxsUKKamuYi31tsqADxHSKHEObqgM4FDgK9ZjHQwhTnNXhCLHNcfmHtGParugAH kCQhT2JWnO7i63w3F39ZvP+EDfwBRrcgPEL3ZWcH2PoZjseMs7hN7TFPwBnEkJSs7lRa eajVnA4h2r3Hoa0gAaPOcsT4rezwFELYVbPwCS52vbOWRjkV+/aEHODcdAdEQSUYEqme rEINE+763hi6CRoITAN4z9xrfV6qzqKlXoa+zWP2i1f/RVuVkeS+qScjPiLVeslSXCLx CREw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=7XflMtnCzKZRF+oWK4Pk1/dX7RHw++Fwdo9f71/Hnu0=; b=lcGTBTVSUtgc+ZPlBq+VksUAehJwmkj56GXt3RDF2h6WphGQaUC+CsfArelKBPxS7v vs5l8UaWdiRkCwc5+rQZPyhRACZzoN/zVt/UN+iG6Ao5oJB5u5fjheIPsE4IUKDwiF+u 8rRDzIOGaB9tgVUAAfuOSyuH38rZ1pm/lJIAU38kNSfE+eX+Qn/Z3/g1/p6SjkGj1IAS OcAS4xIqmuTSCwYGjFB+bqD09jGODkz9z1veXgfLj0m05abKtNkYbuWN4gZAhR+YV6OO h0BNbIgnRLkCV9+aP93depky+poyQ18/fNqEBzDEmIOQNyzbV17yVzVcc1Mqg9zHam64 rSKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24-v6si3759023pgk.315.2018.10.23.23.05.22; Tue, 23 Oct 2018 23:05:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbeJXObg (ORCPT + 99 others); Wed, 24 Oct 2018 10:31:36 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:52768 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726080AbeJXObf (ORCPT ); Wed, 24 Oct 2018 10:31:35 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A698C7D51925C; Wed, 24 Oct 2018 14:04:54 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.408.0; Wed, 24 Oct 2018 14:04:51 +0800 From: zhong jiang To: CC: , , , , , Subject: [PATCHv3] rtlwifi: rtl8723ae: Remove set but not used variables and #defines Date: Wed, 24 Oct 2018 13:52:09 +0800 Message-ID: <1540360329-65013-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org radiob_array_table' and 'radiob_arraylen' are not used after setting its value. It is safe to remove the unused variable. Meanwhile, radio B array should be removed as well. because it will no longer be referenced. Signed-off-by: zhong jiang Acked-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +---- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ---- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 -- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c index 5cf29f5..3f33278 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c @@ -509,13 +509,10 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw, int i; bool rtstatus = true; u32 *radioa_array_table; - u32 *radiob_array_table; - u16 radioa_arraylen, radiob_arraylen; + u16 radioa_arraylen; radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH; radioa_array_table = RTL8723E_RADIOA_1TARRAY; - radiob_arraylen = RTL8723E_RADIOB_1TARRAYLENGTH; - radiob_array_table = RTL8723E_RADIOB_1TARRAY; rtstatus = true; diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c index 61e8604..1bbee0b 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c @@ -475,10 +475,6 @@ 0x000, 0x00030159, }; -u32 RTL8723E_RADIOB_1TARRAY[RTL8723E_RADIOB_1TARRAYLENGTH] = { - 0x0, -}; - u32 RTL8723EMAC_ARRAY[RTL8723E_MACARRAYLENGTH] = { 0x420, 0x00000080, 0x423, 0x00000000, diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h index 57a548c..a044f3c 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h @@ -36,8 +36,6 @@ extern u32 RTL8723EPHY_REG_ARRAY_PG[RTL8723E_PHY_REG_ARRAY_PGLENGTH]; #define RTL8723ERADIOA_1TARRAYLENGTH 282 extern u32 RTL8723E_RADIOA_1TARRAY[RTL8723ERADIOA_1TARRAYLENGTH]; -#define RTL8723E_RADIOB_1TARRAYLENGTH 1 -extern u32 RTL8723E_RADIOB_1TARRAY[RTL8723E_RADIOB_1TARRAYLENGTH]; #define RTL8723E_MACARRAYLENGTH 172 extern u32 RTL8723EMAC_ARRAY[RTL8723E_MACARRAYLENGTH]; #define RTL8723E_AGCTAB_1TARRAYLENGTH 320 -- 1.7.12.4