Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp222754ima; Tue, 23 Oct 2018 23:30:18 -0700 (PDT) X-Google-Smtp-Source: AJdET5dlvcv4PvC7dG9pnyg9kCOFh7UQT0VCsFl+zHVrbESrn0O/zbtdNXuQKZqV7jF724pGUeGp X-Received: by 2002:a17:902:bcc3:: with SMTP id o3-v6mr1366911pls.66.1540362618113; Tue, 23 Oct 2018 23:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540362618; cv=none; d=google.com; s=arc-20160816; b=wH1+SKeu9K2C+WRuW3Nt4JCwjggK7Lb0y38KC0enpNsEpQmjA4zOFcJ6ineLU+xSxm H0InY9NrbJ6RCx5zTOuVC7n/SCplWtrjILidmyMhB6ZPpX7WIrp9Sa4BomXrOWwvJA6v qSayM199dlNkRtxBDAd6H6uOby+oFR6+II+feALcmNmrInjUlukWiN/1UJpfvQzYBpKh GEiGtwrbgJm2g5bn1CC8KjPRdZ0un+2jAnn/42KvwIXd+fglwWOSMZMV5OvY+CDMDVaf flvOCbqvZ4ugQ9QuCtCJH/budEL/JFtCSacLDLhh/DPJ51yLcs3/gUy0Mt1g9+5Uirc9 nmQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=bzvBsOpBXsd7gQ2AhOlr9g+7I5GSvFSfN+bZEDgLuXA=; b=dW1qwADpqwsOBz2+kAgzuO9Na/6TYm6mTdqhvt8KbR8yfZgcgW6pQoYAKPmCBZFfRi ulF9yJKHmh8p12qX7b5MBDxoVAh0hZCGfHdO//VnjrDZdJKSmIcWiL3UlYWAszymlg19 TSSu0pd1nWAjHY3n1ePVkqWGD06dzKJu/T0EZ1u2WvbLfrVbuT5oRgewhEpR36IbyxCF 0lYteJW6YXWyXqcGTaP1F3hH36M8U4NzXgj/3/f+93ph9fz0OjwiO6OrkBP1hF2qXYYx Y6EiJWKSc8yBObgp/o0uiHP8o7Y27DmrCwWlJ0HA9ctqCgb6noA6avCDAiBnqz2r7rn1 INwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o10-v6si3410001plk.295.2018.10.23.23.30.03; Tue, 23 Oct 2018 23:30:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726949AbeJXO4U (ORCPT + 99 others); Wed, 24 Oct 2018 10:56:20 -0400 Received: from mail-sh2.amlogic.com ([58.32.228.45]:38319 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbeJXO4T (ORCPT ); Wed, 24 Oct 2018 10:56:19 -0400 Received: from [10.18.29.185] (10.18.29.185) by mail-sh2.amlogic.com (10.18.11.6) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 24 Oct 2018 14:29:24 +0800 Subject: Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver To: Stephen Boyd , Jerome Brunet , Neil Armstrong CC: Yixun Lan , Kevin Hilman , Carlo Caione , Michael Turquette , Rob Herring , Miquel Raynal , Boris Brezillon , Martin Blumenstingl , Liang Yang , Jian Hu , Qiufang Dai , Hanjie Lin , Victor Wan , , , , References: <1539839245-13793-1-git-send-email-jianxin.pan@amlogic.com> <1539839245-13793-4-git-send-email-jianxin.pan@amlogic.com> <153988282130.5275.17528969137837015544@swboyd.mtv.corp.google.com> From: Jianxin Pan Message-ID: Date: Wed, 24 Oct 2018 14:29:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <153988282130.5275.17528969137837015544@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.29.185] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/10/19 1:13, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-17 22:07:25) [...] >> diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c >> new file mode 100644 >> index 0000000..5555e3f >> --- /dev/null >> +++ b/drivers/clk/meson/mmc-clkc.c >> @@ -0,0 +1,296 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * Amlogic Meson MMC Sub Clock Controller Driver >> + * >> + * Copyright (c) 2017 Baylibre SAS. >> + * Author: Jerome Brunet >> + * >> + * Copyright (c) 2018 Amlogic, inc. >> + * Author: Yixun Lan >> + */ >> + >> +#include > > clk-provider.h instead of clk.h?> Maybe we need to keep clk.h devm_clk_get() is called in mmc_clkc_register_mux() to get parent in from DTS. I'm sorry to miss this in previous reply. >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include [...]> > . >