Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp334235ima; Wed, 24 Oct 2018 01:59:35 -0700 (PDT) X-Google-Smtp-Source: AJdET5c4Vks4sVfwAYqyeEfZ5PmVZGTl2tY07FrMJbqVxbRG9TtNgLjLoTwAQKiWZMplTVENWHSb X-Received: by 2002:a63:588:: with SMTP id 130mr1695422pgf.273.1540371575134; Wed, 24 Oct 2018 01:59:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540371575; cv=none; d=google.com; s=arc-20160816; b=JIWNMOK9o1oJMTvZkK9wB6I7eL2JWspUpM98VsNGpGLJE4q9HlM+FEHt0l6fXP+mnK TxuUb8T/zbl2IlNODmuB1jzSf/a0g2mJ0M0NBAK5XofXwDNKDUPk745b1d9yhA7zDxVr xk9O6J2CJasuGmfy2T50Uh4PzSH7RU0Zkp2gfr0G87s56z2cyhDJnmbnCf0jfhGgOTCU wAcpEoCYQFRYgKLHP7+P6B/XmO+QXfjuy5DOhIHjn8m7N+wlackqhID+lwEIaHZaR6ba dkgjC/uY1UrEm73mFXCb4a053q/pvqgZO3+NYuuV/UqYwY4qvL+TlUFfwA1vEUlFc/47 qcHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=XBv6KqGIf71xyXRnMQYrzKLmuKH14/ChKXMZjZ3eXhg=; b=dUsLUaHlJ85FFrbJTJKnqfRFEC2WjoopsYA9jRv6v97RzreUFV4LXSuQXIQD/gqhqm KPWxkvL/VYlKd8NpQJYCjGLDtJqfPmh5Y4cy2hj4LE9+MKo/wpYSAymfQoAti4grlkFi frfn+yoxvudPnUoDf4hWmQ/CFNpZ7Mu/1x/TPBgYBfo967u0QLuWGPygNJSymCyMp77+ enSTEaaSEKxwnoDt7eCP9EchdEeBRYg1bXbQXgRptqJGV4DXwLqX7JDWrUkw2aoeKQuK 21Mo1gx/R67A/pVezhc228RT9ir57S6MX8DRvukE3Iz4xcWOnos9R++5LUzHrEljbxnu bZTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=pIdOmhiy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9-v6si4218240pfk.27.2018.10.24.01.59.20; Wed, 24 Oct 2018 01:59:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=pIdOmhiy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727862AbeJXR0B (ORCPT + 99 others); Wed, 24 Oct 2018 13:26:01 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:34663 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727530AbeJXR0A (ORCPT ); Wed, 24 Oct 2018 13:26:00 -0400 Received: by mail-wm1-f67.google.com with SMTP id f1-v6so1857271wmg.1 for ; Wed, 24 Oct 2018 01:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=XBv6KqGIf71xyXRnMQYrzKLmuKH14/ChKXMZjZ3eXhg=; b=pIdOmhiytNqGY1viYBaD+wa730cuLSDcFI6Y7FPYd7XiX6TzYZN8lAXRVcuQ2poVbF XMTCcDMRaGeJBKzl4cgxXMmU6O7QXtWCDmllfILWuplVN78EMY7sHk+F7gQ5h3cUTmYF bOgIl3UEboWcJQ/CoZCGziag/OMgx6z5BWO6Zb2cKA2KdjhvGo9Tnehn/RsSBdJBRQXr VMZo4VZg8eTbK09bfWj9etv7O2Ip5bXVnTq/dMQdMs7ZJ812x5MJpE7OvZQz326NWOpi 6oUq/l2ZV1UXEOIFvghSYI2Gy7unsZzDM65b517dUivAHDp1/I41eWfBzqssAgXC2KVV ELPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=XBv6KqGIf71xyXRnMQYrzKLmuKH14/ChKXMZjZ3eXhg=; b=EbRRjw0Ro6ljKcPR0xEqj0VBXaKK7g6AAdq5WONyhTke2WhVZuAeRXfmspXdkHLYrC 7zUji+OUmcDkJzSVVlADlfFMvHppYB+Ss/Y/6AX83J0kmgLKl+HaDEhB6hJsiRHzuYad oi1haHEb6m/xVpt9uzYv12DpXe30nPTiNA95tN3yR3khx18/bSiFqnbM24NOchQbI8ci Ap1bDE8kvnUia2sYXUIQ41cFif06doDMi2bagsxeVw/S/B3izZrgX+y1SJCL9FyjjD3b irnideFLlrnuD77SAbfEUHykNMzLs2Xm2CD/1VHrHOClkC+SFRAGxFuMVf41/5sRbS2b u4bQ== X-Gm-Message-State: AGRZ1gJWVVgAcwAmG50mNBpg47LeDLENkoBzMsa6qJB3Nk0EoAq919w0 a6oCtsMnAWHztp7juZfE20N9CA== X-Received: by 2002:a1c:1752:: with SMTP id 79-v6mr1730730wmx.145.1540371524476; Wed, 24 Oct 2018 01:58:44 -0700 (PDT) Received: from boomer ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id o201-v6sm4885975wmg.16.2018.10.24.01.58.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Oct 2018 01:58:43 -0700 (PDT) Message-ID: Subject: Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller From: Jerome Brunet To: Jianxin Pan , Neil Armstrong Cc: Yixun Lan , Kevin Hilman , Carlo Caione , Michael Turquette , Stephen Boyd , Rob Herring , Miquel Raynal , Boris Brezillon , Martin Blumenstingl , Liang Yang , Jian Hu , Qiufang Dai , Hanjie Lin , Victor Wan , linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 24 Oct 2018 10:58:42 +0200 In-Reply-To: <1539839245-13793-3-git-send-email-jianxin.pan@amlogic.com> References: <1539839245-13793-1-git-send-email-jianxin.pan@amlogic.com> <1539839245-13793-3-git-send-email-jianxin.pan@amlogic.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: > From: Yixun Lan > > Document the MMC sub clock controller driver, the potential consumer > of this driver is MMC or NAND. Also add four clock bindings IDs which > provided by this driver. > > Reviewed-by: Rob Herring > Signed-off-by: Yixun Lan > Signed-off-by: Jianxin Pan > --- > .../devicetree/bindings/clock/amlogic,mmc-clkc.txt | 31 ++++++++++++++++++++++ > include/dt-bindings/clock/amlogic,mmc-clkc.h | 17 ++++++++++++ > 2 files changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > create mode 100644 include/dt-bindings/clock/amlogic,mmc-clkc.h > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > new file mode 100644 > index 0000000..9e6d343 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.txt > @@ -0,0 +1,31 @@ > +* Amlogic MMC Sub Clock Controller Driver > + > +The Amlogic MMC clock controller generates and supplies clock to support > +MMC and NAND controller > + > +Required Properties: > + > +- compatible: should be: > + "amlogic,gx-mmc-clkc" > + "amlogic,axg-mmc-clkc" > + > +- #clock-cells: should be 1. > +- clocks: phandles to clocks corresponding to the clock-names property > +- clock-names: list of parent clock names > + - "clkin0", "clkin1" > + > +Parent node should have the following properties : > +- compatible: "amlogic,axg-mmc-clkc", "syscon". > +- reg: base address and size of the MMC control register space. I get why Stephen is confused by your description, I am too. The example contradict the documentation. The documentation above says that the parent node should be a syscon with the mmc register space. But your example shows this in the node itself. > + > +Example: Clock controller node: > + > +sd_mmc_c_clkc: clock-controller@7000 { > + compatible = "amlogic,axg-mmc-clkc", "syscon"; > + reg = <0x0 0x7000 0x0 0x4>; > + #clock-cells = <1>; > + > + clock-names = "clkin0", "clkin1"; > + clocks = <&clkc CLKID_SD_MMC_C_CLK0>, > + <&clkc CLKID_FCLK_DIV2>; > +}; > diff --git a/include/dt-bindings/clock/amlogic,mmc-clkc.h b/include/dt-bindings/clock/amlogic,mmc-clkc.h > new file mode 100644 > index 0000000..162b949 > --- /dev/null > +++ b/include/dt-bindings/clock/amlogic,mmc-clkc.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > +/* > + * Meson MMC sub clock tree IDs > + * > + * Copyright (c) 2018 Amlogic, Inc. All rights reserved. > + * Author: Yixun Lan > + */ > + > +#ifndef __MMC_CLKC_H > +#define __MMC_CLKC_H > + > +#define CLKID_MMC_DIV 1 > +#define CLKID_MMC_PHASE_CORE 2 > +#define CLKID_MMC_PHASE_TX 3 > +#define CLKID_MMC_PHASE_RX 4 > + > +#endif