Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp335304ima; Wed, 24 Oct 2018 02:00:45 -0700 (PDT) X-Google-Smtp-Source: AJdET5cFzcKv0tO09YAkkpBL/KpsBrHC8W6C18m/+brPtQgp4jE9WwEaIxodNBFFteNC5Sc87HMn X-Received: by 2002:a63:e00d:: with SMTP id e13-v6mr1729449pgh.114.1540371645510; Wed, 24 Oct 2018 02:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540371645; cv=none; d=google.com; s=arc-20160816; b=Wl+zB6WH83SypRUd3jgEaeYAf8AhiazhlG3dukl/8Og0g6wQw5rM1pSHiNuH3NoODg DciH5BTvcFIgMgV6XfSqEXZ+lQUm1jjWdjUP0LFojVIhg7wZXf0EfaJzOTtKMdpLF97l Htwiga4HP+bVOiV0YpbiM8/RCasBD40bHr63iuP618iY9zwZgC7pL19mzZZdZsroY+iu UJ0YVfy7jaG79yH0YGMf9oDdoJvCa2ezJX5WGOjv6knnwZwGny2XTSLVJQbyKzM7xavO XLxFxP9FOgicVEbSgQ2G2qaazE2VnH8sjOJkFcL4WMobV7ogeeL+kctDv5NkP98wsIXx 8sHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=roBxiORdi36LcJWdRJtQUC+hIJMMxf4kDcz6fRt+7EE=; b=HrWtAIbariCmkE6b9N05Lu3KvVMNJiRzRnKOLJ4IRM1m00Yt+Z6gW5cUQbbYhW6QPc RqXiseokgIkMgBFrGtUZjc30Nrs9i4cTzmH3KgiTTYSb5MsBkbCobVqBs1Z/QwPdp6qX akdKKf/N6vas3f3WqgH8vcnVS2O0/x1jifTncImRYXZ3g3Uix2Y59xmE2krgtsB98TGo Mk2PIRTQ1frqYZtUkelIIo3V+4nneAqYmVJnYwzi6sJD4RV2ZmoECDhKpC54cXFFzT/a 2PItc7bu9JIQhbvb4XKfhj/ZwS68/TRfC6+j6ABB/iDOdkS7nZA7jAQrtepAtXBYqYqj n/pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x33-v6si4147939pga.246.2018.10.24.02.00.27; Wed, 24 Oct 2018 02:00:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727788AbeJXR0y (ORCPT + 99 others); Wed, 24 Oct 2018 13:26:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:5526 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727508AbeJXR0y (ORCPT ); Wed, 24 Oct 2018 13:26:54 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 01:59:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,419,1534834800"; d="scan'208";a="85158266" Received: from sakethyx-mobl2.gar.corp.intel.com ([10.249.254.29]) by orsmga006.jf.intel.com with ESMTP; 24 Oct 2018 01:59:35 -0700 Date: Wed, 24 Oct 2018 11:59:34 +0300 (EEST) From: Jarkko Sakkinen X-X-Sender: jsakkine@jsakkine-mobl1 To: "Winkler, Tomas" cc: Jarkko Sakkinen , Jason Gunthorpe , Nayna Jain , "Usyskin, Alexander" , "Struk, Tadeusz" , "linux-integrity@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: RE: [PATCH] tpm: tpm_try_transmit() refactor error flow. In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9D9FB5D1@hasmsx109.ger.corp.intel.com> Message-ID: References: <20181016133716.17842-1-tomas.winkler@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9D9F5512@hasmsx109.ger.corp.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9D9F85F5@hasmsx109.ger.corp.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9D9FB5D1@hasmsx109.ger.corp.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Oct 2018, Winkler, Tomas wrote: > To the out label we jump after we are done with locality and cmd > read() before we jump to locality 'locality'. We will need to add > another variable to check If cmd_ready() was called or not in order to > get rid of the extran label, it's not internally tracked so far. I think this is fine. Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen I tested this by assigning rc error code instead of requesting locality in addition of testig unchanged code. /Jarkko