Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp336788ima; Wed, 24 Oct 2018 02:02:11 -0700 (PDT) X-Google-Smtp-Source: AJdET5eYbB57tzJO1QWexQafnKUcUp51UqWyJ9yv5yI/kR9SNhcBZMRgHYO3G3UuaZQxn5AKbsQd X-Received: by 2002:a63:7f0e:: with SMTP id a14-v6mr1740781pgd.296.1540371731825; Wed, 24 Oct 2018 02:02:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540371731; cv=none; d=google.com; s=arc-20160816; b=mFYfvvsBLKTz7Yjn/ZuPRyeWviS8gBd8j0nVIwl09lS6tWeQVSwdLW+xgS3GIGUWjq Ptf0rXBbzc1xc2N8aMKDD+b+/PBBBctJv2PixV70d5kKLeCnKAOhGrqo+b6f1zutLWym nsBnI4n0CQQtoRNiby0yw8/xl+hpGYjabm1vlQIHA0Xe/WorGOPu6KcyymtfgTRyTwy9 LRN3nI2aopy9P9UzdakAxLksb/OKueBHAEO/8ZFWFhtMZ1Y18my/fqnKCbDYNAYPcSJ7 jk5msXBVcdU94J+QA3O9x3Dy2HimcAsyjHhgjqQSU7Vpc/+/3mIe1X6gTv6i0NOJtwse U7IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-reaction:dlp-version:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=4YpxSkBc7Uex34OJxsh4XIEqhG4R8M98HyiHxr+UNlw=; b=nwls93zZVhkMHDG/zYFL88QvBqqKF891Dhu1CO6RmL/Ebnz1FNlcXI+3moQXFMuiuN iBEO/UDn+ZX6O59EGFDltix/waZB4LnhypVCU4OAB3fZa5BH29FfY4FteEi1FaHll9VG n4vXWfHQtcH2G26W5j4SQPdvSW+mIidZ5jui9cnO3YtxS/jjiXXCENF2QNB/+TnguWXX xXs+lFOBbM2gN/QcE+HIR9qWWdYsAoLwjynycpYUos30lHJrxC6wqsWffv8vllgJ9xY9 eBP9dr8gjQdwc0sr33CmXNRrgp552+lNajLwWLFb7POblz8yxWesMfLeFt6DtnJwR64F 3cNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t33-v6si4138521pgk.141.2018.10.24.02.01.56; Wed, 24 Oct 2018 02:02:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727969AbeJXR2o convert rfc822-to-8bit (ORCPT + 99 others); Wed, 24 Oct 2018 13:28:44 -0400 Received: from mga06.intel.com ([134.134.136.31]:47079 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727626AbeJXR2n (ORCPT ); Wed, 24 Oct 2018 13:28:43 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 02:01:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,419,1534834800"; d="scan'208";a="90811378" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 24 Oct 2018 02:01:28 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Oct 2018 02:01:28 -0700 Received: from hasmsx111.ger.corp.intel.com (10.184.198.39) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Oct 2018 02:01:27 -0700 Received: from HASMSX109.ger.corp.intel.com ([169.254.3.28]) by HASMSX111.ger.corp.intel.com ([169.254.5.194]) with mapi id 14.03.0319.002; Wed, 24 Oct 2018 12:01:26 +0300 From: "Winkler, Tomas" To: Jarkko Sakkinen CC: Jason Gunthorpe , Nayna Jain , "Usyskin, Alexander" , "Struk, Tadeusz" , "linux-integrity@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: RE: [PATCH] tpm: tpm_try_transmit() refactor error flow. Thread-Topic: [PATCH] tpm: tpm_try_transmit() refactor error flow. Thread-Index: AQHUZneRpMm4aXcqcE6txCcRpwrMbKUkg60wgAKFoACAAbSoMIAD6zIAgAA5PtCAAQ4lAIAAMqtQ Date: Wed, 24 Oct 2018 09:01:25 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9D9FC1E7@hasmsx109.ger.corp.intel.com> References: <20181016133716.17842-1-tomas.winkler@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9D9F5512@hasmsx109.ger.corp.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9D9F85F5@hasmsx109.ger.corp.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9D9FB5D1@hasmsx109.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmVhNzdkOTgtMTRiMi00NzhmLTkxMzQtMWQwNDU5M2E5ODY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWGFKUkV5eEtQNlVhYXdXczQxaFQ3SkVTZjA1K1E4UkMrYXh3bXUzbjRqU0M0S0szcWRPMjNvSEVUaURcLzdGMWIifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.252.19.114] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Tue, 23 Oct 2018, Winkler, Tomas wrote: > > To the out label we jump after we are done with locality and cmd > > read() before we jump to locality 'locality'. We will need to add > > another variable to check If cmd_ready() was called or not in order to > > get rid of the extran label, it's not internally tracked so far. > > I think this is fine. > > Reviewed-by: Jarkko Sakkinen > Tested-by: Jarkko Sakkinen > > I tested this by assigning rc error code instead of requesting locality in > addition of testig unchanged code. > Great Thanks Tomas