Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp363596ima; Wed, 24 Oct 2018 02:34:26 -0700 (PDT) X-Google-Smtp-Source: AJdET5fYJIGlcEkUScYvm6cdsaWcVH1yEtnV0aKdqDhuRHH8kXeTv2cjKUwDhHy+cozu1cDaUdRl X-Received: by 2002:a62:b50a:: with SMTP id y10-v6mr1907956pfe.199.1540373666056; Wed, 24 Oct 2018 02:34:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540373666; cv=none; d=google.com; s=arc-20160816; b=z02N9M6CvzfWK4rDxIaYflX7IhZtXnoExvuLxbWXFfuJ98jFx4mrOyWpPZvRvafjOk bwYt8uxK9MlyaAvrl2UDn7i9ei/DRGGxHjdaVDr4cHlGst/uXk+/ExD31mFItsrDwT4S ZNmtGWVOXsGPGWMwOwSEPo4hv3cWLhDiaeVzATPpzDj8+I0sj13NOyCnpGb02Rtw8GEB piqjflTVhz6vsedC52hEZwHGSCxQ+E6V8aSD7Nr9V2232qZDxjuUgBZPw08ozrCr5WO8 NyiPqf/lq4aGs4p74b8GJ3dKkjbRbf2v7PF3RoYaMRUtQiMuQ1ay/T4I4bZX91qemvdJ +vaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=pvvUtzLzmosOJ08XRXic8PI1doe5kZEh2S4HadyiVn0=; b=YYPb+M2Bq76VXXtlS2JmVCQQLg+iKWeQEnjfD54K1NgeBBh4FrK2BkYHcX5fVS/RNR dZ+Xq/Yopq74Co+F/z0ubbQGR11P+kNSEIzKZjZBEzl4onl6RwclHqziL1SrDzuPjoeG OlFJJLpX6ZRjUjk6B2SVl2a51JiJeGlLTGVsT2yI53pOdHYuvl0NGXwV6NmPuVpyoTGB kvgZaCeZD7mYAJnMtt3aa3Ui5delFDG2Je5nBMoC+dZEmDam6mB8jr5wpbKRu5jZ4yEH nusYuTMB81PzJdHErzx0QxvNbg6AW05ruknLl5p8lK6yQiC4EHYFG694QjQirQVuiCgH XEnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a135-v6si4558027pfd.241.2018.10.24.02.34.10; Wed, 24 Oct 2018 02:34:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbeJXR7I (ORCPT + 99 others); Wed, 24 Oct 2018 13:59:08 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14114 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726792AbeJXR7H (ORCPT ); Wed, 24 Oct 2018 13:59:07 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id AE670117CDC25; Wed, 24 Oct 2018 17:31:43 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.408.0; Wed, 24 Oct 2018 17:31:34 +0800 Subject: Re: [PATCH v2] f2fs: fix count of seg_freed to make sec_freed correct To: Yunlong Song , , , CC: , , , , , References: <1539168739-79848-1-git-send-email-yunlong.song@huawei.com> <1540368510-14270-1-git-send-email-yunlong.song@huawei.com> From: Chao Yu Message-ID: <6eed9a3c-120e-f920-58cd-7ce2a2b9bc16@huawei.com> Date: Wed, 24 Oct 2018 17:31:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1540368510-14270-1-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/10/24 16:08, Yunlong Song wrote: > When sbi->segs_per_sec > 1, and if some segno has 0 valid blocks before > gc starts, do_garbage_collect will skip counting seg_freed++, and this > will cause seg_freed < sbi->segs_per_sec and finally skip sec_freed++. > > Signed-off-by: Yunlong Song > Signed-off-by: Chao Yu Reviewed-by: Chao Yu Thanks,