Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181024075617.19548-1-xiaoning.wang@nxp.com> <20181024075617.19548-4-xiaoning.wang@nxp.com>
In-Reply-To: <20181024075617.19548-4-xiaoning.wang@nxp.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Wed, 24 Oct 2018 07:56:47 -0300
Message-ID: <CAOMZO5DFgd2RsjRojWaDBOc2XxD47aQ1fkhxXYX-7BCAJnnVdA@mail.gmail.com>
Subject: Re: [PATCH V2 4/5] spi: lpspi: enable runtime pm for lpspi
To:     xiaoning.wang@nxp.com
Cc:     Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Han Xu <han.xu@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Clark,

On Wed, Oct 24, 2018 at 5:01 AM Clark Wang <xiaoning.wang@nxp.com> wrote:
>
> Enable the runtime pm for lpspi module
>
> BuildInfo:
>         - U-Boot 2018.03-imx_4.14.y

This buildinfo piece is not very helpful in upstream. Please drop it.

> Signed-off-by: Han Xu <han.xu@nxp.com>
> Reviewed-by: Frank Li <frank.li@nxp.com>
> Signed-off-by: Xiaoning Wang <xiaoning.wang@nxp.com>

Also, it would be nice if your From field (Clark Wang) could match
your Signed-off-by (Xiaoning Wang).

As Mark mentioned in case this patch comes from Han Xu, then his name
should go into the From field instead.