Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp485110ima; Wed, 24 Oct 2018 04:37:51 -0700 (PDT) X-Google-Smtp-Source: AJdET5dWYr3jcKV2RREzd/cLINkZqtEtlHbTXEvbBJZw0Vy1Hwnyd/wrLBEZXlkUXIG2SD6YtgMW X-Received: by 2002:a62:64cc:: with SMTP id y195-v6mr2399655pfb.100.1540381071007; Wed, 24 Oct 2018 04:37:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540381070; cv=none; d=google.com; s=arc-20160816; b=FugXmIDFsYCPMUW98HCWK0u3G3RQG/2UQWNhkkWYHFU3vpJ48CKHEP5K1e1E31KIYs htdx3DzQxqDqOfl2wZ5f60UPm/Mf+Dw3wK0d9pYMkSsR8MDssC9KgDzwoL1jYVnKjmnE 49lmn78QLAMwXY91JzHEyF9fTod3HbBnby+q+1jaR0DL0QDg14icedpC5ZKaDW1ftbps RnkK2xi5Zc3SkDWEfrmGjxBbnIy4/WPrsWi9wFjKrYCXVbvUi1u1tw6Nagk9pBzpoKWn OnRb1w+crgEysFtZJZP1mIibXqFyNR80PpDq2U4NPqYmFFNHKuWhcEVEmwDxukKFUGZE LMPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=8D5JPRyxZwzLuzDbvWVS/rB6XrJcc8c2j+tFbk+4fSM=; b=s9M7F8lrd3EHAN1fH8GlC6F+8TYDZQ8hx/1C/G+XrwsqiryO59kPO6P7dxZzjc1nam KHqnbK9OnuCOPjdtQnSTfOCGjf8yO3+hHeqzxQNU9QcfQqMeJZ50EQiXNPR1oLJDml8M y2W8spnBsYUzLOiAi0Y+SUEyx+l9eBG7mvRgUmJfPKxSqeYEVr4CX99HCmQUkRP2Hw4B WzdRoqR1uAxXRan6e+VK/rp9C5zSqmhKgk03LsaOvUQHpxBAedUsQsWllnIhRWsD5MKr OZ6mRZcRXBIXjQXKxC8HUaIU1vUQTb+gwUi5X0tz+rZkUjRjuTDRapMFMqcBGQLpV3zj 7guw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Pd4HGz51; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7-v6si4780236pgl.345.2018.10.24.04.37.35; Wed, 24 Oct 2018 04:37:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Pd4HGz51; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727564AbeJXUES (ORCPT + 99 others); Wed, 24 Oct 2018 16:04:18 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:49766 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727302AbeJXUES (ORCPT ); Wed, 24 Oct 2018 16:04:18 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id w9OBaHh1075196; Wed, 24 Oct 2018 06:36:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1540380977; bh=8D5JPRyxZwzLuzDbvWVS/rB6XrJcc8c2j+tFbk+4fSM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=Pd4HGz519pBRJoKMk5vPY4eZZlaEbVphA6jL+6CjJQDi49P7FH/YR1ypa85AasWYQ hX1M67dYDXQdosG83OjDiNyTkhvi4WuJUHfXdxLjjTiV7hmkQC/DUTzifte9/2bhN4 eNeE8kQoNsP5dGApwGfA+WxqCb719V6dcHYYUdbo= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9OBaH19029964; Wed, 24 Oct 2018 06:36:17 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 24 Oct 2018 06:36:17 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Wed, 24 Oct 2018 06:36:17 -0500 Received: from [172.22.136.76] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9OBaHIu008147; Wed, 24 Oct 2018 06:36:17 -0500 Subject: Re: [RFC PATCH 0/3] M_CAN Framework rework To: Wolfgang Grandegger , , CC: , , References: <20181010142055.25271-1-dmurphy@ti.com> <8d7fcd11-b537-97c1-ee50-ba30f236b5ec@grandegger.com> From: Dan Murphy Message-ID: <1db25e4b-9b83-a234-b98f-e3c0c72d5e31@ti.com> Date: Wed, 24 Oct 2018 06:36:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <8d7fcd11-b537-97c1-ee50-ba30f236b5ec@grandegger.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wolfgang On 10/24/2018 02:43 AM, Wolfgang Grandegger wrote: > Hallo Dan, > > I will have a closer look later this week. Unfortunately you already > renamed file names and structs making the patch almost unreadable. More > soon.. > I tried to format the patch to eliminate the massive change but format patch kept giving me the same result. It is a massive change regardless not sure how else to make is smaller. I guess this is why I opt'd to just create the dedicated TCAN driver. Dan > Thanks for you patience, > > Wolfgang. > > Am 17.10.2018 um 22:21 schrieb Dan Murphy: >> Bump >> >> On 10/10/2018 09:20 AM, Dan Murphy wrote: >>> All >>> >>> This patch series creates a m_can core framework that devices can register >>> to. The m_can core manages the Bosch IP and CAN frames. Each device that >>> is registered is responsible for managing device specific functions. >>> >>> This rewrite was suggested in a device driver submission for the TCAN4x5x >>> device >>> Reference upstream post: >>> https://lore.kernel.org/patchwork/patch/984163/ >>> >>> For instance the TCAN device is a SPI device that uses a specific data payload to >>> determine writes and reads. In addition the device has a reset input as well >>> as a wakeup pin. The register offset of the m_can registers differs and must >>> be set by the device attached to the core. >>> >>> The m_can core will use iomapped writes and reads as the default mechanism for >>> writing and reading. The device driver can provide over rides for this. >>> >>> This patch series is not complete as it does not handle the CAN interrupts >>> nor can perform a CAN write. If this patch series is deemed acceptable I will >>> finish debugging the driver and post a non RFC series. >>> >>> Finally I did attempt to reduce the first patch with various git format patch >>> directives but none seemed to reduce the patch. >>> >>> Dan >>> >>> Dan Murphy (3): >>> can: m_can: Create m_can core to leverage common code >>> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >>> can: tcan4x5x: Add tcan4x5x driver to the kernel >>> >>> .../devicetree/bindings/net/can/tcan4x5x.txt | 34 + >>> drivers/net/can/m_can/Kconfig | 18 + >>> drivers/net/can/m_can/Makefile | 4 +- >>> drivers/net/can/m_can/m_can.c | 1683 +---------------- >>> .../net/can/m_can/{m_can.c => m_can_core.c} | 479 +++-- >>> drivers/net/can/m_can/m_can_core.h | 100 + >>> drivers/net/can/m_can/tcan4x5x.c | 321 ++++ >>> 7 files changed, 722 insertions(+), 1917 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >>> copy drivers/net/can/m_can/{m_can.c => m_can_core.c} (83%) >>> create mode 100644 drivers/net/can/m_can/m_can_core.h >>> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >>> >> >> -- ------------------ Dan Murphy