Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp576678ima; Wed, 24 Oct 2018 06:07:05 -0700 (PDT) X-Google-Smtp-Source: AJdET5chBlZXRV3pDozZYqaepnka11NRmNWBbSP5Bhm/HBKQRvD8sG+nUGKUElFyt3nkNtYty/W7 X-Received: by 2002:a62:2904:: with SMTP id p4-v6mr2541329pfp.233.1540386425155; Wed, 24 Oct 2018 06:07:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540386425; cv=none; d=google.com; s=arc-20160816; b=HW/+b8qxTRaXXvNFCaI80pplZ7gtW9e6zieE5UycHDdf2Y4NPvycGeRubHFlQjAR5B oBGyxEmOWTccb9IpYVt7/DD7siYhHc6tkD21J/RN5IhyZKJM4AGJj6hexjYMVQHXsddu XPePH/LMlOsUmH0u5Vfa7n9pD3BLb5PNqvyzgBjvYTTLEmauGTF+nAZnOZhki1yf/5CS 0C6YWa8hfL1+UKMdOz0z43Q9f1DAdMD3BqqUJrdH5DALFUsAL+hN2KlV8w2OrZjYOFuF jFmwMawqAUgNu+13pWeYpAlQIRUlrUt6EUZ1QiHzsF70ol2Z/zFqNzt9/50EmVO4NASG 2aug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=zp/ysz7KwWpJ0AGzAaASKg9cLkaBbq7VFQ3rrmh42jA=; b=fqH0fXba+QyCfecvb8QVjhx9SbouqbZfgmXpwFJ1lyJClADMQj/x/H3zLxKTCV6JQu Qv96svlxtrAPkTHF2ykdAJHfX0YT2DQTU/lrPvu/lmwQvniaAB2CJrcsqkMrrkgbo3fg CiPJQWG+lsSb9AFuYMeOvg7s0pRIqoETomjhad1Vdn71OwzP6asSZxAC54UcjKjlKvns Ukk0p7uFHAX2hiiCYIzH4yusgQQqnd4OOY2zwwl/dbxS4cGRE8Az22NaKR2sjDWH6H7u dfMbXl4Vwoae9ryRYcvYQS4z8VgdoZT4dhhdlKQcgeyGTthj+8qU8KGIT48yAWmHj9GK Fj8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a16-v6si4422081pgw.187.2018.10.24.06.06.39; Wed, 24 Oct 2018 06:07:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbeJXVdM (ORCPT + 99 others); Wed, 24 Oct 2018 17:33:12 -0400 Received: from mga12.intel.com ([192.55.52.136]:25390 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbeJXVdM (ORCPT ); Wed, 24 Oct 2018 17:33:12 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 06:05:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,420,1534834800"; d="scan'208";a="100281727" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga004.fm.intel.com with ESMTP; 24 Oct 2018 06:05:05 -0700 Received: from andy by smile with local (Exim 4.91) (envelope-from ) id 1gFIqO-0004jP-PY; Wed, 24 Oct 2018 16:05:04 +0300 Date: Wed, 24 Oct 2018 16:05:04 +0300 From: Andy Shevchenko To: Dan O'Donovan Cc: linux-kernel@vger.kernel.org, Mika Westerberg , Heikki Krogerus , Lee Jones , Linus Walleij , Jacek Anaszewski , Pavel Machek , linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org, Carlos Iglesias Subject: Re: [PATCH v2 0/3] UP Squared board drivers Message-ID: <20181024130504.GU10650@smile.fi.intel.com> References: <20180421085009.28773-1-javier@emutex.com> <1539969334-24577-1-git-send-email-dan@emutex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1539969334-24577-1-git-send-email-dan@emutex.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 19, 2018 at 06:15:31PM +0100, Dan O'Donovan wrote: > Hi all, > > This series adds platform support for AAEON's UP Squared, a x86 SBC > based on Apollo Lake [1]. Specifically, it enables control for the board > pin headers and for the LEDs, as both of these features are only > available behind a FPGA-based platform controller. > > This is structured around a MFD driver that provides a regmap interface > to that platform controller to each MFD cell. > > The series is carved out from an out-of-tree support patchset, initially > written for the original UP Board [2] and then extended through the past > year to support new entries in the lineup (UP Board, UP Squared and > UP Core) [3]. > > Here we only submit support for UP Squared to simplify review. Still, > the driver is designed so that it can easily gain support for the other > boards. > > V1 was originally submitted by Javier Arteaga in April 2018 as an RFC [4]. > This V2 aims to address the feedback gratefully received from that. Are you attending ELCE in Edinburgh? > > [1]: http://www.up-board.org/upsquared/specifications-up2/ > [2]: https://lkml.kernel.org/r/1467648434-29080-1-git-send-email-dan@emutex.com > [3]: https://github.com/emutex/ubilinux-kernel/commits/upboard-4.9 > [4]: https://lore.kernel.org/lkml/20180421085009.28773-1-javier@emutex.com/ > > V2: > * Rewrote regmap r/w handlers to avoid duplication and improve readability > * Simplified data passing between MFD parent and child device drivers > * Removed incorrect __init attribute from probe functions > * Moved MFD cell definitions into same patch as MFD driver and simplified them > * Promoted some dev_dbg instances to dev_err for probe error cases > * Decoupled MFD cell reference from ACPI driver data > * Miscellanous coding style improvements > * Fixed license mismatches > > Javier Arteaga (3): > mfd: upboard: Add UP2 platform controller driver > leds: upboard: Add LED support > pinctrl: upboard: Add UP2 pinctrl and gpio driver > > drivers/leds/Kconfig | 10 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-upboard.c | 104 ++++++++ > drivers/mfd/Kconfig | 17 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/upboard.c | 344 +++++++++++++++++++++++++ > drivers/pinctrl/Kconfig | 13 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-upboard.c | 519 ++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/upboard.h | 44 ++++ > 10 files changed, 1054 insertions(+) > create mode 100644 drivers/leds/leds-upboard.c > create mode 100644 drivers/mfd/upboard.c > create mode 100644 drivers/pinctrl/pinctrl-upboard.c > create mode 100644 include/linux/mfd/upboard.h > > -- > 2.7.4 > > > ------ > This email has been scanned for spam and malware by The Email Laundry. > -- With Best Regards, Andy Shevchenko