Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1540315748-29158-1-git-send-email-rplsssn@codeaurora.org>
In-Reply-To: <1540315748-29158-1-git-send-email-rplsssn@codeaurora.org>
From:   Evan Green <evgreen@chromium.org>
Date:   Wed, 24 Oct 2018 08:50:09 -0700
Message-ID: <CAE=gft6o8c4abTxa3JDeUTk_xkuZmtFXCx7+Ach1E-vv-cYzMw@mail.gmail.com>
Subject: Re: [PATCH RESEND] drivers: qcom: rpmh: avoid sending sleep/wake sets immediately
To:     rplsssn@codeaurora.org
Cc:     Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        sboyd@kernel.org, Doug Anderson <dianders@chromium.org>,
        mka@chromium.org, Lina Iyer <ilina@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 23, 2018 at 10:29 AM Raju P.L.S.S.S.N
<rplsssn@codeaurora.org> wrote:
>
> Fix the redundant call being made to send the sleep and wake requests
> immediately to the controller.
>
> As per the patch[1], the sleep and wake request votes are cached in rpmh
> controller and sent during rpmh_flush(). These requests needs to be sent
> only during entry of deeper system low power modes or suspend.
>
> [1]https://patchwork.kernel.org/patch/10477533/
>
> Signed-off-by: Raju P.L.S.S.S.N <rplsssn@codeaurora.org>
> Reviewed-by: Lina Iyer <ilina@codeaurora.org>
> ---
>  drivers/soc/qcom/rpmh.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c
> index e6e98d4..877fe78 100644
> --- a/drivers/soc/qcom/rpmh.c
> +++ b/drivers/soc/qcom/rpmh.c
> @@ -228,9 +228,8 @@ static int __rpmh_write(const struct device *dev, enum rpmh_state state,
>                 WARN_ON(irqs_disabled());
>                 ret = rpmh_rsc_send_data(ctrlr_to_drv(ctrlr), &rpm_msg->msg);
>         } else {
> -               ret = rpmh_rsc_write_ctrl_data(ctrlr_to_drv(ctrlr),
> -                               &rpm_msg->msg);
>                 /* Clean up our call by spoofing tx_done */
> +               ret = 0;
>                 rpmh_tx_done(&rpm_msg->msg, ret);
>         }
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of the Code Aurora Forum, hosted by The Linux Foundation.
>

I think this makes sense to me, though the paths through here can be a
little winding.

Reviewed-by: Evan Green <evgreen@chromium.org>