Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp772887ima; Wed, 24 Oct 2018 09:01:00 -0700 (PDT) X-Google-Smtp-Source: AJdET5dKu0uXZVsXoxN8BJQC+rFl8DkPMyUZMp0b2nvR87m7mcQ08Rcv7FFwYHtUWturb38cDVVc X-Received: by 2002:a63:9041:: with SMTP id a62mr3016389pge.163.1540396860432; Wed, 24 Oct 2018 09:01:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540396860; cv=none; d=google.com; s=arc-20160816; b=X488ZDYZc6fMxTs5xmg352dgjY9mMGiTuYfm88W0K2fGTzG6gI6tBr6XFIcXWzSpIY wLOj+/9GeUhsj7PEzyx5DGrpBapQTPX66ikHc9IqVmTx/IpZGPO/TvtqLfVAudXe+Y6B bzARs8XnA/P6C/y2yxq8XflfgBcFmNIB6xkFjJP/EFgLdelP52sV+CUtXEhimWGQIniO iO4qIO24iHs6u51X5/9mC5LB4CIrECRUqaMgKQ4yd2etH9VX4vVY8v7nByvWHwV2sRrG RGLCUdFangbVvKS7i/0+OcXCYIx7wju5SRSRzJ0cpj9c8VNFNtWPsvLNDfNg7LNmeOUH 4AVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=tkOD/tgaIRCmfNzSeuIvsxupgqvG6w6hzAPVZ07SxNU=; b=JHigRQ/ojBFjLPczJVmb+UnfKtl+CfL21EcMfO2taKhDRU1V4H1/ZqE49aMPawPVJ4 ODlGDDdmE/uKSAhvixN0hqIbXPkH8QdftyNkh4Ybb7955u5FbwthrbmLQxIG01vjiiee BofoB/Fbt02JKc3bgm4/+sVDsJL/uzQwa4MjB51UY5YEV019epQ/TAPbKPQ/A4eQhQRi 3uSFTb64o6St4BC85X+1y+AXYbckip9urdf9JJrSkcRgJrEfqpVTzuCxOyBIqjHt2a62 V/x53dUhaYVKBYzXjRZd3PDNVGmmDEuncr+EFV7JdlEPhR5+TLV/IRZiQ/5px5ZLm9Uu /ACA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=wESs8kVD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o6-v6si4852991plk.304.2018.10.24.09.00.44; Wed, 24 Oct 2018 09:01:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=wESs8kVD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727147AbeJYA2a (ORCPT + 99 others); Wed, 24 Oct 2018 20:28:30 -0400 Received: from mail-it1-f193.google.com ([209.85.166.193]:53424 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726433AbeJYA2a (ORCPT ); Wed, 24 Oct 2018 20:28:30 -0400 Received: by mail-it1-f193.google.com with SMTP id q70-v6so6807402itb.3 for ; Wed, 24 Oct 2018 08:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tkOD/tgaIRCmfNzSeuIvsxupgqvG6w6hzAPVZ07SxNU=; b=wESs8kVD9hLE5VddBF1BFnN3qv2+P9JgD/YkVOpajkmJ5Tek7XKoAPrLqoIhs00b2V k/u6iBpHIFJNfHT8bXj2m/ocOL0Nv4VexVotK6eiJde4XO+WRnScoD8CX3HO/gZasHFA jV9YnVON/s9WjHPYCT55T+k3Mh77H7e3hw/GJlv+n0YXBBUYAPH1Mu6ZFVZmmbK8vjoY AL/XRJDNkC/Jc76Yi/CypQCr6wxgupLGqZb+IjirXHYdAiWo8J0bydHHyahYOiDi5zzD 0TdbVuRecSzEPdbjjWrfyAXQnvMM1teEQ0ORNNaLfx/8WbtoWBGn2aH4EKeqKWSNsvKU 1yBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tkOD/tgaIRCmfNzSeuIvsxupgqvG6w6hzAPVZ07SxNU=; b=q+Wn9Df+FweWAsjaNp3b2PjTLDGvXnYNItijvCmKtamDwvkP088IYIvIiEZpuZeGOl MHeu51iUGBAG/IzTIBhKXw+yD6S67UMphVFGaVXoZBf8PVaOwbgT35S3w+/3UiXBNGpF 9e8q/to9sbQOQ7ERx+/Mtwsc8/mGVyX9zUyK+GoM4IbC/CqnLelaA/phl/OfFZ4SvyBw IZiFjcHfU64xD22S5WONHq1JrEBr7+W7HXdhDXfm8JKKP83fHsiXKpgXwV0an2afjj68 x/6uE/rb4KUaVS5AiCFdbywOg1EW/r9O7b+EM6opQ50mbFnQlzrj/apqKwCw+tiw6jQo 6r7A== X-Gm-Message-State: AGRZ1gL9kMoVSGpqh9maWMwEo0vk7dfjcmEeIsRo63j3SHuBCmBn71ZS wAmOs2O4ANGOBmqKMIb5YJHvt94kBnK5OJW+xplaFw== X-Received: by 2002:a24:74d4:: with SMTP id o203-v6mr1954916itc.81.1540396790956; Wed, 24 Oct 2018 08:59:50 -0700 (PDT) MIME-Version: 1.0 References: <20181024154729.5312-1-wanghaifine@gmail.com> In-Reply-To: <20181024154729.5312-1-wanghaifine@gmail.com> From: Eric Dumazet Date: Wed, 24 Oct 2018 08:59:39 -0700 Message-ID: Subject: Re: [PATCH] Change judgment len position To: wanghaifine@gmail.com Cc: David Miller , Alexey Kuznetsov , Hideaki YOSHIFUJI , netdev , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 24, 2018 at 8:47 AM Wang Hai wrote: > > To determine whether len is less than zero, it should be put before > the function min_t, because the return value of min_t is not likely > to be less than zero. ???? I really wonder if you actually tested this patch. Thanks.