Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp956151ima; Wed, 24 Oct 2018 11:51:30 -0700 (PDT) X-Google-Smtp-Source: AJdET5eFuTiLkut7/3GAlckqWtrAvMaltMKsM3m6kP/y70EzNWfwG3DDE7usOoO6sxf9P5QxzWXy X-Received: by 2002:a63:d805:: with SMTP id b5-v6mr3552208pgh.174.1540407090834; Wed, 24 Oct 2018 11:51:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540407090; cv=none; d=google.com; s=arc-20160816; b=u9VzFqNh9JGpK0rGpq79qWC+mdw64R9BgLk8ZV0BuP6eTYJzMHXhl61LTmZPaDxTku +UeLbzHtyZNadUSUErLQpKpBLZCup9bVWlL3X+IVUqz1x2r3cN/LMaP/jCvoaJ8H1haN 30EtoPP1lI1ZhrnxSOEr2rcXMcfKNoqhFghQe9jzA86/XYzr1MS07R3knK4gpMxwDvdh XpHLQUqBhq+HhO7Bi+4oLt2MqJs6eYL+oUyiDAYKfQ+SerOkEZvXkfYkXwHHAgmnq4ws BnJvzGDn2VtCssZeWduRPaE2Jb9C3mQ7iOjmpca07a7izXztKaZ/KCKg6HNV194PaU19 ai0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=rctWxg59tlU08TpLA4ZQSwL3ZtMAEx1lIshn+sbH+Y4=; b=pWvi9HQK3uui5DgRU8jfmkobzqUCaZvGPhiqwH3EHWRjCchfnIEFMSUP8uaguty7XJ 5fiZE07Sb/XeIjpeaEjbVHmYyvZG6xd3784hHmuGDsBsjAGU/e1NcH+MXEpggpkU0+LR UjEfHmrw4gyw5Pnycx3z6gvaxAN0FOB/R3EwIJUYOdFqdaYX8wozm6YPffHYiM4yQhcA yBQ6sQzU/9tol/VEUZHmMoiItIXt6A9TyEmWY1G/i9yJVhRm/Tsj0sJWmC7FGcww9pV3 hPjG8PrXncELC10WA54U30wTRtKW0XHXzpocLRtfMUOwoTYK7v0ih4aFPAYp6eKUIFuH +QTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kWjT7thn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q13-v6si513334pgm.239.2018.10.24.11.51.14; Wed, 24 Oct 2018 11:51:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kWjT7thn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727416AbeJYDUF (ORCPT + 99 others); Wed, 24 Oct 2018 23:20:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:44550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbeJYDUF (ORCPT ); Wed, 24 Oct 2018 23:20:05 -0400 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E02EC20834 for ; Wed, 24 Oct 2018 18:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1540407053; bh=rctWxg59tlU08TpLA4ZQSwL3ZtMAEx1lIshn+sbH+Y4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=kWjT7thnePojpiiOjfY+KTe56aAFahI/+ihS8y3t90ZrbHjcUeWUyNsLaOfTYCqtI kdn8gN6UqRocnNuXrDodsqJfRDsFyBi1U7MlT4728dzK9pUMdv8FXNnyqJZi1GxUgj m7D/ApTpeot3U5rROFWlSZiCMqYIrO1ZQy01jfCU= Received: by mail-wm1-f48.google.com with SMTP id w186-v6so6466559wmf.0 for ; Wed, 24 Oct 2018 11:50:52 -0700 (PDT) X-Gm-Message-State: AGRZ1gJfcYgB9Oo3iveb2/K+erNzhEig75O5gRhkFtrwF7tXTg7fDzAt vVAXf6lWzmYd8X597O1qJcT/cD/jzpcGsntGFGpJCw== X-Received: by 2002:a1c:9355:: with SMTP id v82-v6mr3899423wmd.128.1540407051398; Wed, 24 Oct 2018 11:50:51 -0700 (PDT) MIME-Version: 1.0 References: <20181023184234.14025-1-chang.seok.bae@intel.com> <20181023184234.14025-2-chang.seok.bae@intel.com> In-Reply-To: <20181023184234.14025-2-chang.seok.bae@intel.com> From: Andy Lutomirski Date: Wed, 24 Oct 2018 11:50:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v3 01/12] taint: Introduce a new taint flag (insecure) To: "Bae, Chang Seok" Cc: Ingo Molnar , Thomas Gleixner , Andrew Lutomirski , "H. Peter Anvin" , Andi Kleen , Dave Hansen , "Metzger, Markus T" , "Ravi V. Shankar" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 23, 2018 at 11:43 AM Chang S. Bae wrote: > > For testing (or root-only) purposes, the new flag will serve to tag the > kernel taint accurately. > > When adding a new feature support, patches need to be incrementally > applied and tested with temporal parameters. Currently, there is no flag > for this usage. I don't object to this patch per se, but it seems unnecessary to me. Especially since, once the whole series is applied, this code is again unused.