Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Oct 2018 19:57:27 +0100 (BST)
From:   Julia Lawall <julia.lawall@lip6.fr>
To:     Chunming Zhou <david1.zhou@amd.com>
cc:     kbuild-all@01.org, intel-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org,
        =?ISO-8859-15?Q?Christian_K=F6nig?= 
        <easy2remember.chk@googlemail.com>,
        Gustavo Padovan <gustavo@padovan.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm: fix call_kern.cocci warnings (fwd)
Message-ID: <alpine.DEB.2.21.1810241955110.3776@hadrien>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-944385150-1540407448=:3776"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-944385150-1540407448=:3776
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT

The containing function is called with a spin_lock held, so GFP_KERNEL
can't be used.

julia

---------- Forwarded message ----------
Date: Tue, 23 Oct 2018 17:14:25 +0800
From: kbuild test robot <lkp@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH] drm: fix call_kern.cocci warnings

CC: kbuild-all@01.org
CC: intel-gfx@lists.freedesktop.org
CC: dri-devel@lists.freedesktop.org
TO: Chunming Zhou <david1.zhou@amd.com>
CC: "Christian K?nig" <easy2remember.chk@googlemail.com>
CC: Gustavo Padovan <gustavo@padovan.org>
CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
CC: Sean Paul <sean@poorly.run>
CC: David Airlie <airlied@linux.ie>
CC: dri-devel@lists.freedesktop.org
CC: linux-kernel@vger.kernel.org

From: kbuild test robot <fengguang.wu@intel.com>

drivers/gpu/drm/drm_syncobj.c:202:4-14: ERROR: function drm_syncobj_find_signal_pt_for_point called on line 390 inside lock on line 389 but uses GFP_KERNEL

 Find functions that refer to GFP_KERNEL but are called with locks held.

Semantic patch information:
 The proposed change of converting the GFP_KERNEL is not necessarily the
 correct one.  It may be desired to unlock the lock, or to not call the
 function under the lock in the first place.

Generated by: scripts/coccinelle/locks/call_kern.cocci

Fixes: 48197bc564c7 ("drm: add syncobj timeline support v9")
CC: Chunming Zhou <david1.zhou@amd.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---

tree:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
head:   8d7ffd2298c607c3e1a16f94d51450d7940fd6a7
commit: 48197bc564c7a1888c86024a1ba4f956e0ec2300 [1968/2033] drm: add syncobj timeline support v9
:::::: branch date: 4 hours ago
:::::: commit date: 5 days ago

Please take the patch only if it's a positive warning. Thanks!

 drm_syncobj.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -199,7 +199,7 @@ static struct dma_fence
 	    (point <= syncobj->timeline)) {
 		struct drm_syncobj_stub_fence *fence =
 			kzalloc(sizeof(struct drm_syncobj_stub_fence),
-				GFP_KERNEL);
+				GFP_ATOMIC);

 		if (!fence)
 			return NULL;
--8323329-944385150-1540407448=:3776--