Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        "Michal Hocko" <mhocko@kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [RFC PATCH] mm: don't reclaim inodes with many attached pages
Thread-Topic: [RFC PATCH] mm: don't reclaim inodes with many attached pages
Thread-Index: AQHUau+GsFRIu7vNQ0mBGnFYa9WgU6Uu+XwAgAAZewA=
Date:   Wed, 24 Oct 2018 23:51:07 +0000
Message-ID: <20181024235101.GB15663@castle.DHCP.thefacebook.com>
References: <20181023164302.20436-1-guro@fb.com>
 <20181024151950.36fe2c41957d807756f587ca@linux-foundation.org>
In-Reply-To: <20181024151950.36fe2c41957d807756f587ca@linux-foundation.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c091:180::1:50a3]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;BY2PR15MB0870;20:cA3qX0HB+fdJXRitqt2Cf8Ck/tKuqzPYwLcXdO8dyR/qQ+qgMDdLIsYMcmz7gWKePtG64VG7cYf9Yta1t7dDbPqAAkeLgCi5QziNvOckk2cTkY8nMoJp3Sm63jprWNOnUnSgoXZKNvWxaOI7NJfUO46Eig71ajA5nLf18s2lxj0=
x-ms-office365-filtering-correlation-id: 5e727fe5-fe81-421c-30c4-08d63a0b910e
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:BY2PR15MB0870;
x-ms-traffictypediagnostic: BY2PR15MB0870:
x-microsoft-antispam-prvs: <BY2PR15MB08704191EE2235A4AF2203A2BEF60@BY2PR15MB0870.namprd15.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(67672495146484);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823302103)(3002001)(3231355)(11241501184)(944501410)(52105095)(10201501046)(93006095)(93001095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:BY2PR15MB0870;BCL:0;PCL:0;RULEID:;SRVR:BY2PR15MB0870;
x-forefront-prvs: 083526BF8A
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(366004)(346002)(136003)(39860400002)(396003)(199004)(189003)(53936002)(305945005)(8676002)(2900100001)(97736004)(7736002)(54906003)(81166006)(14454004)(8936002)(5250100002)(11346002)(476003)(478600001)(81156014)(316002)(2906002)(6486002)(4326008)(6916009)(5024004)(446003)(1076002)(9686003)(25786009)(99286004)(6116002)(6512007)(33656002)(68736007)(6246003)(76176011)(186003)(105586002)(6436002)(71200400001)(256004)(5660300001)(6506007)(106356001)(229853002)(102836004)(71190400001)(52116002)(46003)(33896004)(86362001)(386003)(486006)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR15MB0870;H:BY2PR15MB0167.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: 60YucXapT+ncCakUS+fdbVXmRPEcdHxwjc+TGB1e3ix64pCb0QukPUEccYcwrbgOSyA7LNXPIFzsLdMyvKuItyL8f+PFucoQsmfSS7h4CCCSZn/hSOCVaSpEE3VnWC6vWJeI4Vd2LOahB4jl6qePSnDh5rYVUlS0A0durifayilfmPjRCZdu/9BnS1eZrARFyS+7hbzFocoRWqKlfj5GLIS6bt1uJAsknbNaGj0zm7y9kqoidbds/2elEKHH51bojTXsxLhKRdVPqAQV/EZdPbJrCFdt1x3JHYotbFB+m0U2VPq08p4aRsIv3Vrg0fdxS+NhgV0au8tqGjOFS0qbdLDYS8ae5tknG6m55TYOT7s=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <79CFF4DBB7966C44A8429A0EEE6994C0@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e727fe5-fe81-421c-30c4-08d63a0b910e
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2018 23:51:07.7650
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR15MB0870
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-10-24_09:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 24, 2018 at 03:19:50PM -0700, Andrew Morton wrote:
> On Tue, 23 Oct 2018 16:43:29 +0000 Roman Gushchin <guro@fb.com> wrote:
>=20
> > Spock reported that the commit 172b06c32b94 ("mm: slowly shrink slabs
> > with a relatively small number of objects") leads to a regression on
> > his setup: periodically the majority of the pagecache is evicted
> > without an obvious reason, while before the change the amount of free
> > memory was balancing around the watermark.
> >=20
> > The reason behind is that the mentioned above change created some
> > minimal background pressure on the inode cache. The problem is that
> > if an inode is considered to be reclaimed, all belonging pagecache
> > page are stripped, no matter how many of them are there. So, if a huge
> > multi-gigabyte file is cached in the memory, and the goal is to
> > reclaim only few slab objects (unused inodes), we still can eventually
> > evict all gigabytes of the pagecache at once.
> >=20
> > The workload described by Spock has few large non-mapped files in the
> > pagecache, so it's especially noticeable.
> >=20
> > To solve the problem let's postpone the reclaim of inodes, which have
> > more than 1 attached page. Let's wait until the pagecache pages will
> > be evicted naturally by scanning the corresponding LRU lists, and only
> > then reclaim the inode structure.
>=20
> Is this regression serious enough to warrant fixing 4.19.1?

I'd give it some testing in the mm tree (and I'll test it by myself
on our fleet), and then backport to 4.19.x.

Thanks!