Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp1561667ima; Thu, 25 Oct 2018 00:54:13 -0700 (PDT) X-Google-Smtp-Source: AJdET5f6Ta3xAC9hF35uG6fM4Hb2eoLS57pcXnVU32jUmHYagKR7h4b/vgjGwmTQ+FGKpU2Ddyox X-Received: by 2002:a62:898d:: with SMTP id n13-v6mr514607pfk.57.1540454053816; Thu, 25 Oct 2018 00:54:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540454053; cv=none; d=google.com; s=arc-20160816; b=t4bG8DQnNzboH4f470S98R8sb2ZfSAyFkIf3kGhvjN15Rmgo82vA8A0f58uZjc+syi EYezDflB/dabP1VXS+k4xU/cSXfFclR57OfrnrMrrhwb59wGWJuHxZCdhIYLbKJ1SgCC ivqIjiaVJT7tOxeayWVFRBlX5NLPwEIw2IufPd8DvUhnziQZwXekcifJHuRoxxoOd9Ay wPXPWW4hDYlSCfsom8EwLHx2CVafW108DlvU6jWs6/UWo0C5TrvnGMAqsBrd1MkvBMpx 33bp0eA5EatmUwJgM3mPSt/BTNcRuu3WjldSyMtaKo+p0afwOiKJxSAwc3TDpjeAniRx Mb5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=CSFnvHNnXuTbF2gr3D3n5JGTlUutpW1f6VaBkb3L45M=; b=Dq171vZMe7IV73bI7wI8SiPsP9/B8AJFlBgOu/3v3ep6Zp3cAQKaywebU9W2YHujOl qcNG3zf0yQdMjq5pvNrSJxXNNUPKSl4tPXZxDMsNilhvDxtILFO8UXPvoNtyGQZHevU8 sYqfGEbmZnptIbTjNyILfBKnPWxpOCqmNl+h+qL/ki+VoQrTxVDT/A7OtLTA2SHerDVv a/oD1Wnf6x8V9CrCCvcu719Rny/P5Ov0Hp/PFHhGx3reFLXQBKyyZ+mnJy4veGBcifAF d/zwPg8z3xFnpk14psVbjsuq1ix6EiHp/TIQhs6Z0K+aVB8fYXGYH4UEejlIXaaOqiCP aD5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e17-v6si7083379pgb.19.2018.10.25.00.53.57; Thu, 25 Oct 2018 00:54:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727147AbeJYQXN (ORCPT + 99 others); Thu, 25 Oct 2018 12:23:13 -0400 Received: from mga05.intel.com ([192.55.52.43]:21756 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbeJYQXN (ORCPT ); Thu, 25 Oct 2018 12:23:13 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 00:51:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,423,1534834800"; d="scan'208";a="94874232" Received: from reinig-mobl1.ger.corp.intel.com (HELO [10.252.35.227]) ([10.252.35.227]) by orsmga003.jf.intel.com with ESMTP; 25 Oct 2018 00:51:36 -0700 Subject: Re: [PATCH] drm: fix call_kern.cocci warnings (fwd) To: =?UTF-8?Q?Christian_K=c3=b6nig?= , "Zhou, David(ChunMing)" , Julia Lawall Cc: "kbuild-all@01.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , Gustavo Padovan , Sean Paul , David Airlie , "linux-kernel@vger.kernel.org" References: <823eb7cc-ba7e-b816-1821-c73dfd4c70bf@googlemail.com> From: Maarten Lankhorst Message-ID: <8c956766-57ba-c6f7-405c-04a41ae926be@linux.intel.com> Date: Thu, 25 Oct 2018 09:51:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <823eb7cc-ba7e-b816-1821-c73dfd4c70bf@googlemail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 25-10-18 om 08:53 schreef Christian König: > Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing): >> Reviewed-by: Chunming Zhou > > NAK, GFP_ATOMIC should be avoided. > > The correct solution is to move the allocation out of the spinlock or drop the lock and reacquire. Yeah +1. Especially in a case like this where it's obvious to prevent. :)