Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 05/10] sched/fair: Hoist idle_stamp up from idle_balance
To:     Valentin Schneider <valentin.schneider@arm.com>, mingo@redhat.com,
        peterz@infradead.org
Cc:     subhra.mazumdar@oracle.com, dhaval.giani@oracle.com,
        rohit.k.jain@oracle.com, daniel.m.jordan@oracle.com,
        pavel.tatashin@microsoft.com, matt@codeblueprint.co.uk,
        umgwanakikbuti@gmail.com, riel@redhat.com, jbacik@fb.com,
        juri.lelli@redhat.com, linux-kernel@vger.kernel.org
References: <1540220381-424433-1-git-send-email-steven.sistare@oracle.com>
 <1540220381-424433-6-git-send-email-steven.sistare@oracle.com>
 <2a368b7c-3ecf-9b0c-a930-d2e739ea9b17@arm.com>
From:   Steven Sistare <steven.sistare@oracle.com>
Organization: Oracle Corporation
Message-ID: <3cec1fb2-d2f8-9693-178e-ac1b9aa77506@oracle.com>
Date:   Thu, 25 Oct 2018 10:04:52 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <2a368b7c-3ecf-9b0c-a930-d2e739ea9b17@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/25/2018 9:47 AM, Valentin Schneider wrote:
> Hi Steve,
> 
> On 22/10/2018 15:59, Steve Sistare wrote:
> [...]
>> @@ -6740,8 +6744,19 @@ static void check_preempt_wakeup(struct rq *rq, struct task_struct *p, int wake_
>>  	return p;
>>  
>>  idle:
>> +	/*
>> +	 * We must set idle_stamp _before_ calling idle_balance(), such that we
>> +	 * measure the duration of idle_balance() as idle time.
>> +	 */
>> +	IF_SMP(rq->idle_stamp = rq_clock(rq);)
>> +
>>  	new_tasks = idle_balance(rq, rf);
>>  
>> +	if (new_tasks)
>> +		IF_SMP(rq->idle_stamp = 0;)
>> +
>> +	schedstat_end_time(rq->find_time, time);
> 	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> That's a stray hunk from 10/10

Thanks Valentin, will fix in next version.  I reordered the patches and missed this.

- Steve