Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp1946637ima; Thu, 25 Oct 2018 07:24:34 -0700 (PDT) X-Google-Smtp-Source: AJdET5dl+JkM5R+RlmQsRHeF7v8J03i5fXq4SC5Nb8OOKyzl7NT1XtzdwCHapaDzAn5UFmOTvnFN X-Received: by 2002:a63:cd12:: with SMTP id i18-v6mr1702829pgg.319.1540477474054; Thu, 25 Oct 2018 07:24:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540477474; cv=none; d=google.com; s=arc-20160816; b=vWecAwPmjihJiY8ghrlbsSmdZNdN9gSOFvIgAsrK5+LRoPx+LnTmcpJCuPTzIH4Qgc UM2Hn5ohxPARSSnLlyNWFZLowNooc24Jdw66q8kdAMhaft+DyXaHR/Mzx4qNtth6O03n /b0BuT9/Mq0X7ULDTEDJxJ2SZ8W5vDIsJNjWc47x53J+MmSg9Yq8PC3Ek0K4RuM5wDd7 U+McFFgYnpKGyt/29Ya7PqF9vkCbBJrs20IuBP7gpQdvpwiWqk2CuTKlnpnl2p6RuBFa TK91WUhlx+LzgwyspqxERHJMfjco1hhczNwXz3LVrcpuUJ9brqTN5RPlHjSUfOPm9Jk6 9H7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=yahWW1Zd6yYsrh08cAFuluxlSKz3LIzN5hDhZVjwURs=; b=coxXSE5KgvRiXb8EEOi+lJZk8Cux64QDtQKR+gX0IVmPnbzksANwLX16KxGJCo+nh9 p4ts+8Et0W5GKFlwv3rsUQBUoL64BI5x1GskXg1WXMSMb/FTQr/gMOK2B8W1yRExGvgZ WN7Rqbl+O/jx399XIMkHsEpPA8tXyTKQnrfW83HTsYUF4Rf1SJtUI6yvWmqDcjP8YBs7 nr70Gta6AJE36XQoy0k905zYpJEORBpDErOdkSh1yJskKV/OKFa/lCDc7i51DX1ZTOq0 vqPdUXofBtiLIBfaeZ4pbooJf+Wian89e/gwKe8JWVqzzrrw34irTBv4r2VzvUAb2CLX S20g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=maujvyET; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n18-v6si7937648plp.294.2018.10.25.07.23.53; Thu, 25 Oct 2018 07:24:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=maujvyET; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731336AbeJYWx7 (ORCPT + 99 others); Thu, 25 Oct 2018 18:53:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:36712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731305AbeJYWx6 (ORCPT ); Thu, 25 Oct 2018 18:53:58 -0400 Received: from sasha-vm.mshome.net (unknown [167.98.65.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 120312148E; Thu, 25 Oct 2018 14:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1540477260; bh=hUCESz8cklmb6R6GteSAwU5G8f9bCgKxo885PuL4+zE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=maujvyETYFIvDoWX1E7FljsJVcoXx2w7pbyTjIfhmhcxq7Y40qlBjismIStNo+vhE iq1tU5M/0hE+Dw5ymsj3NkvrPQKr+lRYjJB1u+9eqEdXvMbIvQFqDH8ArEsUhpq7yC t3UPKrCdAcjPbdetSQE+qabLL0caEq6k4y6Kli4E= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sudip Mukherjee , "Martin K . Petersen" , Tejun Heo , Sasha Levin Subject: [PATCH AUTOSEL 3.18 83/98] libata: blacklist Micron 500IT SSD with MU01 firmware Date: Thu, 25 Oct 2018 10:18:38 -0400 Message-Id: <20181025141853.214051-83-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181025141853.214051-1-sashal@kernel.org> References: <20181025141853.214051-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudip Mukherjee [ Upstream commit 136d769e0b3475d71350aa3648a116a6ee7a8f6c ] While whitelisting Micron M500DC drives, the tweaked blacklist entry enabled queued TRIM from M500IT variants also. But these do not support queued TRIM. And while using those SSDs with the latest kernel we have seen errors and even the partition table getting corrupted. Some part from the dmesg: [ 6.727384] ata1.00: ATA-9: Micron_M500IT_MTFDDAK060MBD, MU01, max UDMA/133 [ 6.727390] ata1.00: 117231408 sectors, multi 16: LBA48 NCQ (depth 31/32), AA [ 6.741026] ata1.00: supports DRM functions and may not be fully accessible [ 6.759887] ata1.00: configured for UDMA/133 [ 6.762256] scsi 0:0:0:0: Direct-Access ATA Micron_M500IT_MT MU01 PQ: 0 ANSI: 5 and then for the error: [ 120.860334] ata1.00: exception Emask 0x1 SAct 0x7ffc0007 SErr 0x0 action 0x6 frozen [ 120.860338] ata1.00: irq_stat 0x40000008 [ 120.860342] ata1.00: failed command: SEND FPDMA QUEUED [ 120.860351] ata1.00: cmd 64/01:00:00:00:00/00:00:00:00:00/a0 tag 0 ncq dma 512 out res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x5 (timeout) [ 120.860353] ata1.00: status: { DRDY } [ 120.860543] ata1: hard resetting link [ 121.166128] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300) [ 121.166376] ata1.00: supports DRM functions and may not be fully accessible [ 121.186238] ata1.00: supports DRM functions and may not be fully accessible [ 121.204445] ata1.00: configured for UDMA/133 [ 121.204454] ata1.00: device reported invalid CHS sector 0 [ 121.204541] sd 0:0:0:0: [sda] tag#18 UNKNOWN(0x2003) Result: hostbyte=0x00 driverbyte=0x08 [ 121.204546] sd 0:0:0:0: [sda] tag#18 Sense Key : 0x5 [current] [ 121.204550] sd 0:0:0:0: [sda] tag#18 ASC=0x21 ASCQ=0x4 [ 121.204555] sd 0:0:0:0: [sda] tag#18 CDB: opcode=0x93 93 08 00 00 00 00 00 04 28 80 00 00 00 30 00 00 [ 121.204559] print_req_error: I/O error, dev sda, sector 272512 After few reboots with these errors, and the SSD is corrupted. After blacklisting it, the errors are not seen and the SSD does not get corrupted any more. Fixes: 243918be6393 ("libata: Do not blacklist Micron M500DC") Cc: Martin K. Petersen Cc: stable@vger.kernel.org Signed-off-by: Sudip Mukherjee Signed-off-by: Tejun Heo Signed-off-by: Sasha Levin --- drivers/ata/libata-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index cd589d012ef1..6629a5deccbd 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -4249,6 +4249,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { ATA_HORKAGE_NOLPM, }, /* devices that don't properly handle queued TRIM commands */ + { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM | + ATA_HORKAGE_ZERO_AFTER_TRIM, }, { "Micron_M500_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM, }, { "Crucial_CT*M500*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | -- 2.17.1