Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp1946783ima; Thu, 25 Oct 2018 07:24:40 -0700 (PDT) X-Google-Smtp-Source: AJdET5c2GCP/uFA0xIoQMAvXa+sM3jGn1hWLwancymTecek7JdwTs57YA2miD8nIL8GPdDWX72/d X-Received: by 2002:a17:902:b403:: with SMTP id x3-v6mr1743039plr.237.1540477480492; Thu, 25 Oct 2018 07:24:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540477480; cv=none; d=google.com; s=arc-20160816; b=yw92X2cEtykNDDRKmY7o7JUfMwZ5yodTkLpvFr/7qbBf/9MilhR1Z7Ui+k9/6SelBO zgy7vfG/THE/VIzkWHI6Qz/IjZGdbM8pgP+AJJHvnxVmvCxepe7jHnvhcYfVJzNYtTPQ CaHdTCx2lsOCzmYK3wsgu5eEbFI2XT6RARuf5Vzoc0PpicTvqZrIC8IZt3/Xf/X8PiWX QspOGs2WOVou+OFgKiqMsnKFGt+k8aTieONsxZ9cROq7J7i2m04AE5W0QKEupmY4ULyJ hD3es0sMI8aSBHnKreR//mTdvuqZZ1QXJyYIZbmXV1rOcnmH7tW9yjZj6LS7V+lMOKaR ml6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=qyuNf/Sxa2m1Etu1KA8ur96/M4IYN89HvI6qbNd4LUc=; b=YDtanK/Fs6NTjabn7gjrHf9grk5xeSXsmFdpS/91C6CBPmWw6PaL1MfCv0OTBe8jnJ 0WgeIJ+Z/b8eHrrbD+U8hFpmAjAlWR1kfqe58AxySJAFS42lrSbPLpwlClAIxfrIhfEr 0izB7GHiisqIcGggktlAwRrO6WCVpYDs5YVVq9M7VNi7C4YaAKskK3Y9CJXcj3euPmTU 4SeYjUC11KFkJpGaH1ROyul9IWyNK6FnUTnB573Nf48sc9CvEWMeLoBotIdilwrYrDn6 MqnPD7H++2ktuHLpyZJDK2R3BZ/UN+jglIIHXUaRrgbNlb2Hnrn81tIOxf7Nyop54k2W EXbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=s2Lz1ErL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y1-v6si8467083pgf.78.2018.10.25.07.23.59; Thu, 25 Oct 2018 07:24:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=s2Lz1ErL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731318AbeJYWx5 (ORCPT + 99 others); Thu, 25 Oct 2018 18:53:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:36670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731305AbeJYWx4 (ORCPT ); Thu, 25 Oct 2018 18:53:56 -0400 Received: from sasha-vm.mshome.net (unknown [167.98.65.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B68D421479; Thu, 25 Oct 2018 14:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1540477258; bh=DFj2vPUdIJ0F4tkD/+rAV590YYMY8c4guCnyOnIRghM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s2Lz1ErLKiXOXQdbBL4den2+zL4UYLNodjSWpHI3mCZnRo/RJqpbnFUCw6TMBWTF1 jUSclThWkf0qKdmhDyguvXrGPT07YTb0knGCLSKCq0d55kaKCQcxDo2cncaow1+55H 2JAwJnqidmkblJrID957koxwDHNyP0BHX4Dh+Uh8= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shota Suzuki , Jeff Kirsher , Sasha Levin Subject: [PATCH AUTOSEL 3.18 82/98] igb: Unpair the queues when changing the number of queues Date: Thu, 25 Oct 2018 10:18:37 -0400 Message-Id: <20181025141853.214051-82-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181025141853.214051-1-sashal@kernel.org> References: <20181025141853.214051-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shota Suzuki [ Upstream commit 37a5d163fb447b39f7960d0534de30e88ad395bb ] By the commit 72ddef0506da ("igb: Fix oops caused by missing queue pairing"), the IGB_FLAG_QUEUE_PAIRS flag can now be set when changing the number of queues by "ethtool -L", but it is never cleared unless the igb driver is reloaded. This patch clears it if queue pairing becomes unnecessary as a result of "ethtool -L". Signed-off-by: Shota Suzuki Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igb/igb_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 1ffad88e8a29..84049078c4f0 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -2941,6 +2941,8 @@ void igb_set_flag_queue_pairs(struct igb_adapter *adapter, */ if (adapter->rss_queues > (max_rss_queues / 2)) adapter->flags |= IGB_FLAG_QUEUE_PAIRS; + else + adapter->flags &= ~IGB_FLAG_QUEUE_PAIRS; break; } } -- 2.17.1