Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp1951853ima; Thu, 25 Oct 2018 07:29:16 -0700 (PDT) X-Google-Smtp-Source: AJdET5cDCIfGiDdSIrM/cgm21ZMtFpM4WJ8aJwqaMitXVGNg/W/1yqLbkM8ZIqXV3Z64BY7ZaL9X X-Received: by 2002:a63:e943:: with SMTP id q3-v6mr1706365pgj.42.1540477756520; Thu, 25 Oct 2018 07:29:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540477756; cv=none; d=google.com; s=arc-20160816; b=pVIB10WPw59Y0l8EWIybC4dhsxpyeMXYL0xSAa3c9vF2cSJc95CwCg3azUo/yEVwtd hbfbcZubYkKNGn5Xt5IEhJ2/Y1hR2Gq9JYgZxklekiSu1vfczYJIZfV1PbjldGDc1Cgc y9D0L4/bmqRm2hFGimt0QGC0WFrieb1EB5+8GhrmgZSAvqoy6R8GuE/GrIwCaEhN+XzP 4w+Z5Q/uRxfz8I43x17/EtPIRUmjOXwwBWIGu6HhzhxT9OS/GFofirhwXysOescFlbeh 3RiIsu1h2wS4zxRrKamqqTWf8LpufGO33oCbGB9UNi2TVDOsHfQzGoe9vRDKeyMqW8og j20w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=s99UsvwVgzJdkkXdrBCMxXpc+BxW13M4Ts19/+m77vg=; b=LEhJf7gCfH6I7DKM3pH4vl89E9ceWzMzzf/qoMO/0e1Ao6yLunt2Ty35fZB++k/xNn /rlEOiQ8qRWf3Mz5QGqlNmuLfo0YIdtMBQXiVrlHettoS4LSydWRjxlTENCMMi5gHeK9 YTmOMa0/k5V6GVTwPoondj0BZ3qTKtuIRjArj2wjI7kQ8N29lHOlyAZ3k9IYwNKBEtcT C8gRY36tlGTIaFPXfWCCKc0fALB6LvfADXArLHCUDt0TQDbwZ0SmNJZmxQyJcokVG3m+ 3pw8GhnVtoh6dFncZbgjN0LBJ0terc9jIqmdd/zpiQXhlUf+qF4wHfReoHbxJSCNNPYS DJmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=o2wq5Gde; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si7798410plw.203.2018.10.25.07.28.47; Thu, 25 Oct 2018 07:29:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=o2wq5Gde; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730617AbeJYWwf (ORCPT + 99 others); Thu, 25 Oct 2018 18:52:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:34630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730602AbeJYWwd (ORCPT ); Thu, 25 Oct 2018 18:52:33 -0400 Received: from sasha-vm.mshome.net (unknown [167.98.65.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ECA862086D; Thu, 25 Oct 2018 14:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1540477175; bh=T7sPpB8pf8Wh7F9UBSvshsMAujrfQnTTt3k70AoubrU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o2wq5Gde0+5Eq3o+B5MLGmSvNXmpaPXxYnEZWA36rNHY/9zymIeS9bHpu0BXbl8nR CsXasm0JHbpSagcRlEUQIVgLATcr5bYxsbZipLWuSjSYF2ZacbIxleux4Y3BYOWwnF lq89IODddn5eDANxXCuTTSe6GLwRKseRbJgnjQTo= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Trond Myklebust , Sasha Levin Subject: [PATCH AUTOSEL 3.18 27/98] NFSv4: Remove incorrect check in can_open_delegated() Date: Thu, 25 Oct 2018 10:17:42 -0400 Message-Id: <20181025141853.214051-27-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181025141853.214051-1-sashal@kernel.org> References: <20181025141853.214051-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Trond Myklebust [ Upstream commit 4e379d36c050b0117b5d10048be63a44f5036115 ] Remove an incorrect check for NFS_DELEGATION_NEED_RECLAIM in can_open_delegated(). We are allowed to cache opens even in a situation where we're doing reboot recovery. Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- fs/nfs/nfs4proc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index db8456b4ecb8..21906d2a13cc 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -1117,8 +1117,6 @@ static int can_open_delegated(struct nfs_delegation *delegation, fmode_t fmode) return 0; if ((delegation->type & fmode) != fmode) return 0; - if (test_bit(NFS_DELEGATION_NEED_RECLAIM, &delegation->flags)) - return 0; if (test_bit(NFS_DELEGATION_RETURNING, &delegation->flags)) return 0; nfs_mark_delegation_referenced(delegation); -- 2.17.1