Received: by 2002:ac0:aa62:0:0:0:0:0 with SMTP id w31-v6csp2279241ima; Thu, 25 Oct 2018 12:26:54 -0700 (PDT) X-Google-Smtp-Source: AJdET5dA8dA0uLdBwDLQmpvEru6F/w2HLh4+295wkRNjA+90lOs4njA/aRD/L/bZNkZXEaWPchzi X-Received: by 2002:a63:111c:: with SMTP id g28mr446219pgl.85.1540495614901; Thu, 25 Oct 2018 12:26:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540495614; cv=none; d=google.com; s=arc-20160816; b=ZRsF/SFX87eyplZC9T84hNzvmYPjCVDTat4lvTiX6nEFztFb6Cx3FXW/QvGm0zpoY9 3m1psAvYajyG8lzuyzc+f1QtJxlZzwavwceJk4QhjSOqxCWSZ4xDO1GntIPWeJbZZiEI pIE+v0I+vsIaRpN2rnGt0bmlnzNnL9gxXXt6QluMz/hWtyv5H5hCCAyI1htjX32mZIT5 Pvys+/NRRyk73QDNaol5ulJfeWJiycra6xKtT18NJGLeRZ8pGiFBT5yyh3gYCkOLGCyq /vXaq6aO9uZhBUnUPNUAMgxqlyb6x/tUc0eg3YYXrb2yfZXEFZTKnL/ebYIhTPWCRPsj HcyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=anMxU8BmYbrxflB/t4K72M1IoZqfBn3WtzMnyo+Yhxw=; b=M3MsZ+vDUj15iKqAKv6DrgRkmBJCQ7lAM7wWSLm+q5iTneN/oRT18m3wC6w8ciChSz HZP5ghn8kVgUpdRg1Q4POgSqsODgdSI6TZSfImRsgTJDIEEIhTBVYmc3NsW0H0PARMZ7 cGCnLlRAU4RgJGykLwmAD3IYf+lmwN5QqBU2cUl8lXcMBQb0t6lELBr43waiDvhK6+B5 Vw6PTiQtbJF0LWLY3PccWxah1Cc6u004v0q5+Ca7S66fzxmK5pzoq4+dcVAXc5NK9/vT J8/94UZtY3IwOfieUSf7keWbXV1GXDBZoY6yEbfaywHwFR9L5HObDVzQBNlH/+gTGbW7 qulw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u2-v6si3009424plm.284.2018.10.25.12.26.39; Thu, 25 Oct 2018 12:26:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727710AbeJZD7p (ORCPT + 99 others); Thu, 25 Oct 2018 23:59:45 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:41552 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727502AbeJZD7o (ORCPT ); Thu, 25 Oct 2018 23:59:44 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id w9PJPRIg056548; Thu, 25 Oct 2018 14:25:27 -0500 Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id w9PJPR3D037267 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 25 Oct 2018 14:25:27 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 25 Oct 2018 14:25:27 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Thu, 25 Oct 2018 14:25:27 -0500 Received: from [128.247.59.147] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9PJPRS7002329; Thu, 25 Oct 2018 14:25:27 -0500 Subject: Re: [PATCH net-next 0/4] net: ethernet: ti: cpsw: fix vlan mcast To: David Miller , CC: , , , , References: <20181024221059.21834-1-ivan.khoronzhuk@linaro.org> <20181025.113441.567599603045046210.davem@davemloft.net> From: Grygorii Strashko Message-ID: <12ca7599-e5f0-087f-674d-a887f3768913@ti.com> Date: Thu, 25 Oct 2018 14:25:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181025.113441.567599603045046210.davem@davemloft.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, On 10/25/18 1:34 PM, David Miller wrote: > From: Ivan Khoronzhuk > Date: Thu, 25 Oct 2018 01:10:55 +0300 > >> The cpsw holds separate mcast entires for vlan entries. At this moment >> driver adds only not vlan mcast addresses, omitting vlan/mcast entries. >> As result mcast for vlans doesn't work. It can be fixed by adding same >> mcast entries for every created vlan, but this patchseries uses more >> sophisticated way and allows to create mcast entries only for vlans >> that really require it. Generic functions from this series can be >> reused for fixing vlan and macvlan unicast. > > This is a bug fix but targetted at net-next, and indeed it is quite > invasive as it adds new core infrastructure and converts the generic > vlan code over to using it. > > Unfortunately net-next is closed. > > So if you want this bug fixed in mainline you will have to come up > with a less invasive fix, and resubmit this net-next approach when the > net-next tree opens back up. I think it's ok to wait as this issue was always here, so it's not critical. -- regards, -grygorii