Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1540485629-5970-1-git-send-email-alokc@codeaurora.org> <1540485629-5970-3-git-send-email-alokc@codeaurora.org>
In-Reply-To: <1540485629-5970-3-git-send-email-alokc@codeaurora.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Thu, 25 Oct 2018 13:06:52 -0700
Message-ID: <CAD=FV=VUB6jxQE61eXdFQBcc45uLz5Lc9PO2K4pmOY=6PjNDnQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] spi: spi-geni-qcom: Simplify probe function
To:     alokc@codeaurora.org
Cc:     Stephen Boyd <swboyd@chromium.org>,
        Mark Brown <broonie@kernel.org>,
        linux-spi <linux-spi@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Thu, Oct 25, 2018 at 9:40 AM Alok Chauhan <alokc@codeaurora.org> wrote:
>
> Re-arrange existing APIs in probe function to
> avoid using goto and remove redundant variables.
>
> Signed-off-by: Alok Chauhan <alokc@codeaurora.org>
> ---
>  drivers/spi/spi-geni-qcom.c | 49 ++++++++++++++++++++++-----------------------
>  1 file changed, 24 insertions(+), 25 deletions(-)

I agree that this is what Stephen was looking for in his review
feedback.  I personally thought it was fine the way it was but I have
no objections to this.  Thanks for following up.

Reviewed-by: Douglas Anderson <dianders@chromium.org>