From: Peter Chubb <peter@chubb.wattle.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16375.57972.132841.32878@wombat.chubb.wattle.id.au>
Date: Sun, 4 Jan 2004 20:52:52 +1100
To: Jens Axboe <axboe@suse.de>
Cc: Hugang <hugang@soulinfo.com>, Bart Samwel <bart@samwel.tk>,
       Andrew Morton <akpm@osdl.org>, smackinlay@mail.com,
       Bartek Kania <mrbk@gnarf.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] laptop-mode-2.6.0 version 5
In-Reply-To: <20040102120327.GA19822@suse.de>
References: <20031231210756.315.qmail@mail.com>
	<3FF3887C.90404@samwel.tk>
	<20031231184830.1168b8ff.akpm@osdl.org>
	<3FF43BAF.7040704@samwel.tk>
	<3FF457C0.2040303@samwel.tk>
	<20040101183545.GD5523@suse.de>
	<20040102170234.66d6811d@localhost>
	<20040102112733.GA19526@suse.de>
	<20040102193849.6ff090da@localhost>
	<20040102120327.GA19822@suse.de>
Comments: Hyperbole mail buttons accepted, v04.18.
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 815
Lines: 20

>>>>> "Jens" == Jens Axboe <axboe@suse.de> writes:

Jens> The dump printk() needs to be changed anyways, the rw
Jens> deciphering is not correct. Something like this is more
Jens> appropriate:

Jens>	if (unlikely(block_dump)) { 
Jens>		char b[BDEVNAME_SIZE];
Jens>		printk("%s(%d): %s block %Lu on %s\n", current->comm, current-> pid, (rw & WRITE) ? "WRITE" : "READ",
Jens>		(u64) bio->bi_sector, bdevname(bio->bi_bdev, b)); 
Jens>	}

Please cast to (unsigned long long) not (u64) because on 64-bit
architectures u64 is unsigned long, and you'll get a compiler warning.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/