Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp218785imd; Fri, 26 Oct 2018 07:33:09 -0700 (PDT) X-Google-Smtp-Source: AJdET5eqxVefyqMYMrTW3pSqXFBqvYKx4daSXI3YCA4yJ9qP8v3cvvtIS9Do9NODXNfenFnl0brM X-Received: by 2002:a62:de05:: with SMTP id h5-v6mr3975389pfg.258.1540564389701; Fri, 26 Oct 2018 07:33:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1540564389; cv=none; d=google.com; s=arc-20160816; b=oFYjIgqpTziX9b6a+3wyLrbmGKMXrjstTZMzsKiWPTeLyxpp99VJL2l6hI1NjBPSSP 7GKP6j2E9WIlY8u+Xts4Gk6cymwNuoTbVv2z00jYed9GdPEIfPR1Mi4VfL/334qtKblW Imtku2ZOrsVBqhSdUMuHYBjUV5o0epl5GZm9zaBvUDmnI9vDiAL9eM3GVN8n3rUkLrnK IslTWGRD3PuB+BMXHbrVO1RVZbQBqNRayYjp2fUmnTL8NVgZEs2KVvNqcLuCpoWjb5Fk 6ScqYxCXkVDVx1DXIQ/cVNXpnu4faYMElWzlNdichs3ilE+RRtk/BqBCwuJtgkhfYvkK ncAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=9trSVi7jXyd9RnhGg9BZFWoB2w1goqvrHO33GUiPOak=; b=PtUBGEee/b0AzQcyMsqQE/fXJst/7So3CU8/8e5+5HAKQRG8bEz7jWB7kbA78Dlh2r 23ppVlHfigNWnCxuA6IWPOAU5WzNuCuBzxIUY0FWl37EGJ/SafN1/hA0YW1Gj3vh8kwl aTVukvOCsuOPkWqy0FmeLLQyk1QIfU97wbWC8rlMXD59j/boVbcsustSkpX0+SqpO/pM 1IeVKMrV2wG+356JKx5nd4IfLpFq/c6jkdNCuPmhowsV2P7XsoADBJoGjuEdVgtK8Uar +qgdUyguNBmEN8yYfqXosVQEVf7p+wa7gkdi4AMvQBXk0Bc1VRyUdnu64ks6VuZ8Z9x5 3NVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e11-v6si3314842pgk.309.2018.10.26.07.32.53; Fri, 26 Oct 2018 07:33:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbeJZXIL (ORCPT + 99 others); Fri, 26 Oct 2018 19:08:11 -0400 Received: from mga03.intel.com ([134.134.136.65]:25653 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726113AbeJZXIL (ORCPT ); Fri, 26 Oct 2018 19:08:11 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 07:30:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,428,1534834800"; d="scan'208";a="81138198" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.193]) by fmsmga007.fm.intel.com with ESMTP; 26 Oct 2018 07:30:53 -0700 Date: Fri, 26 Oct 2018 07:30:53 -0700 From: Sean Christopherson To: "Stecklina, Julian" Cc: "digitaleric@google.com" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "js@alien8.de" , "pbonzini@redhat.com" Subject: Re: [PATCH 4/4] kvm, vmx: remove manually coded vmx instructions Message-ID: <20181026143052.GA20425@linux.intel.com> References: <09986c98c9655f1542768ecfda644ac821e67a57.1540369608.git.jsteckli@amazon.de> <1540550786.30273.55.camel@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1540550786.30273.55.camel@amazon.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 26, 2018 at 10:46:27AM +0000, Stecklina, Julian wrote: > On Wed, 2018-10-24 at 10:44 -0700, Eric Northup wrote: > > This loses the exception handling from __ex* -> > > ____kvm_handle_fault_on_reboot. > > > > If deliberate, this should be called out in changelog.? Has the race > > which commit 4ecac3fd fixed been mitigated otherwise? > > No, this was not deliberate. Will fix. This is already in kvm/next as commit 4b1e54786e48 ("KVM/x86: Use assembly instruction mnemonics instead of .byte streams"), this patch can be dropped.